Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp1627164rdb; Sun, 8 Oct 2023 17:52:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFDu0GbTea9dZuLDLCrxbVrpnixfhrrilBZFuALIVBVUiUrBjjuCDI4MHWY+HWFtExx/LiB X-Received: by 2002:a05:6a21:3e0c:b0:16d:e2dc:188e with SMTP id bk12-20020a056a213e0c00b0016de2dc188emr3805902pzc.57.1696812763183; Sun, 08 Oct 2023 17:52:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696812763; cv=none; d=google.com; s=arc-20160816; b=IYYSOUH7HyNimYiHBe5etO89WpeERbAa+9hE2AI6mlbpr3GXbrZk9CrQeonKm0IkDQ F678vh6EZc4Brh9ppmw54HS2nQTGdtk3jd44h4QGiXgC/klaX4gjEyMwTR9mYGEyPA7d +UWHKViqMMYgazzvXqF7kE6bWfGRup6Tk2agtbE+yflr6YUsfsN6wSzMiI9/aOBEu5fJ ma0gvT/yfLgS8sWDy2mLfd5r90+3zPC1VXpg1O28UI0vUMZFLq4twOw8J+L+dixlN/F7 Mgq6Ou+ZJ1UlFZ3/3Aunwjaw3WKznGSn0PMqArU3iGSk/Png56YBTPQTfPHlcRmu7drv /Ozg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=hJi7gp6ds0dyx/umqY590OIH88ZQY2QiqvpWYLSxHQI=; fh=CysQsv9tyiqoWW+U9aJLUTgPceadZxl6LhKGjBd3RKI=; b=HiGTS0pbvQX5Lev6NpHohEohQV6m4KiuY5mF/qM+VD7lrXrXgtEnqgCDv9M5MiHdnR 3rIff44mYrmClqSJs5TNcGqY/FGyuEIITfw7+ZmYhn4YDK7r6DOP6259Gn8J1zCxJIMg t0rIzmyvMnEm7HVgRO/q9/AKgACFNElroXMZENHrIbzgkWsY2G+LQoWQs46kYYXz7lAu lw2hjBrz5JxHpMFINbgtW33OFD9fDWu6YFEHpAsPs9IHMKtrIyhszvjgMAGLHZr0iHVM tEm+PLvFZvN2NbZpio77izQ8qtoABWdyuxEveSfAKvgrSzGmHIEikVVqotry6Lvwb25d Rt0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=nw4UFNW4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id v135-20020a63618d000000b00565e42df278si8299064pgb.759.2023.10.08.17.52.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Oct 2023 17:52:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=nw4UFNW4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id C5A9B809848B; Sun, 8 Oct 2023 17:52:31 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344778AbjJIAve (ORCPT + 99 others); Sun, 8 Oct 2023 20:51:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344723AbjJIAvb (ORCPT ); Sun, 8 Oct 2023 20:51:31 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE90FDB for ; Sun, 8 Oct 2023 17:51:28 -0700 (PDT) Received: from localhost.localdomain (unknown [179.221.49.143]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: koike) by madras.collabora.co.uk (Postfix) with ESMTPSA id 66766660708F; Mon, 9 Oct 2023 01:51:22 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1696812687; bh=ztOkjXVXo+152bze9eCJBR/08f5U6J3j1gYA9BVi8nE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nw4UFNW4POi/dV4HzSAxKuqDnOWfwvD8k/8pHId1EhPI8eOie/CF+QBePp+hmeiY+ gffzDCvllNzoYeARPTo4OlQ6cD8U3hhHfleCNbmS41i+jzN0Dk3+zC1B8euDlrI+Pt 7ZHRDXb2g7xx1zHqJnKMbRdwKFx6nT1G7aOu8ep7qL+rmhcskdWMuYHjEF8A2cOe4F QoxB06AAe015IfAAyrxGqGMxm8uEZnnvrZkFXRNWJIziUskbgwvAnEzf9JvBKBLaOp feyqu3H5IcCXkMwISQGxAXjr+QULLaoiHcqlKwBTe258/4dLkCQA6/Ck9mHFPnFQ0T ubKLhqB8lmNTQ== From: Helen Koike To: Helen Koike , David Airlie , Daniel Vetter , Matthias Brugger , AngeloGioacchino Del Regno Cc: robdclark@chromium.org, dmitry.baryshkov@linaro.org, vignesh.raman@collabora.com, sergi.blanch.torne@collabora.com, guilherme.gallo@collabora.com, david.heidelberg@collabora.com, quic_abhinavk@quicinc.com, quic_jesszhan@quicinc.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH 4/9] drm/ci: uprev IGT and make sure core_getversion is run Date: Sun, 8 Oct 2023 21:49:49 -0300 Message-Id: <20231009004953.203576-5-helen.koike@collabora.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231009004953.203576-1-helen.koike@collabora.com> References: <20231009004953.203576-1-helen.koike@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Sun, 08 Oct 2023 17:52:32 -0700 (PDT) X-Spam-Level: ** IGT has recently merged a patch that makes code_getversion test to fails if the driver isn't loaded or if it isn't the expected one defined in variable IGT_FORCE_DRIVER. Without this test, jobs were passing when the driver didn't load or probe for some reason, giving the ilusion that everything was ok. Uprev IGT to include this modification and include core_getversion test in all the shards. Signed-off-by: Helen Koike --- drivers/gpu/drm/ci/gitlab-ci.yml | 2 +- drivers/gpu/drm/ci/igt_runner.sh | 31 ++++++++++++++++++++++++------- drivers/gpu/drm/ci/image-tags.yml | 2 +- 3 files changed, 26 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/ci/gitlab-ci.yml b/drivers/gpu/drm/ci/gitlab-ci.yml index 522f83db1a07..9326522823bb 100644 --- a/drivers/gpu/drm/ci/gitlab-ci.yml +++ b/drivers/gpu/drm/ci/gitlab-ci.yml @@ -5,7 +5,7 @@ variables: UPSTREAM_REPO: git://anongit.freedesktop.org/drm/drm TARGET_BRANCH: drm-next - IGT_VERSION: 471bfababd070e1dac0ebb87470ac4f2ae85e663 + IGT_VERSION: d1db7333d9c5fbbb05e50b0804123950d9dc1c46 DEQP_RUNNER_GIT_URL: https://gitlab.freedesktop.org/anholt/deqp-runner.git DEQP_RUNNER_GIT_TAG: v0.15.0 diff --git a/drivers/gpu/drm/ci/igt_runner.sh b/drivers/gpu/drm/ci/igt_runner.sh index 2bb759165063..2f815ee3a8a3 100755 --- a/drivers/gpu/drm/ci/igt_runner.sh +++ b/drivers/gpu/drm/ci/igt_runner.sh @@ -20,11 +20,16 @@ set +e cat /sys/kernel/debug/dri/*/state set -e -# Cannot use HWCI_KERNEL_MODULES as at that point we don't have the module in /lib -if [ "$IGT_FORCE_DRIVER" = "amdgpu" ]; then - mv /install/modules/lib/modules/* /lib/modules/. - modprobe amdgpu -fi +case "$DRIVER_NAME" in + rockchip|mediatek|meson) + export IGT_FORCE_DRIVER="panfrost" + ;; + amdgpu) + # Cannot use HWCI_KERNEL_MODULES as at that point we don't have the module in /lib + mv /install/modules/lib/modules/* /lib/modules/. + modprobe amdgpu + ;; +esac if [ -e "/install/xfails/$DRIVER_NAME-$GPU_VERSION-skips.txt" ]; then IGT_SKIPS="--skips /install/xfails/$DRIVER_NAME-$GPU_VERSION-skips.txt" @@ -48,6 +53,20 @@ fi curl -L --retry 4 -f --retry-all-errors --retry-delay 60 -s ${FDO_HTTP_CACHE_URI:-}$PIPELINE_ARTIFACTS_BASE/$ARCH/igt.tar.gz | tar --zstd -v -x -C / + +# If the job is parallel at the gitab job level, take the corresponding fraction +# of the caselist. +if [ -n "$CI_NODE_INDEX" ]; then + sed -ni $CI_NODE_INDEX~$CI_NODE_TOTAL"p" /install/testlist.txt +fi + +# core_getversion checks if the driver is loaded and probed correctly +# so run it in all shards +if ! grep -q "core_getversion" /install/testlist.txt; then + # Add the line to the file + echo "core_getversion" >> /install/testlist.txt +fi + set +e igt-runner \ run \ @@ -57,8 +76,6 @@ igt-runner \ $IGT_SKIPS \ $IGT_FLAKES \ $IGT_FAILS \ - --fraction-start $CI_NODE_INDEX \ - --fraction $CI_NODE_TOTAL \ --jobs 1 ret=$? set -e diff --git a/drivers/gpu/drm/ci/image-tags.yml b/drivers/gpu/drm/ci/image-tags.yml index 6650b5a4d724..df94d8fb348e 100644 --- a/drivers/gpu/drm/ci/image-tags.yml +++ b/drivers/gpu/drm/ci/image-tags.yml @@ -4,7 +4,7 @@ variables: DEBIAN_BASE_TAG: "${CONTAINER_TAG}" DEBIAN_X86_64_BUILD_IMAGE_PATH: "debian/x86_64_build" - DEBIAN_BUILD_TAG: "2023-10-06-amd" + DEBIAN_BUILD_TAG: "2023-10-08-igt" KERNEL_ROOTFS_TAG: "2023-10-06-amd" -- 2.34.1