Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     "Liu, Yi L" <yi.l.liu@intel.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
CC:     "cohuck@redhat.com" <cohuck@redhat.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
        "yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
        "peterx@redhat.com" <peterx@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
        "Martins, Joao" <joao.m.martins@oracle.com>
Subject: RE: [PATCH v2 1/6] iommu: Add new iommu op to create domains owned by
 userspace
Thread-Topic: [PATCH v2 1/6] iommu: Add new iommu op to create domains owned
 by userspace
Thread-Index: AQHZ8duSU5XbTPBwc06Tv5gX+XskOrBAtr5A
Date:   Mon, 9 Oct 2023 01:09:48 +0000
Message-ID: <BL1PR11MB5271DC6104FECB86A26565828CCEA@BL1PR11MB5271.namprd11.prod.outlook.com>
References: <20230928071528.26258-1-yi.l.liu@intel.com>
 <20230928071528.26258-2-yi.l.liu@intel.com>
In-Reply-To: <20230928071528.26258-2-yi.l.liu@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dD8n3AqQ+FXJmPq0hCRezi956xa7mjdQQ4QW4OM6B227PF2J/oLv+f8LnAbp?=
 =?us-ascii?Q?tksF5RDJenFLhC/IijGSgxY30IkQwu8oYbtCK20uKNh/74OPEblryr0YeRy6?=
 =?us-ascii?Q?UBEJuOQI+dtTEXPoxSDFEHW6ACKR1F0sUv81fVmxMy1FoLbXZas+xqXtgpYM?=
 =?us-ascii?Q?XJY6ZoLJrCXxcyseICEGMaPMcVPS3Ka+cfTIrfeKbJeZcj4YM0d/IzO0+bLT?=
 =?us-ascii?Q?ijycz581DEgdDdr6JdwoFYYIZcDx3/kyEe5ISi4XSl2sNiS9+9K9m4rbtfFw?=
 =?us-ascii?Q?Er3Ixp2bRDRLDcip2Jbs5DTZp3CuzJbqcwgwYurPQaemZWfqLcuunr/5itIk?=
 =?us-ascii?Q?ZZPnnBHSHeQ/EcnsFJRdcHvBDS2+1x5PULj23G+WZBVg5oO08+TTO0F/ZhFM?=
 =?us-ascii?Q?eM+cRQrdJwMGNsb+mAdjgn86G42c1QOHMPIViKO1BPlHsD4OwpL4IRQw8IFp?=
 =?us-ascii?Q?Dy5gQmAXtYzx2ABWpnJWc1VKiwNm+MpRXkXjU863Ax9tvPGXYfeKiGnCvfTW?=
 =?us-ascii?Q?UmqHAkmRrxldwGJZ8Y54UzHKp2m/+N5wrGIRoKLa6zyWTYWBdc1nBPyL2A9r?=
 =?us-ascii?Q?QprRcx9RTeyIaymvOukdvvJilBsotc3LSEdMoSLiayBdQjdR1CkZBzcecAYX?=
 =?us-ascii?Q?RPeRLlQHqP8VEeIqWr0l5jTSkA68WoSxrxnuhrsl9/NtYKcpSC99Kied+Ug6?=
 =?us-ascii?Q?eCuYtbVrNMwiaI4o0YfjSLb5zB3yalIjgC9lJQnULX13tCk588cZrWAHUVUc?=
 =?us-ascii?Q?AgFDbC0WTGvWZcSAVJnWk2H6ydbBBO+KNX8AlwH8zC2yFse7u+bGxX1yP4yb?=
 =?us-ascii?Q?tG/8uj7349bkASAZeKLuNRdU3XXvDVxKTVHf369rUSV8uGWDP71kf5+4lXuv?=
 =?us-ascii?Q?YA4IVO8+mxnkUB6BcPoOLDQKoBaQ/DioaZRObwv1caJjcFRD4+BZre/JM7HL?=
 =?us-ascii?Q?Xzx93wrQgGdQakdlj5lIGxi4kALkROpY38ynPsfHzX/YULtcV/+siDNn4wNC?=
 =?us-ascii?Q?KaFSC7m+AzT95IoBVTi1I0pcI77C+3xulVU3pfquZ9I9/OAMa0koiTmmrlRn?=
 =?us-ascii?Q?6ugBwOTlSoTwATH+SpuzwVfgjkXHSswPX0rmOeunPFnJwS29IcfcWRxR09fz?=
 =?us-ascii?Q?96xG0lvvnT+WXlvwNmHlXBEO4BhlZG3JFYvCCyta0jEltxU/yaQDn8mfd2Ig?=
 =?us-ascii?Q?qK0dSYOsuJ9cEDLOu2gU92JsTMILNDs/vrIrH0aLtK5I8iKdAejnuYmh2lAB?=
 =?us-ascii?Q?C8tqe/aD4KXnUlGuvT9+kHG863h5Tf0Ma0Hhu8wi4K0Pamk1Yca7yTvz/0hC?=
 =?us-ascii?Q?i9SCQQ/QiQJeqnUB4OUn+kuCN0NN4n64+ooneALjPqQ7MtFJnM95nl6vSXNc?=
 =?us-ascii?Q?d2mImhWdrUY3+63SXcQNSl0u/wGokcdAuKx5mASxKK4eIx572Gx3DC/GMh8C?=
 =?us-ascii?Q?viC+P1ZQXOVINxso/4Q+weA3QDEvAgqKv3fQp23w3HsPT1l+oKl+3pHTsi0X?=
 =?us-ascii?Q?p/CSy4to083FD2zOjcQi6F5EFWP2OwBNX5Vh14IuvWP1wsNmhgaD0juwNQ?=
 =?us-ascii?Q?=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5271.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8893dbb5-a61f-4355-d424-08dbc8646edd
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Oct 2023 01:09:48.5052
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: OhIrUIwH22f/hkQnhucMUK+/5BppUOOii2bYs/a15HvBvfXA1HngnPh4To4s7sJ7PfnvP2LKOToMW2+LnZjl/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5445
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sun, 08 Oct 2023 18:10:06 -0700 (PDT)

> From: Liu, Yi L <yi.l.liu@intel.com>
> Sent: Thursday, September 28, 2023 3:15 PM
>=20
> Introduce a new iommu_domain op to create domains owned by userspace,
> e.g. through IOMMUFD. These domains have a few different properties
> compares to kernel owned domains:
>=20
>  - They may be UNMANAGED domains, but created with special parameters.
>    For instance aperture size changes/number of levels, different
>    IOPTE formats, or other things necessary to make a vIOMMU work
>=20
>  - We have to track all the memory allocations with GFP_KERNEL_ACCOUNT
>    to make the cgroup sandbox stronger
>=20
>  - Device-specialty domains, such as NESTED domains can be created by
>    IOMMUFD.
>=20
> The new op clearly says the domain is being created by IOMMUFD, that
> the domain is intended for userspace use, and it provides a way to pass
> user flags or a driver specific uAPI structure to customize the created
> domain to exactly what the vIOMMU userspace driver requires.
>=20
> iommu drivers that cannot support VFIO/IOMMUFD should not support this
> op. This includes any driver that cannot provide a fully functional
> UNMANAGED domain.
>=20
> This new op for now is only supposed to be used by IOMMUFD, hence no
> wrapper for it. IOMMUFD would call the callback directly. As for domain
> free, IOMMUFD would use iommu_domain_free().
>=20
> Suggested-by: Jason Gunthorpe <jgg@nvidia.com>
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> Co-developed-by: Nicolin Chen <nicolinc@nvidia.com>
> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> Signed-off-by: Yi Liu <yi.l.liu@intel.com>

Reviewed-by: Kevin Tian <kevin.tian@intel.com>