Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp1649485rdb; Sun, 8 Oct 2023 19:21:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGjkh+KkCCge2AJTtoAACmj8yyNnk5aJ1VPsWNHtNKodp5AChX7sBsfyY3JTTykvNOWtJHK X-Received: by 2002:a05:6808:2a53:b0:3a9:bb4f:9efd with SMTP id fa19-20020a0568082a5300b003a9bb4f9efdmr14116877oib.29.1696818104846; Sun, 08 Oct 2023 19:21:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696818104; cv=none; d=google.com; s=arc-20160816; b=ctP2UlDjCKOGd1ALuOkdEHwhA/nDh5zs6okAof6KKcTn+Fua5olX1KB+YwsgHfEWld 3axEdijyxXSvtwhDFZqJd6Jusrq3BooLviCXoyPH2UO6WOX09RF3WjG0WpzJay7Un6q7 D4jG36GJBp3T0i4ukmZ7Hm0pvpMBErgNPIp9uUllTh0WtIGMqtqTjMzdLGPxDAv6Z4MI lTwikLshGx96mx1IGZIlbJcSXRfYsj3xqV2uu5DTmYLYEAjGfIa3r5l9EnSlB1vklY+e c0/JNLVvwP+1OBbUZa2+p/eAnWHQDqXrgtJDuwkElTcbyY6vnLLYhToqJnjzzfFv1XWt p2+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=+eBNEV4qHZyOXv5xS3wKdsGZL8cmoZWOrqhrR5KUaOs=; fh=OlOBVN5OEBKLT4Y9KSAbFQgMwBo+tztdwemMnH261e4=; b=JjoshTlP3vZ5jAEku5zq1aBqfHjnncdbKWJoq7QWWwRJDiW2TtQFQdxGizh3ItOw5n tX0ASbuAHEaEDUnV3BdMkX3rorRxpw21ejAGzxNCMDEjXCw74znVzCKq0uxsJ5cdH9Pf Tcdy1dOJsfnGuYFSzsrH4yLkqT0CyhvoT9l1fEO621KqFtJHdRvGqsLjuypw11m6QXwo zK98zPZzBr5Vt+fiX+nCDwCG66TAKaA2GKXwV6Ye4Yg2UZcxc4YPWYXYX9QKUjUS7v4B fAHWB1rn8dCoOEAOHgdctjhs3YSBhp5bsDrhMQ2CuoChzqv7xjgxEVEtTry3gDuSPpwf 1LeQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b="GR6vFG/p"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id u185-20020a6385c2000000b005779c97fae5si8864602pgd.480.2023.10.08.19.21.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Oct 2023 19:21:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b="GR6vFG/p"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id A06928022595; Sun, 8 Oct 2023 19:21:42 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344984AbjJICVV (ORCPT + 99 others); Sun, 8 Oct 2023 22:21:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232250AbjJICVU (ORCPT ); Sun, 8 Oct 2023 22:21:20 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B43BA4; Sun, 8 Oct 2023 19:21:18 -0700 (PDT) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 246BA7E2; Mon, 9 Oct 2023 04:21:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1696818075; bh=ot+x92A9imuYrYSeW7vRsep0XLo94ZWmYnGMxer6Ljw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GR6vFG/p2D8Clyfe14u8xUOaJWw2cDwjjZfn5LdsgPKw8eCQ/cwbs6rjn5hN5Dyw1 TTrE7K83jX2w762UnHNKie2jN0Rcys7kpScvV+d8cONCOnl0odULCMvY8C76OG7rwY 3yjoVagkaPjdysFXMrNqWdMWD6N7+6JBStCCQYwY= Date: Mon, 9 Oct 2023 05:21:22 +0300 From: Laurent Pinchart To: Mehdi Djait Cc: mchehab@kernel.org, heiko@sntech.de, hverkuil-cisco@xs4all.nl, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, conor+dt@kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, alexandre.belloni@bootlin.com, maxime.chevallier@bootlin.com, paul.kocialkowski@bootlin.com Subject: Re: [PATCH v6 0/3] media: i2c: Introduce driver for the TW9900 video decoder Message-ID: <20231009022122.GH5121@pendragon.ideasonboard.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Sun, 08 Oct 2023 19:21:42 -0700 (PDT) X-Spam-Level: ** On Fri, Oct 06, 2023 at 06:25:27PM +0200, Mehdi Djait wrote: > Hello everyone, > > This series is based on the fifth iteration of the series introducing the > tw9900 driver: sent 29 Dec 2020 [1] > > This is the version 6 of the series adding support for the Techwell > TW9900 multi standard decoder. It's a pretty simple decoder compared to > the TW9910, since it doesn't have a built-in scaler/crop engine. > > Changes v5 => v6: > - dropped .skip_top and .field in the supported_modes > - added error handling for the i2c writes/reads > - added the colorimetry information to fill_fmt > - removed pm_runtime It's not very nice to keep the chip powered up all the time :-( > - added the g_input_status callback > - dropped SECAM > - dropped the non-standard PAL/NTSC variants > > Any feedback is appreciated, > > Mehdi Djait > > media_tree, base-commit: 2c1bae27df787c9535e48cc27bbd11c3c3e0a235 > > [1] https://lore.kernel.org/linux-media/20210401070802.1685823-1-maxime.chevallier@bootlin.com/ > > Mehdi Djait (3): > dt-bindings: vendor-prefixes: Add techwell vendor prefix > media: dt-bindings: media: i2c: Add bindings for TW9900 > media: i2c: Introduce a driver for the Techwell TW9900 decoder > > .../bindings/media/i2c/techwell,tw9900.yaml | 61 ++ > .../devicetree/bindings/vendor-prefixes.yaml | 2 + > MAINTAINERS | 6 + > drivers/media/i2c/Kconfig | 12 + > drivers/media/i2c/Makefile | 1 + > drivers/media/i2c/tw9900.c | 651 ++++++++++++++++++ > 6 files changed, 733 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/techwell,tw9900.yaml > create mode 100644 drivers/media/i2c/tw9900.c -- Regards, Laurent Pinchart