Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp1696135rdb; Sun, 8 Oct 2023 22:28:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGax0YdNH3qkFNDstQAbJx0kwS6HECebkycax9w8LVlDUKBmbRED/JqOBCgolMPfn37mAgJ X-Received: by 2002:a17:902:d50c:b0:1c8:75d9:f7dc with SMTP id b12-20020a170902d50c00b001c875d9f7dcmr15401295plg.28.1696829299799; Sun, 08 Oct 2023 22:28:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696829299; cv=none; d=google.com; s=arc-20160816; b=X8C7Njiz4k1X7FZlG1CHcF+LX3vHkw942VwWul2YqbcN5p3/xnVTFcjEl4AVlXDr3q 11S9Kfkg/+5ELcxkaPNxVRiZ1sQwBa/PiQZUNMzD9W5/mWnKHSXZgjFVRxtxSQf0yr+m /JzoXZHOhSAWNuGqAXoqkFhdXomNuy0FE9qmgClmpbDL/+SPifEbnfFwvG9MPBb1UZAW uDKZhPSq80zfP65tsUeEqTiq6UYd7V9lEPd87u/40IL5Cd3oOf1eqlTKiy6BkjqpgGyc bcHnpTU+oUjbggNFRXZfMilDa13VCxu/mrtAxKO9QBBdM4TJXjd5CW2rXDs9E2c74VRo Z+sQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id; bh=j+afoSmcF0IJhO5eazQTPFiwv2tSyRb98FrrmdVYsWo=; fh=eci5Yol8HVLIuSwZTY7aYwpyYjFxikSBETiy6AohGTs=; b=gngee5NK39ExoQqqv4AqBbOnrUBoMX08TGX0gH2eoDzW2/w9KEBEoCNkg6O5+2vLA6 m0eiBvwXn+CY1ltRO9lsWJ1fPpiN4z40PmGqLfrrqOsHRATCKVmiA2oElzpNShC9Wszh B6fB6WMc/Rqv/QMKagEeUoAM7qVHn4EJ0ceBcwgCbuyyhIWT6oaFW6kbJPm4kFEAX8lj Q/vI+jwbmVh4n930iI1N4oMahZEB1341+wqzEEDcn7JFh7ReuLoknQY90a02tdX66EuL XO3HvR/yQyfCbbc+E4/wpxUHZZ/dqtWM+ISR4XAtuLAHUev0EbhPaTFy/YZJ6ZXUtE1Y olnw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id z189-20020a6333c6000000b00577646e2b5bsi9085391pgz.652.2023.10.08.22.28.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Oct 2023 22:28:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 14E568097159; Sun, 8 Oct 2023 22:28:17 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345104AbjJIF2J (ORCPT + 99 others); Mon, 9 Oct 2023 01:28:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345049AbjJIF2I (ORCPT ); Mon, 9 Oct 2023 01:28:08 -0400 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77EC49E; Sun, 8 Oct 2023 22:28:06 -0700 (PDT) Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-9b27bc8b65eso682504166b.0; Sun, 08 Oct 2023 22:28:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696829285; x=1697434085; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=j+afoSmcF0IJhO5eazQTPFiwv2tSyRb98FrrmdVYsWo=; b=TsOq/gApMhwD4GgaTPXGLZxvLQMcS/1nJXG4LO2Kbc7laWaBWWYwAtFAiE6Wq/JJ0o VyixBd04Ciw+pCW4zyfEwdfPlRlmwxZdG4vbhCikvJauGsuRnUXL33IGbZsOzD+Zf0SE VT+cjOPP3aqXGkhhrxq90+C5ddg97lo1Ratyl7VIgd8X2jZBhXJKt31VWWIArDDbHT0h Jit1+zwqOKyLCl41rZnqFRNL7lnuItKGct0k8ba61TksL7HjSo63cjkbV2utPytYO83N EBAB48qowQxywOjUC3y+smCJwvel2Np2Sms5LjDKUxWPVlz72MTwusdk3HZygdZQsX8s l89g== X-Gm-Message-State: AOJu0YxoSRIoIW/RZJogDJmmdGjjqMVZmtmCo3In/81FxAHYeaCbAM8j g+pcPqN5cuN9Jlgzkev2JrHFGSGv/c0= X-Received: by 2002:a17:906:8a52:b0:9a9:e943:b601 with SMTP id gx18-20020a1709068a5200b009a9e943b601mr10352191ejc.46.1696829284703; Sun, 08 Oct 2023 22:28:04 -0700 (PDT) Received: from ?IPV6:2a0b:e7c0:0:107::aaaa:59? ([2a0b:e7c0:0:107::aaaa:59]) by smtp.gmail.com with ESMTPSA id by8-20020a170906a2c800b009b913aa7cdasm6290049ejb.92.2023.10.08.22.28.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 08 Oct 2023 22:28:03 -0700 (PDT) Message-ID: <68c4b7ee-345f-42e4-a69e-700384b711ad@kernel.org> Date: Mon, 9 Oct 2023 07:28:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] tty: vc_screen: make vc_class constant Content-Language: en-US To: Greg Kroah-Hartman , linux-serial@vger.kernel.org Cc: linux-kernel@vger.kernel.org References: <2023100546-humbly-prologue-e58c@gregkh> <2023100549-sixth-anger-ac34@gregkh> From: Jiri Slaby Autocrypt: addr=jirislaby@kernel.org; keydata= xsFNBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABzSFKaXJpIFNsYWJ5 IDxqaXJpc2xhYnlAa2VybmVsLm9yZz7CwXcEEwEIACEFAlW3RUwCGwMFCwkIBwIGFQgJCgsC BBYCAwECHgECF4AACgkQvSWxBAa0cEnVTg//TQpdIAr8Tn0VAeUjdVIH9XCFw+cPSU+zMSCH eCZoA/N6gitEcnvHoFVVM7b3hK2HgoFUNbmYC0RdcSc80pOF5gCnACSP9XWHGWzeKCARRcQR 4s5YD8I4VV5hqXcKo2DFAtIOVbHDW+0okOzcecdasCakUTr7s2fXz97uuoc2gIBB7bmHUGAH XQXHvdnCLjDjR+eJN+zrtbqZKYSfj89s/ZHn5Slug6w8qOPT1sVNGG+eWPlc5s7XYhT9z66E l5C0rG35JE4PhC+tl7BaE5IwjJlBMHf/cMJxNHAYoQ1hWQCKOfMDQ6bsEr++kGUCbHkrEFwD UVA72iLnnnlZCMevwE4hc0zVhseWhPc/KMYObU1sDGqaCesRLkE3tiE7X2cikmj/qH0CoMWe gjnwnQ2qVJcaPSzJ4QITvchEQ+tbuVAyvn9H+9MkdT7b7b2OaqYsUP8rn/2k1Td5zknUz7iF oJ0Z9wPTl6tDfF8phaMIPISYrhceVOIoL+rWfaikhBulZTIT5ihieY9nQOw6vhOfWkYvv0Dl o4GRnb2ybPQpfEs7WtetOsUgiUbfljTgILFw3CsPW8JESOGQc0Pv8ieznIighqPPFz9g+zSu Ss/rpcsqag5n9rQp/H3WW5zKUpeYcKGaPDp/vSUovMcjp8USIhzBBrmI7UWAtuedG9prjqfO wU0ETpLnhgEQAM+cDWLL+Wvc9cLhA2OXZ/gMmu7NbYKjfth1UyOuBd5emIO+d4RfFM02XFTI t4MxwhAryhsKQQcA4iQNldkbyeviYrPKWjLTjRXT5cD2lpWzr+Jx7mX7InV5JOz1Qq+P+nJW YIBjUKhI03ux89p58CYil24Zpyn2F5cX7U+inY8lJIBwLPBnc9Z0An/DVnUOD+0wIcYVnZAK DiIXODkGqTg3fhZwbbi+KAhtHPFM2fGw2VTUf62IHzV+eBSnamzPOBc1XsJYKRo3FHNeLuS8 f4wUe7bWb9O66PPFK/RkeqNX6akkFBf9VfrZ1rTEKAyJ2uqf1EI1olYnENk4+00IBa+BavGQ 8UW9dGW3nbPrfuOV5UUvbnsSQwj67pSdrBQqilr5N/5H9z7VCDQ0dhuJNtvDSlTf2iUFBqgk 3smln31PUYiVPrMP0V4ja0i9qtO/TB01rTfTyXTRtqz53qO5dGsYiliJO5aUmh8swVpotgK4 /57h3zGsaXO9PGgnnAdqeKVITaFTLY1ISg+Ptb4KoliiOjrBMmQUSJVtkUXMrCMCeuPDGHo7 39Xc75lcHlGuM3yEB//htKjyprbLeLf1y4xPyTeeF5zg/0ztRZNKZicgEmxyUNBHHnBKHQxz 1j+mzH0HjZZtXjGu2KLJ18G07q0fpz2ZPk2D53Ww39VNI/J9ABEBAAHCwV8EGAECAAkFAk6S 54YCGwwACgkQvSWxBAa0cEk3tRAAgO+DFpbyIa4RlnfpcW17AfnpZi9VR5+zr496n2jH/1ld wRO/S+QNSA8qdABqMb9WI4BNaoANgcg0AS429Mq0taaWKkAjkkGAT7mD1Q5PiLr06Y/+Kzdr 90eUVneqM2TUQQbK+Kh7JwmGVrRGNqQrDk+gRNvKnGwFNeTkTKtJ0P8jYd7P1gZb9Fwj9YLx jhn/sVIhNmEBLBoI7PL+9fbILqJPHgAwW35rpnq4f/EYTykbk1sa13Tav6btJ+4QOgbcezWI wZ5w/JVfEJW9JXp3BFAVzRQ5nVrrLDAJZ8Y5ioWcm99JtSIIxXxt9FJaGc1Bgsi5K/+dyTKL wLMJgiBzbVx8G+fCJJ9YtlNOPWhbKPlrQ8+AY52Aagi9WNhe6XfJdh5g6ptiOILm330mkR4g W6nEgZVyIyTq3ekOuruftWL99qpP5zi+eNrMmLRQx9iecDNgFr342R9bTDlb1TLuRb+/tJ98 f/bIWIr0cqQmqQ33FgRhrG1+Xml6UXyJ2jExmlO8JljuOGeXYh6ZkIEyzqzffzBLXZCujlYQ DFXpyMNVJ2ZwPmX2mWEoYuaBU0JN7wM+/zWgOf2zRwhEuD3A2cO2PxoiIfyUEfB9SSmffaK/ S4xXoB6wvGENZ85Hg37C7WDNdaAt6Xh2uQIly5grkgvWppkNy4ZHxE+jeNsU7tg= In-Reply-To: <2023100549-sixth-anger-ac34@gregkh> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=2.6 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Sun, 08 Oct 2023 22:28:17 -0700 (PDT) X-Spam-Level: ** On 05. 10. 23, 15:33, Greg Kroah-Hartman wrote: > Now that the driver core allows for struct class to be in read-only > memory, making all 'class' structures to be declared at build time > placing them into read-only memory, instead of having to be dynamically > allocated at load time. > > Cc: Jiri Slaby > Signed-off-by: Greg Kroah-Hartman > --- > drivers/tty/vt/vc_screen.c | 28 ++++++++++++++-------------- > 1 file changed, 14 insertions(+), 14 deletions(-) > > diff --git a/drivers/tty/vt/vc_screen.c b/drivers/tty/vt/vc_screen.c > index 829c4be66f3b..b16ea517bb17 100644 > --- a/drivers/tty/vt/vc_screen.c > +++ b/drivers/tty/vt/vc_screen.c ... > @@ -811,11 +810,12 @@ int __init vcs_init(void) > > if (register_chrdev(VCS_MAJOR, "vcs", &vcs_fops)) > panic("unable to get major %d for vcs device", VCS_MAJOR); > - vc_class = class_create("vc"); > + if (class_register(&vc_class)) > + panic("unable to create vc_class"); FWIW it's no longer "create". Now it's "register". Anyway, for the sake of archives: Reviewed-by: Jiri Slaby regards, -- js suse labs