Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Date:   Mon, 9 Oct 2023 13:13:45 +0800
From:   Yan Zhao <yan.y.zhao@intel.com>
To:     Yi Liu <yi.l.liu@intel.com>
CC:     <joro@8bytes.org>, <alex.williamson@redhat.com>, <jgg@nvidia.com>,
        <kevin.tian@intel.com>, <robin.murphy@arm.com>,
        <baolu.lu@linux.intel.com>, <cohuck@redhat.com>,
        <eric.auger@redhat.com>, <nicolinc@nvidia.com>,
        <kvm@vger.kernel.org>, <mjrosato@linux.ibm.com>,
        <chao.p.peng@linux.intel.com>, <yi.y.sun@linux.intel.com>,
        <peterx@redhat.com>, <jasowang@redhat.com>,
        <shameerali.kolothum.thodi@huawei.com>, <lulu@redhat.com>,
        <suravee.suthikulpanit@amd.com>, <iommu@lists.linux.dev>,
        <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
        <zhenzhong.duan@intel.com>, <joao.m.martins@oracle.com>
Subject: Re: [PATCH v4 03/17] iommufd: Unite all kernel-managed members into
 a struct
Message-ID: <ZSOMCXBzUMRujp89@yzhao56-desk.sh.intel.com>
Reply-To: Yan Zhao <yan.y.zhao@intel.com>
References: <20230921075138.124099-1-yi.l.liu@intel.com>
 <20230921075138.124099-4-yi.l.liu@intel.com>
 <ZSEuBcLaSq4NjoC8@yzhao56-desk.sh.intel.com>
 <c299567a-5be8-f65f-d8ec-ffd3fa183b03@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <c299567a-5be8-f65f-d8ec-ffd3fa183b03@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qUXEu6KTvXAzdHn/D2aROar30BFvyh6ZOQRsaBnZpJlx3LleEHm4KOLN/Ds3?=
 =?us-ascii?Q?6rTnCuHHkpKMVCeOzZuvoX4pVtDIvdHfm3vSULUramC5wegp7PhyLrepF9CC?=
 =?us-ascii?Q?MJJ0ZiquDhaasUf7IWp9C/UW2AozfuR2tCHPjT2Ib2Wgm40PFbIL/YtR28s8?=
 =?us-ascii?Q?u4d+BLL31TBBG7xKKdqYwMwI73M1sPpyyR1YT5vUoS4Ln6t9Gxp8yVGJ5YYY?=
 =?us-ascii?Q?a1xhSX83bRcZejbgcwvBjdZgfge/QxZFp7KlKXwiXzNZx/E+f7hPSdKLCpmM?=
 =?us-ascii?Q?4XNnleXRt+rSk5dI+khzsf1bQ0Oga7ICyEB8G6kUYmJYnvgB4hoDMKxjFog6?=
 =?us-ascii?Q?61Uer5fyn2sNOYE0LUHSJmBzPREGIUBOp8AuVSpMKYQvIR3KOkEHYONTKJEu?=
 =?us-ascii?Q?pqeazz4mKN/0a0Vq0XZ1h4rt20RyGmYJIVV2pun3NpV4XnkogpPYXbKkIwgV?=
 =?us-ascii?Q?1hUx5KK4fJfKcQxxPr2nxzEpgQlREPC460ceTYL6frE2Q1aQFp3jt42NV21Q?=
 =?us-ascii?Q?5zv9qd1FG2rYL8k54UC9WAbGt3m3h8F3TYvv0zdtqnfQlSwTbH10lz+zs7iE?=
 =?us-ascii?Q?vIEkaE4ntWYkALuNfL2eMG0lY3Xijgc+yiXnK4qKY+AcjJcEIHoP+uoTjjzD?=
 =?us-ascii?Q?j6hQGpwacgabnBSx3SeZOCAESKGX++ZEjfVUm0c+FX6TS5GP6r4Y7tLRGgFk?=
 =?us-ascii?Q?wJwItGnM480VLNcwDzZUcm/A42lI/0fbUp1JmhdVO6Hluw/suv46vR/kFZEG?=
 =?us-ascii?Q?pBduqw5iHN2Gv5hX9u2WQfvc+mwM4/8+RtIQ7I9cxFy+Q38BBbvbDck9tpVy?=
 =?us-ascii?Q?R6HIY95PZtg+LwYDM0rq+0pjSeqe5UHNTcb/xsP0vMwbV265cxSF7PvXnasb?=
 =?us-ascii?Q?o3VPmHCI2Z4kGjjadqDmzv2RF/XyOpX+aJOeVE08zHg+XLWoGtjP/UAQ7RwR?=
 =?us-ascii?Q?d+gEBxQo2/dJkOHlHCROURttXG3YKSF3CLjbRHi7fSyJR7uyS4whL2pomY59?=
 =?us-ascii?Q?DhNfztguDySxMrFJKoJoArSwWRi2ZK0RdjA/5oqpxjXf2q1t1hlpuXrXET7r?=
 =?us-ascii?Q?7D/c+xec7+72bJLW9QRBj522hlOUG7H/q4mlJnLEhRvp00+DRunULLsaRnla?=
 =?us-ascii?Q?fkZS/PJ1vKoTdVtuaYFO6e2ehBuE5n3Yb/7xMfl9pdvnVPwKSODP3gq3VwtS?=
 =?us-ascii?Q?AqByp+o4OIvYgdK9I3caR8nQP0yTbLeLZtxZRCzzF4HqaZW224HLXopD+49K?=
 =?us-ascii?Q?vKM5j0v+kjvvOvirj8ppZd7ldZRagR5eqfz6JmKvbnzLoMldMho4VdRUe8Ir?=
 =?us-ascii?Q?L/w0LIxrPTjckhN8R24wcajnU3KyKr3xo0GnAgGIZcq0szkNEtXo/fxFpJQY?=
 =?us-ascii?Q?Lc7S8VWWtbiKfdmwH4Xv6IqnEu1aW4QthlnjkI236dM9L5HYSNAWF/Xx1bQX?=
 =?us-ascii?Q?QdXjct1QpjrNb1BvMaCG1huu0s71Gu3nFVEKRpGUmmW9DahfXn/PT+hD3lBU?=
 =?us-ascii?Q?25r5AaoaFg5y8aeVIiLOq2x0XurPloWfS0vPMMVfMzESm6e6aE3CUXIuJek9?=
 =?us-ascii?Q?UHCJ8gfozXZBpQniQiTSP8pJvyRUfLZ2m/rMAH3W?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 52f2b7d1-6f21-4915-c2fc-08dbc88a70bb
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB5966.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2023 05:41:53.0597
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: G3Xa/1BjJVcVDw7ooh2HgP3Zni/Qzy+ubRaasMOvU8B0VYRZHe/Z29++yIb8E+65pXb5Tr+WNjK1PKu1drL4qQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8475
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Sun, 08 Oct 2023 22:42:18 -0700 (PDT)
X-Spam-Level: **

On Mon, Oct 09, 2023 at 12:13:52PM +0800, Yi Liu wrote:
> On 2023/10/7 18:08, Yan Zhao wrote:
> > On Thu, Sep 21, 2023 at 12:51:24AM -0700, Yi Liu wrote:
> > > From: Nicolin Chen <nicolinc@nvidia.com>
> > > 
> > > The struct iommufd_hw_pagetable has been representing a kernel-managed
> > > HWPT, yet soon will be reused to represent a user-managed HWPT. These
> > > two types of HWPTs has the same IOMMUFD object type and an iommu_domain
> > > object, but have quite different attributes/members.
> > > 
> > > Add a union in struct iommufd_hw_pagetable and group all the existing
> > > kernel-managed members. One of the following patches will add another
> > > struct for user-managed members.
> > > 
> > > Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> > > Signed-off-by: Yi Liu <yi.l.liu@intel.com>
> > > ---
> > >   drivers/iommu/iommufd/iommufd_private.h | 17 +++++++++++------
> > >   1 file changed, 11 insertions(+), 6 deletions(-)
> > > 
> > > diff --git a/drivers/iommu/iommufd/iommufd_private.h b/drivers/iommu/iommufd/iommufd_private.h
> > > index 3064997a0181..947a797536e3 100644
> > > --- a/drivers/iommu/iommufd/iommufd_private.h
> > > +++ b/drivers/iommu/iommufd/iommufd_private.h
> > > @@ -231,13 +231,18 @@ int iommufd_vfio_ioas(struct iommufd_ucmd *ucmd);
> > >    */
> > >   struct iommufd_hw_pagetable {
> > >   	struct iommufd_object obj;
> > > -	struct iommufd_ioas *ioas;
> > >   	struct iommu_domain *domain;
> > > -	bool auto_domain : 1;
> > > -	bool enforce_cache_coherency : 1;
> > > -	bool msi_cookie : 1;
> > > -	/* Head at iommufd_ioas::hwpt_list */
> > > -	struct list_head hwpt_item;
> > > +
> > > +	union {
> > > +		struct { /* kernel-managed */
> > > +			struct iommufd_ioas *ioas;
> > > +			bool auto_domain : 1;
> > Will iommufd_hw_pagetable_put() also be called on non-kernel-managed domain?
> 
> yes.
> 
> > If yes, hwpt->user_managed needs to be checked in iommufd_hw_pagetable_put(),
> > (e.g. as below).
> > Otherwise, this union will lead to hwpt->ioas and hwpt->auto_domain still being
> > accessible though invalid.
> 
> not quite get this sentence.
I mean with this union, hwpt->auto_domain or hwpt->ioas should only be accessed if and
only if hwpt type is kernel-managed.
So, any unconditional access, as in iommufd_hw_pagetable_put() pasted below, is buggy.

Therefore, do you think it's better to add a filed like "bool kernel_managed : 1",
and access the union fields under  /* kernel-managed */ only when hwpt->kernel_managed
is true.


> 
> > 
> >   static inline void iommufd_hw_pagetable_put(struct iommufd_ctx *ictx,
> >                                              struct iommufd_hw_pagetable *hwpt)
> >   {
> > -       lockdep_assert_not_held(&hwpt->ioas->mutex);
> > -       if (hwpt->auto_domain)
> > +       if (!hwpt->user_managed)
> > +               lockdep_assert_not_held(&hwpt->ioas->mutex);
> 
> this is true. this assert is not needed when hwpt is not kernel managed domain.
> 
> > +
> > +       if (!hwpt->user_managed && hwpt->auto_domain)
> 
> actually, checking auto_domain is more precise. There is hwpt which is
> neither user managed nor auto.

auto_domain is under union fields marked with kernel-managed only.
Access it without type checking is invalid.

struct iommufd_hw_pagetable {
        struct iommufd_object obj;
        struct iommu_domain *domain;

        void (*abort)(struct iommufd_object *obj);
        void (*destroy)(struct iommufd_object *obj);

        bool user_managed : 1;
        union {
                struct { /* user-managed */
                        struct iommufd_hw_pagetable *parent;
                };
                struct { /* kernel-managed */
                        struct iommufd_ioas *ioas;
                        struct mutex mutex;
                        bool auto_domain : 1;
                        bool enforce_cache_coherency : 1;
                        bool msi_cookie : 1;
                        bool nest_parent : 1;
                        /* Head at iommufd_ioas::hwpt_list */
                        struct list_head hwpt_item;
                };
        };
};

> 
> >                  iommufd_object_deref_user(ictx, &hwpt->obj);
> >          else
> >                  refcount_dec(&hwpt->obj.users);
> > }
> > 
> > > +			bool enforce_cache_coherency : 1;
> > > +			bool msi_cookie : 1;
> > > +			/* Head at iommufd_ioas::hwpt_list */
> > > +			struct list_head hwpt_item;
> > > +		};
> > > +	};
> > >   };
> > >   struct iommufd_hw_pagetable *
> > > -- 
> > > 2.34.1
> > > 
> 
> -- 
> Regards,
> Yi Liu