Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp1708932rdb; Sun, 8 Oct 2023 23:13:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHCx1/PMdiJkqcA7mBZwvBJXJAhuk0rqDpc8d+/yQjBb7ayg3grobyD0EfgXbR5vQovllLt X-Received: by 2002:a05:6870:14c1:b0:1be:c586:31ae with SMTP id l1-20020a05687014c100b001bec58631aemr16954205oab.40.1696832027000; Sun, 08 Oct 2023 23:13:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696832026; cv=none; d=google.com; s=arc-20160816; b=lEsLoBwogR7yupJPx4jzuc61CiIUzWvrY/c8OywW2LD7/g78/vBw0xACw+WIyAEvE2 p8y7yEYsFr1K/FgDGPjpCrug/De1C12yIq/ucz8nLmZ+inzmNnWhV2dgd44bYN8s+1fX uAZZIu+uEhB1XDPZTyLY2B61pAJScIOEq9X1MdPGsmJQKdrekZQ8LFJkezF7suvoL4at OyYntHawsH7KLnj8Jt6SIvvCdSGkCjyHFpElDImU7AjjHTLa+3dhWAedcAFgf59Z2ViW /hja37haJhbYiD0bkxW7ffZSOIc35MfMaUhPyM3pVPSC/lrgTEmSp+FZ6wSJ6WUoIM9g KCxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=isgfiMYnDUmKSuuL8ramwJORWRVET3xdFZwGhhbzB9c=; fh=fNDGVlggGhwBZT1A6LcXnmIf1JpDrbs4o9QXXpNp88g=; b=bFY0plUqUImpWWNzei5AMFTLaQWBMEM9Int0VLIR5yQT3W2y5e3IJyDSasjshbkkB5 elQ/2aCkeRmneaMIHzk221dFkIG/ZlijXKebMqkWu2nCX/9YRgcYXbYNQ/F8gRjV/EPt x7PVSpJZ43/tN+DHF/rUEgqPV5ou9MOO8a3n2o43IZblfev1F3ltppcBIE75h55udcBj +xKAKczXqt/htddHEbPHjQNVcFB39V9/aI9r5eiOCL8mqnxAh7OXssihEegkThHxXARe LUVdDUOgrh/gcj0f8LYSmJUIYUrz5gWD7yGHS4pUDDOU2KuC1r0WXCiCbPgBXvlI0LDa wxvw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="oWyg/PPf"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id cv12-20020a056a0044cc00b0068e243a72basi6662947pfb.330.2023.10.08.23.13.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Oct 2023 23:13:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="oWyg/PPf"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 7D188809C902; Sun, 8 Oct 2023 23:13:44 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345240AbjJIGNG (ORCPT + 99 others); Mon, 9 Oct 2023 02:13:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345223AbjJIGM6 (ORCPT ); Mon, 9 Oct 2023 02:12:58 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20AA9D47; Sun, 8 Oct 2023 23:12:50 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60681C433C9; Mon, 9 Oct 2023 06:12:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696831969; bh=qJEBc8o2ZV06sm/dmj3FbZTvrSDw0aYx8qLgkYtyhM8=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=oWyg/PPfQLgsreoGrYsB8yYD4BCn+DHGyL9ftulsoNJ5xYZzrS9kncTfgUp4ur8sk +h56OHM285gqKhEr6TH3FVo46QLAKZGxxHWkST31AjeuRoCr/Bx4Hmv+/fFumKOSOq oddosbzmWDKqSYNH9JKMjPxX7t7dXKfGFlBSlp4GDJbg2GsYWUt7ZyUCJ5Wkvmz5VY g57aKs7IuRQJkZfSCQyTNYGUncNXB+7CbVznYq035j6B+7L5hTUDlZIkj8h/sgBvFq 6fbWvH/jBVylJrKi64pzyhf7n8gbO6KdVyGrED9enjtLqHfmX9nv1hzfGgkSEsMTWq 6GUIDddCtNFbQ== From: Vinod Koul To: Maxime Coquelin , Alexandre Torgue , M'boumba Cedric Madianga , Pierre-Yves MORDRET , Amelie Delaunay Cc: stable@vger.kernel.org, dmaengine@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org In-Reply-To: <20231004163531.2864160-1-amelie.delaunay@foss.st.com> References: <20231004163531.2864160-1-amelie.delaunay@foss.st.com> Subject: Re: [PATCH 1/3] dmaengine: stm32-mdma: abort resume if no ongoing transfer Message-Id: <169683196592.44135.17868056770840545307.b4-ty@kernel.org> Date: Mon, 09 Oct 2023 11:42:45 +0530 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12.3 X-Spam-Status: No, score=2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Sun, 08 Oct 2023 23:13:44 -0700 (PDT) X-Spam-Level: ** On Wed, 04 Oct 2023 18:35:28 +0200, Amelie Delaunay wrote: > chan->desc can be null, if transfer is terminated when resume is called, > leading to a NULL pointer when retrieving the hwdesc. > To avoid this case, check that chan->desc is not null and channel is > disabled (transfer previously paused or terminated). > > Applied, thanks! [1/3] dmaengine: stm32-mdma: abort resume if no ongoing transfer commit: 81337b9a72dc58a5fa0ae8a042e8cb59f9bdec4a [2/3] dmaengine: stm32-mdma: use Link Address Register to compute residue commit: a4b306eb83579c07b63dc65cd5bae53b7b4019d0 [3/3] dmaengine: stm32-mdma: set in_flight_bytes in case CRQA flag is set commit: 584970421725b7805db84714b857851fdf7203a9 Best regards, -- ~Vinod