Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Date:   Mon, 9 Oct 2023 08:35:22 +0200
From:   Maciej =?utf-8?Q?Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>
To:     <babu.moger@amd.com>
CC:     Fenghua Yu <fenghua.yu@intel.com>,
        Reinette Chatre <reinette.chatre@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        "Ingo Molnar" <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, <x86@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>, Jonathan Corbet <corbet@lwn.net>,
        Peter Newman <peternewman@google.com>,
        Ilpo =?utf-8?B?SsOkcnZpbmVu?= <ilpo.jarvinen@linux.intel.com>,
        <linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>
Subject: Re: [PATCH v4 4/4] Documentation/x86: Document resctrl's new
 sparse_masks
Message-ID: <6swdqsa6anvhtdwfvj2xw55kfyih42w2buef4fc7wti54pvw2r@to4h2i76zqc6>
References: <cover.1696493034.git.maciej.wieczor-retman@intel.com>
 <7bbdf55ac6f909a6701915d99d79c8f9977bd0b4.1696493034.git.maciej.wieczor-retman@intel.com>
 <fd2309d5-ea56-abed-5c3e-a8a038b07d9e@amd.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <fd2309d5-ea56-abed-5c3e-a8a038b07d9e@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?xT4CCzx+D8UfBT+42we6U8V3USXILEnFM79OMqFOjNN1O8YFC+GQVZQ59G?=
 =?iso-8859-1?Q?mLS5ZBfyhfLtFqHsM0rCv9Hsn+tDSe55peJoqpW5skYOkJ8aBxEKNoAEDe?=
 =?iso-8859-1?Q?VW5DcRQLmSSQFOd+O3+PECzvvkmePoEfWy22Nu95BgtYcvf9+CZcGRvUwk?=
 =?iso-8859-1?Q?Ppzc3MDlrthzugNiIGCgBwLqtYlAshW3PXX3Gnkp1pTBRtv50Fm2do7UZg?=
 =?iso-8859-1?Q?j5wooNZ87SBlWPoz/ZDaKIs1apnw8QWCrnnbEnzmfRdl4wO33T92cHh7kZ?=
 =?iso-8859-1?Q?qjflTydJ45ZYVne9pCbDBBYTvt4pcpQg+JghkoXrPo8sItEpwlC98HuF6z?=
 =?iso-8859-1?Q?jXzbIGkPA52I6EKKfbtdcKHVNLx61wsLrYbtKOLtDUaWrTjalTh84Opk9d?=
 =?iso-8859-1?Q?9zJbpz8ls/Bf/+n6xYBdv1q7EFgG+OrU21kFD7x0JTWS6XGPTkPiD/aZz0?=
 =?iso-8859-1?Q?+U8C01rHhvDRdHq9wvXnydn9Fp2x+cj9KLPx9L/hpO1n1CfqL4cyC2EycG?=
 =?iso-8859-1?Q?Y5hv0vmurEdv7TI2xg+qwQZuGCrBcgGQ5sZZoMlSxsfew0+ykwU8ZmbOKp?=
 =?iso-8859-1?Q?prcO4ZT2DjUuoX4HOZEQr2+kr49DPnveEaa7q6lbVktyDu8JNDWuSOhr9n?=
 =?iso-8859-1?Q?AA6VI9IwEnGl6Glu/DA5qWE5NQ7t2yy0EJWMBvYGyyyiZLlYyzASmnUu2M?=
 =?iso-8859-1?Q?V4dv6XMXoizFSOA/Lj9l+MYJfC6vRpfSKsh3ici9LJZZF+dqUhmFqdsSdM?=
 =?iso-8859-1?Q?UeJSj8NEJ5nuvGiq2cHlyKrajQUprRW8lapQTNun92UlHjU2kC8PjsqXSs?=
 =?iso-8859-1?Q?L5JWKwZZ+v4+RdKoSp+rJmnP5TXH+jMBGxlLnefYMGS4ySUC69mEq4YAHp?=
 =?iso-8859-1?Q?dY5QtnDYFIg1TE8yZvZPRghxRcgV1n3P7Z1sHLiPt52gTwidp+1Yx2zxyq?=
 =?iso-8859-1?Q?KBcmFR405+BTe7sXmypxUYrBtIzgnlhKu1F8h/2gxjREAHzf5Jt+TBKERF?=
 =?iso-8859-1?Q?52npUHTW1+UAhpcegbh7zE4G4mzVrrfyCbLH8S66ftaJBi9drnCSmT8uKI?=
 =?iso-8859-1?Q?N1iSscUqB4SNvzpSLSwwReng6KcaGkqiA6vEKfW/6nxmnCH0BbwmdbC51+?=
 =?iso-8859-1?Q?M6vNaWTt4teAJCMf/4HRFvP5uwzXIFtqnd58TpGcTmj770LSEarTd2Wni3?=
 =?iso-8859-1?Q?XO+TqQxRHwAtAex3hZiOt8udLuGqHDh1vMjwcgyWMIBgm3oY10oxnPlCah?=
 =?iso-8859-1?Q?IadfxFosbLoHSU6STjOh+mPl53ZEwLg/wIc4tdfRWzN3ytQZrZz0Uil8ps?=
 =?iso-8859-1?Q?D3u4k/qA/4X8S/JHFUM/ghqsKRyt00/e4BwzNGcxNpDXiboUEEQlehp49b?=
 =?iso-8859-1?Q?ZAGZtWlRHRGzEnnTmI+TvQs35g6eb4HTL3Xq5WRzfGj4AZZcjxPOYG+k4B?=
 =?iso-8859-1?Q?EWEuBWGiPSUxawDXerv2/QuIHsNlCyRfmqevqOF2hlqTZsl5k7e8WuhXiR?=
 =?iso-8859-1?Q?6Otc24Mgw0vuDqaUM7jSEqjO6f2qdwKNq/SfL5pk5lTl0nfKDreRaf9Q5W?=
 =?iso-8859-1?Q?U0ZbOwKa2MJHFpBAgVMTOMX3I6o1Di9Sq4ti/s58cJrW9DHPZZOaFDZDdR?=
 =?iso-8859-1?Q?wHq0MVHiI8+i0hMMeTQT95dzx6FVhtYwRD7XlvVrEVtih7gXUePd0Yg1H5?=
 =?iso-8859-1?Q?N+OMZ6ssAI9pydNCR98=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 071ed85b-24c5-4990-6679-08dbc891eee4
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6231.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2023 06:35:30.8821
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4ral7QUJ5l2h4gvLPjX4U+5imqf9b7xz1ExkzTuSw2m9mrNWFvfi/e+H3R86BHpFHMqb/tz1JsT0uXWZN+V0v7NlHxndzWQp+v6tryOoCQ8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6293
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Sun, 08 Oct 2023 23:35:53 -0700 (PDT)
X-Spam-Level: **

Hi, thanks for reviewing the series!

On 2023-10-06 at 15:42:15 -0500, Moger, Babu wrote:
>Hi Maciej,
>
>My last comment didn't make it to lkml.? Could be my mail server problem.
>Commenting again.
>
>On 10/5/2023 3:15 AM, Maciej Wieczor-Retman wrote:
>> From: Fenghua Yu <fenghua.yu@intel.com>
>> 
>> The documentation mentions that non-contiguous bit masks are not
>> supported in Intel Cache Allocation Technology (CAT).
>> 
>> Update the documentation on how to determine if sparse bit masks are
>> allowed in L2 and L3 CAT.
>> 
>> Mention the file with feature support information is located in
>> the /sys/fs/resctrl/info/{resource}/ directories and enumerate what
>> are the possible outputs on file read operation.
>
>This last paragraph is not clear.? All the information is already in the
>documentation.

Right, I guess that paragraph does mirror patch contents a bit too much.
I'll remove it and repost it.

>You can drop this paragraph. First two paragraphs are fine.
>
>> 
>> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
>> Signed-off-by: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
>> Tested-by: Peter Newman <peternewman@google.com>
>> Reviewed-by: Ilpo J?rvinen <ilpo.jarvinen@linux.intel.com>
>> Reviewed-by: Peter Newman <peternewman@google.com>
>> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
>
>Otherwise patch looks fine.
>
>Reviewed-by: Babu Moger <babu.moger@amd.com>
>
>Thanks
>
>Babu
>

-- 
Kind regards
Maciej Wiecz?r-Retman