Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp1734256rdb; Mon, 9 Oct 2023 00:32:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFq5thMDZ7tCVGjYymPQ/0dDu1c4VvUZRT+UYayF4vOq9Myw8jJYbUR9XPcGe421ODxDbDU X-Received: by 2002:a54:4002:0:b0:3a7:4876:6044 with SMTP id x2-20020a544002000000b003a748766044mr15025032oie.52.1696836746592; Mon, 09 Oct 2023 00:32:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696836746; cv=none; d=google.com; s=arc-20160816; b=cIXA/sn9TljINuY/COdd0MSenNCG1vGNcD8H1aYLlL4x25wHaJcGYcrMyZcSTsCKiN n3wV398CktQ2Jtl2GbMnLgQiU8AAQsloVmJx1nbR2lS4CfqiHBtX957MjMMXZjeWUvBu mdjspYGqy8YbMAiSvCpEtYDKGRlumAyCB+q92ujRK0hroC+wPsZ76yl3IGWOmu+rG+Zg Jgx82dPb9OZJy/h0FGE37h1WDdy/NnAxPpWAmLbPinFN1ai6tfAFNMSjWBmsIQ9nihku GF5FwpGKz+hp/xLAzEB6Wsb7YwnkEyG9RnJouqN+5VtgkJkRu2Jup2KRzSjmCpPSTIcq wmwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:cc:to:from :subject:message-id:dkim-signature; bh=aiMNjsVcGqhrNnfDi/djcbfbRpTfabEPyQg6HFOpBK8=; fh=Wsc7y+WPA0HevyT0mEOQk0SakRKsFhylkhsqsF7ZInw=; b=LARGXM968njTWIDPQF7IKhh/860VLGPk/UIWXsF/drIDn75ybkSoiw7DCAw19JeJUf FKEUfVBMvTZ3VeMUySnoE2heTUgrJ/fvG/6cumoqkA3hnwVLVKcJm1R33vE/XYAmycaa 5B8jtmM+araJB7dsP7zYpLvVxjOMKt/7yG7/s/hkfBLPhUhDC01So8woIhtPpH3Eopp/ H8GiXPI4XsugsPuObSPFeHatBVIjieCGe0pEsqPH7f6oXQY/mEWas7V8ytzDZ3Hu09Au w1BfK96vvv26mbMkBmC6aFBmbnKEA+T5NGXMuxLcGj6tIpT0ImuFeYZVbya3wOTv8nyR F/pw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=LFGjMaDW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id b67-20020a636746000000b00565e56713c7si9306200pgc.91.2023.10.09.00.32.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 00:32:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=LFGjMaDW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 51DD980A9E3D; Mon, 9 Oct 2023 00:32:24 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345404AbjJIHcL (ORCPT + 99 others); Mon, 9 Oct 2023 03:32:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345374AbjJIHcJ (ORCPT ); Mon, 9 Oct 2023 03:32:09 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:242:246e::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13880AB for ; Mon, 9 Oct 2023 00:32:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=aiMNjsVcGqhrNnfDi/djcbfbRpTfabEPyQg6HFOpBK8=; t=1696836725; x=1698046325; b=LFGjMaDWY58A8JXCiiISIS5bm+7cWWbTGPhEUpfHzI0tFmr r5TWdGlmJWaRS13a38GSOyoe/1LU1UyMI39mKvkEraigiiS7TYfHbRL0yvlXQi+UexaAnjo/JgE0d WGdC+5ZztOSBXFiSfQi/wFDkkQ78n3FYDjhLVu/Pz+HofLJgUhYR3YRT6tnJZ82rKHnLOIX9l9LNq xLdommuTTtQ+ALSCMVZN9R+GBTUXU6V5tS1o+Fwn1ThEO1lD8k6JWCl9e7UBDc1S+ySFz95Sb6nmc WwwANMkjdojV9bNlJtVSXsGadAWLK4fnoBmDCBdXODm2jYdvPv0p4iZuk3qzzG/A==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.97-RC0) (envelope-from ) id 1qpkk6-0000000F6yQ-20cA; Mon, 09 Oct 2023 09:31:54 +0200 Message-ID: Subject: Re: [PATCH] um: vector: fix return value check in vector_mmsg_rx From: Johannes Berg To: Ma Ke , richard@nod.at, anton.ivanov@cambridgegreys.com, xiangyang3@huawei.com Cc: linux-um@lists.infradead.org, linux-kernel@vger.kernel.org Date: Mon, 09 Oct 2023 09:31:53 +0200 In-Reply-To: <20231007005104.3994678-1-make_ruc2021@163.com> References: <20231007005104.3994678-1-make_ruc2021@163.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-malware-bazaar: not-scanned X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 09 Oct 2023 00:32:24 -0700 (PDT) X-Spam-Level: ** On Sat, 2023-10-07 at 08:51 +0800, Ma Ke wrote: > In vector_mmsg_rx, to avoid an unexpected result returned by > pskb_trim, we should check the return value of pskb_trim(). And how exactly do you propose pskb_trim() will return anything but 0 in this scenario? Please. If you have a static checker, _think_ about it's output before blindly sending patches. johannes