Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp1735756rdb; Mon, 9 Oct 2023 00:37:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE5vIFysgleA+Fu6IUFzfk8+igoE7ukqzouAkUDmUfwmEINVng0Kkw1UHCoBiZRZF4VUjTA X-Received: by 2002:a17:903:22c3:b0:1c3:cee1:cc8e with SMTP id y3-20020a17090322c300b001c3cee1cc8emr17964785plg.68.1696837027821; Mon, 09 Oct 2023 00:37:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696837027; cv=none; d=google.com; s=arc-20160816; b=oqLgR8hHs08Urvd2CQcYP0OcrpFjJcCbTzKlCwNYlOFVOxavJLpHUx3Yvs8KYzj7ch 6yuFb4Amv1B5CXD7M6dj6+NPMRRL/Laboevu3+XMCtXzvJ7q5MqBOnn6Ok4X51LaPnMK N1E0I7T55TaMxt7JtubUaDRUN0Dw3PttsAF6FXv3UgP/mQuNcIpgSvNH0OA0H6XzlVke 4k66TdqBM/dST6GapfaSuCvS0b5u4+ypnEpmBtuBfitwa9/i8vH3HT0V0qAWWW7l9LSa 3Axf6Jn1XRL7dlkgtAO3Z0jz0oaeVZ9DnfH8I67Q2lmTi/pR54T4QRIh6a01uaaz10DD e77g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=P11GtP8h5bZkmfO9QlBDjtnQW6u1oo0XCFakTqv8vWg=; fh=3X6EEnmY0zI2Hw7my822EeC7Dj36Y8gBAEXDWV0NV0k=; b=X3Myr/JH4wF1bBPKQo77vRz+o3zW/08x3AB0I6IeIQv0O2Si08W2Z5oNsrvPIUtxQB x2ugQUKBzP+ZuZGNluYY2DC5+MpsQxGlY7AptTLhkVhUjuQG52MNDm/S3fmIbujphPJT icsBPe+tpKz8A+9go2TJG89XXG7SKcEPqurRYgFJrpmDnxJIMdhX0kH6+iSOAD1mNLFX 1tSHblrX6YXjZMT3y159zO3MtIGa3BAt7eykZ0e5DVhYnOUmuobp4PJNc2CRpbTM7eQu hAVoo5XeFwwMelTjukEy7Kp6k6QrEBBJRKCUj+VzZyxtPb2cORI3c73Uo72/4g4s9CO7 tWHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cuorHarb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id y16-20020a170902b49000b001c0ebd96c51si8661176plr.602.2023.10.09.00.37.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 00:37:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cuorHarb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id D7F6E808D212; Mon, 9 Oct 2023 00:37:05 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345419AbjJIHgw (ORCPT + 99 others); Mon, 9 Oct 2023 03:36:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345404AbjJIHgv (ORCPT ); Mon, 9 Oct 2023 03:36:51 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA58594; Mon, 9 Oct 2023 00:36:50 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16153C433C8; Mon, 9 Oct 2023 07:36:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696837010; bh=cyOr9wKSZbKTmoYhGi29W/BehcsluNpyqFhmV/79LkU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cuorHarbeq5vdYq06nmPq8nGX2pDzlhYY2aIguVOKLx86qrspW9qfoRixSiD2oG1N BX1bPZiKVWe177iMU3qJ145/6+2QVdLkcYwZxGa8AO5oMtIqJfoIk3nVEGqVXjIFOK veC1rvqC5QOFNQ1rskp5a1QGWowZeU/MLKC+k7IX27yaqQPwaC/2E0+1aTIIPnF7Zi jRQ0blTp93aKHoihZBYvcrr6adET4DoQoSOx+8sYbZ4o9kQCrjGdrCzmS/dXLNJkwz 3hZTLiNv/d324k7T+CNsBKZE4Ai4/PYv3wZJOz/fGp/BoLGTd6qJlk9ik3kuHHAfUA f5I0X9VQZ9jOA== Date: Mon, 9 Oct 2023 09:36:43 +0200 From: Christian Brauner To: David Howells Cc: Hugh Dickins , Jens Axboe , Al Viro , Christoph Hellwig , Christian Brauner , David Laight , Matthew Wilcox , Jeff Layton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH next] iov_iter: fix copy_page_from_iter_atomic() Message-ID: <20231009-bannen-hochwasser-3f0268372b80@brauner> References: <356ef449-44bf-539f-76c0-7fe9c6e713bb@google.com> <20230925120309.1731676-9-dhowells@redhat.com> <20230925120309.1731676-1-dhowells@redhat.com> <1809398.1696238751@warthog.procyon.org.uk> <231155.1696663754@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <231155.1696663754@warthog.procyon.org.uk> X-Spam-Status: No, score=2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 09 Oct 2023 00:37:06 -0700 (PDT) X-Spam-Level: ** On Sat, Oct 07, 2023 at 08:29:14AM +0100, David Howells wrote: > Hugh Dickins wrote: > > > - __copy_from_iter(p, n, i); > > + n = __copy_from_iter(p, n, i); > > Yeah, that looks right. Can you fold it in, Christian? Of course. Folded into c9eec08bac96 ("iov_iter: Don't deal with iter->copy_mc in memcpy_from_iter_mc()") on vfs.iov_iter.