Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
From:   Julian Stecklina <julian.stecklina@cyberus-technology.de>
To:     Sean Christopherson <seanjc@google.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        "H. Peter Anvin" <hpa@zytor.com>
Cc:     Julian Stecklina <julian.stecklina@cyberus-technology.de>,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/2] KVM: x86: Fix partially uninitialized integer in emulate_pop
Date:   Mon,  9 Oct 2023 11:20:53 +0200
Message-Id: <20231009092054.556935-1-julian.stecklina@cyberus-technology.de>
In-Reply-To: <20231004133827.107-1-julian.stecklina@cyberus-technology.de>
References: <20231004133827.107-1-julian.stecklina@cyberus-technology.de>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JtX4E3lBZZtvAYey3T5aWUgis7u1XcDGTX+qxESgsLXcYCG2DVy7tjwueedO?=
 =?us-ascii?Q?fFLd4ecC154gEU0lX38L0zBX2Ka1AoIFEdjxUy+1zEhrBj0h8q0eQdTLJ9rk?=
 =?us-ascii?Q?9U2Eah6vBWq2Y/zsyv1WrVQ5uF1ULV6KK8j1xrVNAtoVIJd0PdDbOituUqUf?=
 =?us-ascii?Q?KS9qFmIFTob2Zgmzx1oQ0o+2eWfP8FxvbjyG55uWURHnSy02TsDE/XrBadef?=
 =?us-ascii?Q?ZzDIujocwI1Qw3p8LHv8qsAQ8PvFB02qzYToe+7k1ST6ZOhuTccZSl/rxWSi?=
 =?us-ascii?Q?RD79CzK5mgvkMpl4RF28tP7YWhshE0GLfyuaog7mk4E1ewAGYLYcAVMGUubU?=
 =?us-ascii?Q?6kegVaZeO8d4egI13Cn8FDt1CyaJrbFysJo+I2kYE+H8f4MXTnrNYfN/tyrA?=
 =?us-ascii?Q?Tvf0n92p54a6BUltjjimDOUWwxfGk2srUxZFJLoI3UN7YE7D6KONe8mDd8Wm?=
 =?us-ascii?Q?agoZcdXfQyzFroRyIdF2nbJG2QJUEtu/WTeKGeDPBTNua7hMzo93PcePFH9u?=
 =?us-ascii?Q?cyKc1YkcJGTKBTM+4+/VSQBzT09dtvSufNKD7BVXHR8xCRZ7wF3d1ahN4ptc?=
 =?us-ascii?Q?EoKdf1SlOprXX4Ec/OaQcq1/+gFSYf7MZX/0zEJpXdN4/1SUMztrDfoWyQJ7?=
 =?us-ascii?Q?bOjwByrd+8g8R4yuz2/GdyvDqAdO+LlrtgtSvK4/xdB78pTo4P1TA3t0cHN/?=
 =?us-ascii?Q?wCJcgrVDL/FZWaPz/rDqmpp7QVT4rMgyKhSHKyz5uaGmKu8Eqc66Lf8Fwptj?=
 =?us-ascii?Q?Fc2R8hAEz6ejZzUkLIZUe3FGfjPDHBX5qu1dKPjvlwBauw6EPOj1CesHKJXx?=
 =?us-ascii?Q?Pa1W7x7p6tph0VUs2hbjgtsae7vktW6LwGxX+v7iXQLgFBk0eKb+tKlRlePs?=
 =?us-ascii?Q?lL6ParUvO2V0Iw0bX9KrOYHww0keriTYnpJ8qCjUSXPtHRIzwchT2Q2+XnSJ?=
 =?us-ascii?Q?dH/rTE/T24dhFIdBjzX7hX5em7BVipp8VIcHBU1BdWgfqKbkp2UDG6xqZCd9?=
 =?us-ascii?Q?VpDiIlgiVJ9udRuAVCF+Cdg4swsyhaHzFXp6Ifso7KiOcC2Cu3UYMabFZSkq?=
 =?us-ascii?Q?bWSD8bxNC/ls3aH7YWfaio8q5Bz92EuQYPbBRRYbjP8FT0zsh17k2XPUxuFx?=
 =?us-ascii?Q?5F5LS+nu9nw4nQdtXY9nHcNKzs0zJgKdPIC/fYhaSufoAFAPrK04BqulFd+s?=
 =?us-ascii?Q?u5qcipm9eOuRCt63GJjk3fszu9pE6Hf8/bT9aDN2PQKVOXXfUglvLYNkC4DN?=
 =?us-ascii?Q?B9zEaFsnXNv7VlFM3iDGkSZmBzCyiCc0YQ5AxHmTttwfw1svxwiMLljxbjah?=
 =?us-ascii?Q?w+hlauXHCKOGf5kEkjKQ14TeZmXvggk6EypYqP1EWRKf64Zw1t9vZyuyC1z/?=
 =?us-ascii?Q?a1g7BRxzYQIkMDf964TfbPBJcWcCdnJPUGj3LAiU1alqfoQuHfqbtRlwAC00?=
 =?us-ascii?Q?hNuz/TpaIWJGAzsNEvdRocI2yScco/OpBhcEZR1eHIYj4GKnsvF0ERk0qhxo?=
 =?us-ascii?Q?w73Y5LT2mbr/Guj7JvCGBEDf1fwqQ2QOEHe2VN72twnm2TY8OH4WNYABleF5?=
 =?us-ascii?Q?zegMoTEEA4FUQbwzje44+gEFWuG0IQZ3/Q34omIOua6o7/WdwJQlvz537+4l?=
 =?us-ascii?Q?a1mZr310JboriVI7roc/BqQ=3D?=
X-OriginatorOrg: cyberus-technology.de
X-MS-Exchange-CrossTenant-Network-Message-Id: f6f3688e-01f8-4c6c-176e-08dbc8a92fc2
X-MS-Exchange-CrossTenant-AuthSource: FR3P281MB1567.DEUP281.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2023 09:21:58.0757
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f4e0f4e0-9d68-4bd6-a95b-0cba36dbac2e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: F+xVXPRHQSvemYDgoFRPqMHzgpR0hBwiSiFk3MA+2q32pgHMzyf8tjZx2VOUvHXT+Q/nRxYgvN+K5sWgZY5IX9ku2+13N9xMySDP7QI76v005TdmZenqxt9/MSoePv5S
X-MS-Exchange-Transport-CrossTenantHeadersStamped: FR0P281MB1983
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 09 Oct 2023 02:22:22 -0700 (PDT)
X-Spam-Level: **

Most code gives a pointer to an uninitialized unsigned long as dest in
emulate_pop. len is usually the word width of the guest.

If the guest runs in 16-bit or 32-bit modes, len will not cover the
whole unsigned long and we end up with uninitialized data in dest.

Looking through the callers of this function, the issue seems
harmless, but given that none of this is performance critical, there
should be no issue with just always initializing the whole value.

Even though popa is not reachable in 64-bit mode, I've changed its val
variable to unsigned long too to avoid sad copy'n'paste bugs.

Signed-off-by: Julian Stecklina <julian.stecklina@cyberus-technology.de>
---
 arch/x86/kvm/emulate.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
index 2673cd5c46cb..86d0ee9f1a6a 100644
--- a/arch/x86/kvm/emulate.c
+++ b/arch/x86/kvm/emulate.c
@@ -1862,7 +1862,8 @@ static int emulate_popf(struct x86_emulate_ctxt *ctxt,
 			void *dest, int len)
 {
 	int rc;
-	unsigned long val, change_mask;
+	unsigned long val = 0;
+	unsigned long change_mask;
 	int iopl = (ctxt->eflags & X86_EFLAGS_IOPL) >> X86_EFLAGS_IOPL_BIT;
 	int cpl = ctxt->ops->cpl(ctxt);
 
@@ -1953,7 +1954,7 @@ static int em_push_sreg(struct x86_emulate_ctxt *ctxt)
 static int em_pop_sreg(struct x86_emulate_ctxt *ctxt)
 {
 	int seg = ctxt->src2.val;
-	unsigned long selector;
+	unsigned long selector = 0;
 	int rc;
 
 	rc = emulate_pop(ctxt, &selector, 2);
@@ -1999,7 +2000,7 @@ static int em_popa(struct x86_emulate_ctxt *ctxt)
 {
 	int rc = X86EMUL_CONTINUE;
 	int reg = VCPU_REGS_RDI;
-	u32 val;
+	unsigned long val = 0;
 
 	while (reg >= VCPU_REGS_RAX) {
 		if (reg == VCPU_REGS_RSP) {
@@ -2228,7 +2229,7 @@ static int em_cmpxchg8b(struct x86_emulate_ctxt *ctxt)
 static int em_ret(struct x86_emulate_ctxt *ctxt)
 {
 	int rc;
-	unsigned long eip;
+	unsigned long eip = 0;
 
 	rc = emulate_pop(ctxt, &eip, ctxt->op_bytes);
 	if (rc != X86EMUL_CONTINUE)
@@ -2240,7 +2241,8 @@ static int em_ret(struct x86_emulate_ctxt *ctxt)
 static int em_ret_far(struct x86_emulate_ctxt *ctxt)
 {
 	int rc;
-	unsigned long eip, cs;
+	unsigned long eip = 0;
+	unsigned long cs = 0;
 	int cpl = ctxt->ops->cpl(ctxt);
 	struct desc_struct new_desc;
 
@@ -3183,7 +3185,7 @@ static int em_call_far(struct x86_emulate_ctxt *ctxt)
 static int em_ret_near_imm(struct x86_emulate_ctxt *ctxt)
 {
 	int rc;
-	unsigned long eip;
+	unsigned long eip = 0;
 
 	rc = emulate_pop(ctxt, &eip, ctxt->op_bytes);
 	if (rc != X86EMUL_CONTINUE)
-- 
2.40.1