Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <92377509-0f30-46ff-8b37-3b4b6fd53189@linaro.org>
Date:   Mon, 9 Oct 2023 12:30:49 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 7/9] drm/ci: export kernel config
Content-Language: en-GB
To:     Helen Koike <helen.koike@collabora.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>
Cc:     robdclark@chromium.org, vignesh.raman@collabora.com,
        sergi.blanch.torne@collabora.com, guilherme.gallo@collabora.com,
        david.heidelberg@collabora.com, quic_abhinavk@quicinc.com,
        quic_jesszhan@quicinc.com, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20231009004953.203576-1-helen.koike@collabora.com>
 <20231009004953.203576-8-helen.koike@collabora.com>
From:   Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
In-Reply-To: <20231009004953.203576-8-helen.koike@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 09/10/2023 03:49, Helen Koike wrote:
> Export the resultant kernel config, making it easier to verify if the
> resultant config was correctly generated.
> 
> Suggested-by: Rob Clark <robdclark@chromium.org>
> Signed-off-by: Helen Koike <helen.koike@collabora.com>

Acked-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>


I'd even say:

Appreciated-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

It will help a lot to debug possible Kconfig changes and/or omissions.

> ---
>   drivers/gpu/drm/ci/build.sh       | 1 +
>   drivers/gpu/drm/ci/image-tags.yml | 2 +-
>   2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/ci/build.sh b/drivers/gpu/drm/ci/build.sh
> index 8eec15143bfe..740b5008be2e 100644
> --- a/drivers/gpu/drm/ci/build.sh
> +++ b/drivers/gpu/drm/ci/build.sh
> @@ -148,6 +148,7 @@ mkdir -p artifacts/install/lib
>   mv install/* artifacts/install/.
>   rm -rf artifacts/install/modules
>   ln -s common artifacts/install/ci-common
> +cp .config artifacts/${CI_JOB_NAME}_config
>   
>   for image in ${KERNEL_IMAGE_NAME}; do
>       cp /lava-files/$image artifacts/install/.
> diff --git a/drivers/gpu/drm/ci/image-tags.yml b/drivers/gpu/drm/ci/image-tags.yml
> index df94d8fb348e..3e5cd4e8be24 100644
> --- a/drivers/gpu/drm/ci/image-tags.yml
> +++ b/drivers/gpu/drm/ci/image-tags.yml
> @@ -4,7 +4,7 @@ variables:
>      DEBIAN_BASE_TAG: "${CONTAINER_TAG}"
>   
>      DEBIAN_X86_64_BUILD_IMAGE_PATH: "debian/x86_64_build"
> -   DEBIAN_BUILD_TAG: "2023-10-08-igt"
> +   DEBIAN_BUILD_TAG: "2023-10-08-config"
>   
>      KERNEL_ROOTFS_TAG: "2023-10-06-amd"
>   

-- 
With best wishes
Dmitry