Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp1790163rdb; Mon, 9 Oct 2023 03:07:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE82+z7L0KJtmLO9YZi19dt5yKdYwFVkw+tYRlBheyIVqrluM2d9UTwbjr+6dUBfc7Iqgvx X-Received: by 2002:a05:6a20:5485:b0:161:25e5:8de9 with SMTP id i5-20020a056a20548500b0016125e58de9mr15453104pzk.48.1696846022864; Mon, 09 Oct 2023 03:07:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696846022; cv=none; d=google.com; s=arc-20160816; b=r6wDNRUcHNKBZ39QZX80JtIh7XIqCN1WHw1sVJ3KZ4wWvwljOCjIowXlSfOVx/ZlEm BvXit5aWpSjvQuiKPk5+9tKkq6T1t68IZGfWD29ylPFZ6pJze1iYlfnfHstetGVE2GcN NSv+PA4oYwvl7rgFIYr+58WLUjfyr7ptrJNZxZnehoIdO2V4hWu7Qtfsqw0hPDXUN4XE wM6iG+hcWyMZJX3a79t3i6o8x8ATs8ls/Qyd3yhrBQp04LfzCwSA0rBLvB6sk8NvPjZf mQv+YjAPeWnTg1B/cOBEYT9flwuedn5vCWjM3MAZ8fDJTLyzH8/9Z1BTVNtrA2GS7gaI MlvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=MvxNbj9ys8IfoqMFyDq76FUDqBV9I6DCBlDdySQb1uU=; fh=VI/SR1spg0cIeMQGlxIiv0e42pjZD3ZsS9z10gqTmKU=; b=ost7mUsLVsmzFYoKUZpmQYFuki9v2mKEz2C2e31qRz1wlCcjOfnaZL2MbIiyu7I2ZH 3Qdla5xxe0KwkPo1KOtDUXtYDdTgq09BbsXSytSe1yPcHgamkhwV639RGieST5LI41E0 Bh2StdnmpC3Vwa2H5h76tA107/Uk3pfitnkViKhRS8YXj5TcLThlTrTMVQ3PAHZA1Scl ZQ4aiLZzB7crcKUgcMGSRjXe/sFvH9zlhY3c5aUFHcwh1+/53QaEmgXEIkfKQ26nByW7 Fd4//TaTUhBrCUUEPixfIERQYff7N1zKxAr4Hfv+buJOMjSpA8yw0hf/A5BGnwsXBJ49 p5Eg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id cp12-20020a170902e78c00b001c5cf1c30cfsi8800245plb.435.2023.10.09.03.07.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 03:07:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 3D4A48021E3C; Mon, 9 Oct 2023 03:07:00 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346073AbjJIKGc (ORCPT + 99 others); Mon, 9 Oct 2023 06:06:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346047AbjJIKG3 (ORCPT ); Mon, 9 Oct 2023 06:06:29 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 159EDED for ; Mon, 9 Oct 2023 03:06:27 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qpn9W-0007Yw-BU; Mon, 09 Oct 2023 12:06:18 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qpn9V-000OEu-UH; Mon, 09 Oct 2023 12:06:17 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qpn9V-00C7Dk-Kz; Mon, 09 Oct 2023 12:06:17 +0200 Date: Mon, 9 Oct 2023 12:06:17 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Florian Fainelli Cc: linux-pwm@vger.kernel.org, Angus Clark , Thierry Reding , Ray Jui , Scott Branden , Broadcom internal kernel review list , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list Subject: Re: [PATCH] pwm: bcm2835: Add support for suspend/resume Message-ID: <20231009100617.lzxyg4mm56yoazla@pengutronix.de> References: <20231005171516.2908961-1-florian.fainelli@broadcom.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="z4x4pndddec4qowb" Content-Disposition: inline In-Reply-To: <20231005171516.2908961-1-florian.fainelli@broadcom.com> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=2.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 09 Oct 2023 03:07:00 -0700 (PDT) X-Spam-Level: ** --z4x4pndddec4qowb Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Florian, On Thu, Oct 05, 2023 at 10:15:15AM -0700, Florian Fainelli wrote: > +static SIMPLE_DEV_PM_OPS(bcm2835_pwm_pm_ops, bcm2835_pwm_suspend, > + bcm2835_pwm_resume); The definition of SIMPLE_DEV_PM_OPS has a comment saying: Deprecated. Use DEFINE_SIMPLE_DEV_PM_OPS() instead. Can you please rework your patch accordingly? Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --z4x4pndddec4qowb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmUj0JgACgkQj4D7WH0S /k76IAf/Rfdj60t96flf+/L/M4w21DvlOcX+c3dDuAu4TBB62jFdMDba2TbmFhAq wqR+hXN1AbdGKgrtHXGQpRobK5W4Yj4pU7vM6GHAbryu9k7aFUtSsrKAfWotKV7E vSEI+tDhsMuiQH8m7lBES5ejX5bV+GeqB2XHrFizqrS/1VoaktYoUXY0M+GB3lTR 7E8VkG4JCPshIetW1ibwO+GyKMZDzNXXHtPStwDz5nggawIReLfwo9jpfixdPwwB vGTd5xC9bymgPfmQ2IgeLqnkVx20VYlwYH+/AKxazyaquCEb2aYvQYd31eZWdJA+ t00/P6lfHL8PiVsh0hg4PIGTStKM1Q== =N91w -----END PGP SIGNATURE----- --z4x4pndddec4qowb--