Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
From:   Niklas Cassel <Niklas.Cassel@wdc.com>
To:     Ma Ke <make_ruc2021@163.com>
CC:     "dlemoal@kernel.org" <dlemoal@kernel.org>,
        "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ata: sata_mv: aspeed: fix value check in
 mv_platform_probe()
Thread-Topic: [PATCH] ata: sata_mv: aspeed: fix value check in
 mv_platform_probe()
Thread-Index: AQHZ+pkfVLu9iJm2J0SnnPjdm/WkQg==
Date:   Mon, 9 Oct 2023 10:12:35 +0000
Message-ID: <ZSPSDcPY5c1UzrM2@x1-carbon>
References: <20231007072657.4001311-1-make_ruc2021@163.com>
In-Reply-To: <20231007072657.4001311-1-make_ruc2021@163.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?emfR2YoKlx44SCC+EHj6KLLQEoeUR1VsrrrDJ9b29rDjpeb/7bm/KE/P+Wc0?=
 =?us-ascii?Q?AF1NcuK/x0D+eAlGTBea9RTbbgzTGuA6I5VavBsS4Art5pRAp9hjIE6laYqG?=
 =?us-ascii?Q?cokZVS3oeYplmj9gIrw3JhsjL1ATwBg1a47QkbJgjDFhOv6ydtPwWA6mHcNV?=
 =?us-ascii?Q?lzHmxqJtlhqBdsPEWmBIUUwoKXawptW0FWyT/6+0u7oClp7C+UNECgC5tqSp?=
 =?us-ascii?Q?Nr/Yaf4rcO0oogolDqwsWRLNFy8pK6/IripoO234x/eDwqgNFeYHRBVo0mlB?=
 =?us-ascii?Q?u9e6thhRhZy7Mj2Hfq9T61d4r1iGLBXTf+yG/eXpYsDJtwOqetrYd8JHYy2y?=
 =?us-ascii?Q?nlFapDgvdbPrcy7sA+Py5khmcauhpoG3z6ypA+BI3BTVU37PD/BWH44AgGQx?=
 =?us-ascii?Q?n24x4cNkwqr31y7LWVfEPdwopThXgmXWVAiXLh3xW8U2opR1yobB5FQTqlbI?=
 =?us-ascii?Q?WJBFF4w36sWQ89STqjHAKKlrUD48HdsWk7Cq+nlfIMFpGBSWqedXDpNERzKr?=
 =?us-ascii?Q?LFSV1P2/8JfXk3X/3rAkEpFmn7mp1tIyy54n9uhqtCf9yixL4pf+ZR+dQiJH?=
 =?us-ascii?Q?gde6yJtHzDfsx4PNIMQap2/d4JbgEuNcF+4KDvCETGsKJsV85HihlACPwJ22?=
 =?us-ascii?Q?vgh4wWJM9oGh0vZ4J2zup5LlOPkfXhnpvIrluaJObSrkYp15H/99vcmmGUjt?=
 =?us-ascii?Q?LTfxEymQb4FMLMiFuRTwtEmDW6uSj3XfHvbNOJJ5A3nN6VsXkh3fCD02+bJV?=
 =?us-ascii?Q?hh63dcv2SDLsG7LAisnr2IhLwJMFGn8gQWpwV/l5YNRDOwe1eAvLhi3GcGbD?=
 =?us-ascii?Q?fNe71J/MFdhUCzK0uSM/+T2G2ZzsG1VFFIBMrW8dXlIx9zSzzJWRFTJC2/nv?=
 =?us-ascii?Q?4qWXB1U18iJPDGCvZKPwXYX+6BRKj/+UphDPRWuBZgqR+9fQdGcfKJjzBqjs?=
 =?us-ascii?Q?vxP8NpE3jo1DLuNy/b6DRQ1DNV+qxTBlOHfJfOFHGUkp0lbCO9/gQXWZByTM?=
 =?us-ascii?Q?h4ZS3DU8RuLQeS5WtKm1gbjVRNeqYU/f1Gx2X/zZB859y0dikwZgw9NSk3sU?=
 =?us-ascii?Q?roPAYxG6NeDub3buRdAE96ev/p8BZJ5rgQz7SilidpEGPQU12j242osLoQ17?=
 =?us-ascii?Q?u/8NP5MVmGAI8SSUNDj1xNPge0Fz5alObmhNecQvtgm47NNmz+DZxrARr/Ab?=
 =?us-ascii?Q?1IfafYivyCwMARuO52qzMxK6t0ETlwv8hTgJGpNSmIn3cIWI2zQjLtbQ98e3?=
 =?us-ascii?Q?MQpwlKvU6Xh4Q9DoYV2KQ18LSKuVJogZP7XkruEpDZQK2LvXynbyQODcQIFx?=
 =?us-ascii?Q?LXsVvdyGbcM7yy9NlxQvH6y/dlo0T7T84L1rCBVhLMgHi1JnL0od9Bt5lhk0?=
 =?us-ascii?Q?n63lPVMc4n3iHutbAlbA+s0dlsDjyvMFErPSlKdaytmK8FG1ah9JgSjrVsQ4?=
 =?us-ascii?Q?ZqgOwXDzG4hDFFmdI825t5jpdg+6KTjN3H6EirA65SGvD561WUWJm9bsp07W?=
 =?us-ascii?Q?8O+ZVm5CPifW/357DpwcBWb5SKaNWZ2Mp6GZxGh2cu5dt8im9X2dhD6q1B2w?=
 =?us-ascii?Q?aHrI2RlWcP+jDrDWGhOGux6QqHEOenQmgMTPwCaVL8U1MxD7NyKBJoG47PtK?=
 =?us-ascii?Q?Rg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1E306AE102A72A4FA1AD8F2A6980DCF5@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: q0cNpu9ziuw7NxTLR/3q/VKVohoWbuFjZ56NhFJRAenlJUBXHQMxEXHh6OIgPO2JB4rSIyH3SH0vPzuW6pEZ2iNfgXhLz5ORDIoHri3g4xXoUO/XBKbYwtpdbK4XOtFZZBHhBE4PJVwq8rRiXpR6yc42bZYbR//AVEm+BSCjVWB2tIubCuQT3EOZEWjjxOtEd/evkpT1hBcBpmFvNz4pBfXTWDIpJ3/6vPPBLovWNqsUq1lEH2xKas7MRkTMM7GFXqgkliEKi/2hguRYZwjgEApOViBWHg+6xDUtYja95uDs+8hjBHydsqNzz7ezQjEhjTVouObQ7xtTJpgO3zkzBrdQ0RT6PHRa/pr0HOoSKXq1TPZtg2COxkOK63jrwsTFSrz2RenkQumk2+mJDnol1BnvqL0aitz86JG1aft/FqpvJEp3QQ47f1UEvi0YjcR9ZiLlGPXyhOlyAihlVHNvMtrGq1i70x5qOm1Il2FdYBV4Sb63QobiYaQ5R2kGjQ9z0XOiWlbUax+wh2xJ70fYfgTLDoXPu4+/rLU7aReUJPjxwQJ36FjAgOI9CQC7m08XdIrDVqT4nck2TLWHctzh7AxVDH/p2Zg7w80hOc1LHMJ9iFz0M5MwO5/z4LuwyNqFRNTW/c9zmPdYQJz49XmMc/HrTH0jCud0n8yY8B9bZyC1mIxhXKWp6OR4SFl27PhsBsdokQXVyAEhXgqHeYDja+iC7L/bnMuUEb/ZYNvO59di+qL2s2eGzcyJs0s4vJpXmPZb1GQEfT6tBA8AEEVp4pzG6fW8q3iBn794PerLNx5lzyx8J06l9x/bGHepmNaaj9X4IlnHawJWeGRKbxEn5w==
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN2PR04MB6272.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ead62f7-69da-48d4-74b2-08dbc8b04260
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Oct 2023 10:12:35.6340
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Meh1OgxeefgqOUfvT6dKVcv3U+76gNjika/MC4EBWfiiDbaR20MfaWJ1XJSv1YS0PevGYL56Vl2gWNID9Pwh2w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR04MB8401
X-Spam-Status: No, score=2.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,
	SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 09 Oct 2023 03:13:08 -0700 (PDT)
X-Spam-Level: **

On Sat, Oct 07, 2023 at 03:26:57PM +0800, Ma Ke wrote:
> In mv_platform_probe(), check the return value of clk_prepare_enable()
> and return the error code if clk_prepare_enable() returns an
> unexpected value.
>=20
> Signed-off-by: Ma Ke <make_ruc2021@163.com>
> ---
>  drivers/ata/sata_mv.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
> index 45e48d653c60..96f9841aae6c 100644
> --- a/drivers/ata/sata_mv.c
> +++ b/drivers/ata/sata_mv.c
> @@ -4125,8 +4125,11 @@ static int mv_platform_probe(struct platform_devic=
e *pdev)
>  	hpriv->clk =3D clk_get(&pdev->dev, NULL);
>  	if (IS_ERR(hpriv->clk))
>  		dev_notice(&pdev->dev, "cannot get optional clkdev\n");
> -	else
> -		clk_prepare_enable(hpriv->clk);
> +	else {
> +		rc =3D clk_prepare_enable(hpriv->clk);
> +		if (rc)
> +			return rc;

Don't you also need to call clk_put() to undo the clk_get()?

Can this error path perhaps simply do a goto err?


Kind regards,
Niklas=