Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Sender: Ingo Molnar <mingo.kernel.org@gmail.com>
Date:   Mon, 9 Oct 2023 13:08:34 +0200
From:   Ingo Molnar <mingo@kernel.org>
To:     Shrikanth Hegde <sshegde@linux.vnet.ibm.com>
Cc:     mingo@redhat.com, peterz@infradead.org, vincent.guittot@linaro.org,
        vschneid@redhat.com, dietmar.eggemann@arm.com,
        linux-kernel@vger.kernel.org, qperret@google.com,
        srikar@linux.vnet.ibm.com, pierre.gondois@arm.com,
        yu.c.chen@intel.com, tim.c.chen@linux.intel.com, pauld@redhat.com,
        lukasz.luba@arm.com, linux-doc@vger.kernel.org
Subject: Re: [PATCH v6 1/2] sched/topology: Remove EM_MAX_COMPLEXITY limit
Message-ID: <ZSPfMjuOC5dTkx5i@gmail.com>
References: <20231009060037.170765-1-sshegde@linux.vnet.ibm.com>
 <20231009060037.170765-2-sshegde@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231009060037.170765-2-sshegde@linux.vnet.ibm.com>
Precedence: bulk


* Shrikanth Hegde <sshegde@linux.vnet.ibm.com> wrote:

> From: Pierre Gondois <Pierre.Gondois@arm.com>
> 
> The Energy Aware Scheduler (EAS) estimates the energy consumption
> of placing a task on different CPUs. The goal is to minimize this
> energy consumption. Estimating the energy of different task placements
> is increasingly complex with the size of the platform. To avoid having
> a slow wake-up path, EAS is only enabled if this complexity is low
> enough.

...

> To reflect this improvement, remove the EAS complexity check.
> Note that a limit on the number of CPUs still holds against
> EM_MAX_NUM_CPUS to avoid overflows during the energy estimation.
> 
> Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
> Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
> Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
> ---
>  Documentation/scheduler/sched-energy.rst | 29 ++----------------
>  kernel/sched/topology.c                  | 39 ++----------------------
>  2 files changed, 6 insertions(+), 62 deletions(-)

I've applied this patch to tip:sched/core, for a v6.7 merge, thanks!

	Ingo