Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <57967900-d00e-4175-8c82-4a91c60022e5@collabora.com>
Date:   Mon, 9 Oct 2023 08:19:45 -0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] drm/ci: Default to UART for logging
Content-Language: en-US
To:     Rob Clark <robdclark@gmail.com>, dri-devel@lists.freedesktop.org
Cc:     Emma Anholt <emma@anholt.net>, Rob Clark <robdclark@chromium.org>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        open list <linux-kernel@vger.kernel.org>,
        Guilherme Alcarde Gallo <guilherme.gallo@collabora.com>
References: <20231006173205.371205-1-robdclark@gmail.com>
From:   Helen Koike <helen.koike@collabora.com>
In-Reply-To: <20231006173205.371205-1-robdclark@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

cc +guilherme

On 06/10/2023 14:32, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
> 
> ssh logging is the default for mesa, as it is generally more reliable.
> But if there are kernel issues, especially at boot, UART logging is
> infinitely more useful.
> 
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
>   drivers/gpu/drm/ci/gitlab-ci.yml | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/gpu/drm/ci/gitlab-ci.yml b/drivers/gpu/drm/ci/gitlab-ci.yml
> index 2c4df53f5dfe..7c55f02f7313 100644
> --- a/drivers/gpu/drm/ci/gitlab-ci.yml
> +++ b/drivers/gpu/drm/ci/gitlab-ci.yml
> @@ -27,6 +27,12 @@ variables:
>   
>     LAVA_JOB_PRIORITY: 30
>   
> +  # Default to UART logging.  Mesa uses ssh by default, as that is more
> +  # reliable if you have a stable kernel.  But kernel CI is more likely
> +  # to encounter unstable kernels (and has lower volume of CI jobs so is
> +  # less likely to be troubled by occasional UART flakes)
> +  LAVA_FORCE_UART: 1
> +
>   default:
>     before_script:
>       - export SCRIPTS_DIR=$(mktemp -d)