Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <af176171-7c06-700d-c885-b63f44a0443d@linux.dev>
Date:   Mon, 9 Oct 2023 19:31:19 +0800
MIME-Version: 1.0
Subject: Re: [PATCH 2/2] sched/rt: Move sched_rt_entity::back to under the
 CONFIG_RT_GROUP_SCHED block
Content-Language: en-US
To:     Ingo Molnar <mingo@kernel.org>
Cc:     mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
        vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
        rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
        bristot@redhat.com, vschneid@redhat.com,
        linux-kernel@vger.kernel.org
References: <20231005162317.3343678-1-yajun.deng@linux.dev>
 <20231005162317.3343678-3-yajun.deng@linux.dev> <ZSPS+jMcJEd+ZR28@gmail.com>
 <5a3342ef-f14f-173c-630f-6b474bded257@linux.dev> <ZSPjbjPPMeafHbjU@gmail.com>
From:   Yajun Deng <yajun.deng@linux.dev>
In-Reply-To: <ZSPjbjPPMeafHbjU@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2023/10/9 19:26, Ingo Molnar wrote:
> * Yajun Deng <yajun.deng@linux.dev> wrote:
>
>> On 2023/10/9 18:16, Ingo Molnar wrote:
>>> * Yajun Deng <yajun.deng@linux.dev> wrote:
>>>
>>>> The member back in struct sched_rt_entity only related to RT_GROUP_SCHED,
>>>> So move sched_rt_entity::back to under the CONFIG_RT_GROUP_SCHED block. It
>>>> will save a few bytes.
>>>>
>>>> Also, init child when parent isn't NULL in init_tg_rt_entry().
>>>>
>>>> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
>>>> ---
>>>>    include/linux/sched.h |  2 +-
>>>>    kernel/sched/rt.c     | 18 +++++++++---------
>>>>    2 files changed, 10 insertions(+), 10 deletions(-)
>>>>
>>>> diff --git a/include/linux/sched.h b/include/linux/sched.h
>>>> index 292c31697248..d0fe56603e60 100644
>>>> --- a/include/linux/sched.h
>>>> +++ b/include/linux/sched.h
>>>> @@ -597,8 +597,8 @@ struct sched_rt_entity {
>>>>    	unsigned short			on_rq;
>>>>    	unsigned short			on_list;
>>>> -	struct sched_rt_entity		*back;
>>>>    #ifdef CONFIG_RT_GROUP_SCHED
>>>> +	struct sched_rt_entity		*back;
>>>>    	struct sched_rt_entity		*parent;
>>>>    	/* rq on which this entity is (to be) queued: */
>>>>    	struct rt_rq			*rt_rq;
>>> Title claims this change - the rest of the changes should be in a separate
>>> patch:
>>
>> Okay. I will send v2.
> It's ~v7 already by my count, isn't it?


May be. If we count from the earliest.

>
> Thanks,
>
> 	Ingo