Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp1839153rdb; Mon, 9 Oct 2023 04:55:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHa9JUH4O5faXbqiTiJwkGPpAEllz8Yac1jV4P/XA0PgwDHX3b7gkozWlEEO0FgB+OdxxUB X-Received: by 2002:a17:902:a511:b0:1c7:4707:964b with SMTP id s17-20020a170902a51100b001c74707964bmr11077555plq.25.1696852558045; Mon, 09 Oct 2023 04:55:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696852558; cv=none; d=google.com; s=arc-20160816; b=K2rrxeixzBaSXs1KQP06OREqB6/24KpthjEsxOx6iV65J3OgZMJpFSJj6R4pZaJVYE Qgk15QRQmf3cGOxGAWVWHgOFHt0PRCdz/nIZd3Bl/oVVMeqQbTmvO8SecklZUjCZT2Hb s74JbPaK+fFKYGqAsuDTllHj9/++/qMl7MTnwf9mxPLYzgAv9lRf0t8/EQWtESZM7yYg 2GinjSGaYYbfZRz75T2O1RM5nBYWjlaDSf4C4eYQWyQcZJNrRtA+jgYOBRrn0NKkRDIp cYx4QSiFzxxiMrEZvuKXTY/V5UJiDKG1Ue1B8GUbD8es5J2gYhWNjqqs9esIj/M570Yo VUKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=kiAu5OMZaiXXi0z5I+8qm7pQTCFQwNtt0IDQ6VM0rXw=; fh=gSlqDyTAaX4sD5o7lNdgN6GT1mkO6Z4/Ye0T8jAhwnM=; b=KUvfGsJdGUaUyVwsTmZ6xrfNQsQb57K2lFyQxrkS370uvvmQZSwmY+tgcYEASoLD0u HhefIykj2NvFsAY0DB0kaKUNCiWP5QICuZHAvQV45jdbvg1sZG5K9UTy/jjlI+UtanFS 4XOkayDd6LvYCbn8ewV2ehRuL7iIUwhwjUE4G/muX7LQnzOHbGOQ68OIyx2n2LdRPu6z Aqg+WvdJ3qvG63FYtAGXQBF4FMaFr2BwIoHAyeWFqB4DIWvAHfVMsZvKKZL7j8dAW2/Z p83O7KN5btJyFtspcnmM/hE5vZ6RMqLmRUuDwSLbbj/70nVcgyOLq/eBBZ027UxQw+Z6 xSiQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id b3-20020a170902d40300b001bf0e15c0a9si8868185ple.269.2023.10.09.04.55.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 04:55:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id C28918021311; Mon, 9 Oct 2023 04:55:45 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346380AbjJILyv (ORCPT + 99 others); Mon, 9 Oct 2023 07:54:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346335AbjJILyr (ORCPT ); Mon, 9 Oct 2023 07:54:47 -0400 Received: from mblankhorst.nl (lankhorst.se [141.105.120.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0B8DAC for ; Mon, 9 Oct 2023 04:54:44 -0700 (PDT) From: Maarten Lankhorst To: alsa-devel@alsa-project.org Cc: Maarten Lankhorst , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Kai Vehmanen , Mark Brown , Daniel Baluta , linux-kernel@vger.kernel.org, sound-open-firmware@alsa-project.org Subject: [PATCH v7 00/13] sound: Use -EPROBE_DEFER instead of i915 module loading. Date: Mon, 9 Oct 2023 13:54:24 +0200 Message-Id: <20231009115437.99976-1-maarten.lankhorst@linux.intel.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=2.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 09 Oct 2023 04:55:47 -0700 (PDT) X-Spam-Level: ** Explicitly loading i915 becomes a problem when upstreaming the new intel driver for Tiger Lake and higher graphics (xe). By loading i915, it doesn't wait for driver load of xe, and will fail completely before it loads. -EPROBE_DEFER has to be returned before any device is created in probe(), otherwise the removal of the device will cause EPROBE_DEFER to try again in an infinite loop. The conversion is done in gradual steps. First I add an argument to snd_hdac_i915_init to allow for -EPROBE_DEFER so I can convert each driver separately. Then I convert each driver to move snd_hdac_i915_init out of the workqueue. Finally I drop the ability to choose modprobe behavior after the last user is converted. Compared to previous version, I added the patch "ASoC: SOF: Intel: Fix error handling in hda_init()" Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Cezary Rojewski Cc: Pierre-Louis Bossart Cc: Liam Girdwood Cc: Peter Ujfalusi Cc: Bard Liao Cc: Ranjani Sridharan Cc: Kai Vehmanen Cc: Mark Brown Cc: Daniel Baluta Cc: alsa-devel@alsa-project.org Cc: linux-kernel@vger.kernel.org Cc: sound-open-firmware@alsa-project.org Maarten Lankhorst (11): ASoC: SOF: core: Ensure sof_ops_free() is still called when probe never ran. ASoC: SOF: Intel: Fix error handling in hda_init() ALSA: hda: Intel: Fix error handling in azx_probe() ALSA: hda: i915: Allow override of gpu binding. ALSA: hda: i915: Add an allow_modprobe argument to snd_hdac_i915_init ALSA: hda: i915: Allow xe as match for i915_component_master_match ASoC: Intel: avs: Move snd_hdac_i915_init to before probe_work. ALSA: hda: Intel: Move snd_hdac_i915_init to before probe_work. ASoC: Intel: Skylake: Move snd_hdac_i915_init to before probe_work. ASoC: SOF: Intel: Move binding to display driver outside of deferred probe ALSA: hda: i915: Remove extra argument from snd_hdac_i915_init Pierre-Louis Bossart (2): ASoC: SOF: core: Add probe_early and remove_late callbacks ASoC: SOF: Intel: hda: start splitting the probe sound/hda/hdac_i915.c | 24 ++++++----- sound/pci/hda/hda_intel.c | 60 ++++++++++++++-------------- sound/soc/intel/avs/core.c | 13 ++++-- sound/soc/intel/skylake/skl.c | 31 +++++--------- sound/soc/sof/core.c | 17 +++++++- sound/soc/sof/intel/hda-common-ops.c | 2 + sound/soc/sof/intel/hda.c | 46 +++++++++++++-------- sound/soc/sof/intel/hda.h | 2 + sound/soc/sof/ops.h | 16 ++++++++ sound/soc/sof/sof-priv.h | 2 + 10 files changed, 129 insertions(+), 84 deletions(-) -- 2.39.2