Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <7add9eef-0d17-6692-14f5-968a4d4778f0@oracle.com>
Date:   Mon, 9 Oct 2023 14:02:16 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH 4.14.y] drivers core: Use sysfs_emit and sysfs_emit_at for
 show(device *...) functions
Content-Language: en-US
To:     Greg KH <gregkh@linuxfoundation.org>,
        Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Cc:     stable@vger.kernel.org, joe@perches.com, blamoreaux@vmware.com,
        linux-kernel@vger.kernel.org
References: <20230922121454.2735355-1-harshit.m.mogalapalli@oracle.com>
 <2023100737-enchilada-angriness-2a42@gregkh>
From:   Vegard Nossum <vegard.nossum@oracle.com>
In-Reply-To: <2023100737-enchilada-angriness-2a42@gregkh>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?KzZMbEovWlk2RFBnbG9WVW51a0k2WHF5Z3F3UGVqaUJGeEZNcEkrYW51ZHd6?=
 =?utf-8?B?L1krZnJRdVVPMUxYVDZoVHpzSmh2cmlTeC9KZGY3ZVBQbkFTQWRlYlpQaEdx?=
 =?utf-8?B?TlJURWNzK21SWUhBT3o3S0Z1RmxyRkxmTkx3ZUQzdTNnMHdIeXluMEwxRlRC?=
 =?utf-8?B?VVRxdk52ajhtMm5vWWJGTWxYRTBFdUl2THFoR3hGQ29ZczhPY3dXRjcvK0lO?=
 =?utf-8?B?MWlVU3d3d2dVVDVWdXpZcG1kcXN5blk5VE1ZSG5UZDVDdndLb1BsSXk0TE9i?=
 =?utf-8?B?MWVpUHc1QnBoWmQvQnNweDlENmptQldJTzBwemQxL2k4VG1sNUh0RjJETmIz?=
 =?utf-8?B?VEpUaUtsWEo4alNlQmtMeXVQcDBDKy8zWWJ2eHNabERXa3NBYnlqYWpIc0Zp?=
 =?utf-8?B?OHd6dGpYWE9WWHFPSnVLQUZiTEc0dUNPY3RYUFlYRnlhSmhoN1B3YUFCOEtz?=
 =?utf-8?B?YnVaTTZJcS9aZktrVGJkT2ZnMXRXU2FncVk2YnVuaE5oOXlPRkM4ZmtsRFht?=
 =?utf-8?B?aEtFbGZ4Z1FKRTZ1UmlrMUZWNGpuTWFFR2ZhdXVnNkh1eUY2Q2VLaWFsMUNW?=
 =?utf-8?B?SGFhb1ozY1o5R21KMFZ3bFFCVzBvQUZKa0xoVnJYR1NWNjFocXhPYkZyTURm?=
 =?utf-8?B?cm5Mem1nQ0ZOMko5amkvYmtCT0YxWjIzV01ocFRqVHE0TGZuRFBkNU5EUjZo?=
 =?utf-8?B?U0laMEZPMnhrTXFnbkRoRnV2OE91YzVuRmUydGd1VzFVRG8wemRNWTlpYTNq?=
 =?utf-8?B?MEh3cWJud3EyNUY2MGpFbkllYTRsN3ZQdHRRSFhKR3R4RXlSVWRaT214cTRQ?=
 =?utf-8?B?NXF4UWRkUGE0TUY1Q1hLVlgrUDNiT1hLYW9CeStLbUpxSUpHMGh4RG5tQ1hD?=
 =?utf-8?B?T0NSZ2oxRm00OUg3RU9WaGJnK3NlUVpuazJreUYxNHludklCYy91MEc5YUVU?=
 =?utf-8?B?TkxKb3c0YmRBRlVVSkxaWEV6OUJXQUdsSHBQSGZOVW1CNVY0WFErcGFzT0hI?=
 =?utf-8?B?NXNTY0VJY3JoMFQ2RFpPWHpXaVFGbjYvQURkQUhYY3ZNM1FSRDZRS05sWURF?=
 =?utf-8?B?em9ZVGJvVm5RMUZoNTNwK2FUQ2p1bHpjc1gzOHpnWmFBQTQzVnJOSXBiblJv?=
 =?utf-8?B?bCtCSTZXZ1RKcEZaWXUrQjFlOGVPb0lTVFhZUnhsdThNRityLzV1MWhLaC9D?=
 =?utf-8?B?aTBYcGlqNVNRdzk2dHNaMFZJSnYxRXBDSkF3MXpOR1Nxcmh3bkhHN1d6L0Yz?=
 =?utf-8?B?WDZEQlVGbVlWMkw1VEEvWDN0MFJOcjNPODhDcEs5czVlSXNXSU85NXRRbnF0?=
 =?utf-8?B?WDUvZlNNUGFtUmNiRkVvTDJjRG5FYzIyYWZ0R1ZRbkNFczlJT2NvMHpRZFg3?=
 =?utf-8?B?ZFl1cFlabDVBbUdCcHlmYUlncjFIaWR3V1oxanB1SWhkdGxHaHhtV2g3OWp4?=
 =?utf-8?B?Z2FjMkRNVWtSR3ZkalVORUFJMXRKaldybkFpSjZMeUVqNVdWYWVsWWVhR0Fj?=
 =?utf-8?B?NGJBcFdLV0VIUE5YYzVEbzF4Zk9uQTJPOXYra1VhWVhHREhZaVE0V2xDNkJL?=
 =?utf-8?B?Z1l1MmFvd1RJUGxyU0ZWUVJsTTVtL0s1RlQxbjIwa25kcko1NFpadWhDeVZJ?=
 =?utf-8?B?WWcxU0dZL0NnS1JPdndocGJlVVZGNmZmRDhzd29BNHRWQUdWZ0NxR1ZjYjFT?=
 =?utf-8?B?SVl1N1g5UVNLb1lPVjM4N0dKR0VRZmo4bkZNL0dSeE9aTWhFTXNCWnRwSk5R?=
 =?utf-8?B?Q0J1OVhUbHpuaE5LakQrN21RbkJqbWF3Vko4eFFqb2gvVGJsN2VPWndxSStl?=
 =?utf-8?B?b3NuU2pmWmh2bXRpbUQzc1JQQzBpQUZsdHpBNDYzYXhiZUx0KzFPZ05CdkNN?=
 =?utf-8?B?NTJzM25Cc1RZcVZtakRnV1pSY3JRcmlFM1B2dWlMc09EbS9JNzFIQnU2bThB?=
 =?utf-8?B?cDFISGxUZ09MeTBtZDJkR1lJeTM3bjk1djU4OUpGYWhGRWFKZUhHVExLWld1?=
 =?utf-8?B?ZjRCaWhyWlBrNGRXRVhGK0trUUJ3ZWFmWms2eXFmYzB6V3hOMTRDM0xkSzdl?=
 =?utf-8?B?dWNzRWRqaUdWSXVoTjIweHl2cUJhN0g4QmxKazRyMDNTYStkeUkzN1dDZVo3?=
 =?utf-8?Q?adUDO46iHo9v6OTSpPKs/idsC?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: iP62MLSfuEJA2dijeN0DY0r1cBRf9iGAIJP33ILWwQZqass3l3JvlG6UbAHQaSVdXUUQNh8TiP9uyRrhGawvDIZV+Wo1ZPurKdfnMN7pvx0txcMNOxGXVHKILJ4ontSWleO7qJplKtCVf0VovoNHQt8A1+1WYIU++51wAYto311epl+JS/9wdV1YSJoz1YXg+b+5GBTlv+LPZ+mYwe0KHo6JAMJtqOS7v+H0GefCot9hPJqj+EiQuyr/54Bgm7AI0t30jf4omWXzBnU8Hi/TsmSDIyOLXTHIm2YbFcV/FfJ0ikzeqVFODe8ZkQIVRHiX3leZXTCscE2RrcxtxjFIWtQFFKHHX+3c/zZ86WXOP1abFZKo3BKjDaWGgV4NygM/bc0p7bAfZgv0ldGbDcVPhxyQ5PMwkdhEpLFrtkRmQ52sFjRTTzrvULI78DebotmCWjQUK303PelEnbP2HeTNuCeRe9vjnWAzBbxFc3CfSb+HfJ5r8W/dnuXNItK1gdG2nltAld7/Unw68T7s1+lB+vn6NC9C5N8h2q2HhkBaMXxMjz7nGSwoERV1XuxyPoKEJU6WR7WXv9Hi7gsbuNI3EFu5ZNq3eD9DLFvDwM/pfdgkooU7RDt33UBrbpG+26jcOwecH6v36KhHk/IIM2aTAk61aCoc1VLjaJUQJd4/FSb/XKNsBC3ejWoSlmerHg/gn8xJop3p7x/d4E3FSyJ+uzRkWZR/vgOGeaslsb+IX6mBSfDUB59WqnpW4fmE0VCByynTyQ9i98JxHzyfEQq2MO0IN789ItD46g119ynuJsb87bC+W4oBvCS9u2ZwHIS0PfPsuk6dWmfqYywcUcvCmZQtV/qxOAHe9athIQosVhcyMS7VNepSCsI3jbFXSfp6
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 627c44d8-3c16-42c3-5cab-08dbc8bf98dd
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB5433.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2023 12:02:23.5821
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WzwkuZrFu3KqJ7OBfefN0PAfBRfhkF6JdqT850oPFBv1sKAMOqrsFQTdGIBz3KcUCSFaiynI1ShOOEc0i0Fdl0z4w1SJ32yl3gPKyQ6U9Yk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB4837
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-09_11,2023-10-09_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxlogscore=949 mlxscore=0
 bulkscore=0 phishscore=0 suspectscore=0 spamscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000
 definitions=main-2310090097
X-Proofpoint-ORIG-GUID: D21vfgEny8gFfCoFe8NwFAz4Ced-sDN_
X-Proofpoint-GUID: D21vfgEny8gFfCoFe8NwFAz4Ced-sDN_
X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 09 Oct 2023 05:02:43 -0700 (PDT)


On 07/10/2023 13:21, Greg KH wrote:
> On Fri, Sep 22, 2023 at 05:14:54AM -0700, Harshit Mogalapalli wrote:
>> Signed-off-by: Joe Perches <joe@perches.com>
>> Link: https://lore.kernel.org/r/3d033c33056d88bbe34d4ddb62afd05ee166ab9a.1600285923.git.joe@perches.com
>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> [Harshit: backport to 4.14.y -- regenerated the diff with the help of
>> coccinelle script in driver/base/ directory.]
>> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
>> ---
>> Only compile tested. This fixes CVE-2022-20166.
>> It is not clear whether the CVE was assigned for a demonstrated issue
>> or just a theoretical one. In any case it's a good defensive measure
>> against future patches that may introduce a real issue if they assume
>> this patch is already there.
> 
> This is not needed in this kernel tree, so why are you attempting to add
> it?
> 
> And if you have questions about a CVE, as the entity that gave the cve
> out, they are responsible for it, not us!

We weren't sure where exactly the issue was, but figured the more
cautious approach would be to apply the patch regardless -- it does look
correct to me at a glance (doesn't suffer from the issues that Ben
pointed out with another submission, AFAICT).

But point taken, this falls under the "no theoretical issues" stable
submission rule.

Thanks,


Vegard