Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
MIME-Version: 1.0
References: <20231006224402.442078-1-robh@kernel.org> <aaf40c3c-a7cc-4556-bb80-f9149327bb7a@linaro.org>
In-Reply-To: <aaf40c3c-a7cc-4556-bb80-f9149327bb7a@linaro.org>
From:   Rob Herring <robh@kernel.org>
Date:   Mon, 9 Oct 2023 07:10:54 -0500
Message-ID: <CAL_JsqK_69+4ZXrg78xf2apvvt_VRHquR2ThjOGkyQZKz655gg@mail.gmail.com>
Subject: Re: [PATCH] memory: Use device_get_match_data()
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Nicolas Ferre <nicolas.ferre@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Beznea <claudiu.beznea@tuxon.dev>,
        Florian Fainelli <florian.fainelli@broadcom.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@broadcom.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, Oct 8, 2023 at 6:33=E2=80=AFAM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 07/10/2023 00:44, Rob Herring wrote:
> > Use preferred device_get_match_data() instead of of_match_device() to
> > get the driver match data. With this, adjust the includes to explicitly
> > include the correct headers.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
>
> ...
>
> >  enum ccf_version {
> >       CCF1,
> > @@ -172,14 +170,9 @@ static irqreturn_t ccf_irq(int irq, void *dev_id)
> >  static int ccf_probe(struct platform_device *pdev)
> >  {
> >       struct ccf_private *ccf;
> > -     const struct of_device_id *match;
> >       u32 errinten;
> >       int ret, irq;
> >
> > -     match =3D of_match_device(ccf_matches, &pdev->dev);
> > -     if (WARN_ON(!match))
> > -             return -ENODEV;
> > -
> >       ccf =3D devm_kzalloc(&pdev->dev, sizeof(*ccf), GFP_KERNEL);
> >       if (!ccf)
> >               return -ENOMEM;
> > @@ -189,7 +182,7 @@ static int ccf_probe(struct platform_device *pdev)
> >               return PTR_ERR(ccf->regs);
> >
> >       ccf->dev =3D &pdev->dev;
> > -     ccf->info =3D match->data;
> > +     ccf->info =3D device_get_match_data(&pdev->dev);
>
> This part is no equivalent. You miss here if (WARN_ON(!ccf->info)).

Checking for match failed was pointless. We already matched in order
to probe and DT is the only way we match.

Rob