Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp1859637rdb; Mon, 9 Oct 2023 05:28:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEIKRM9rQDGSadctpTDYzuAYdrHVX5Gs3qiAevrZQTq8PtmsHt73lyDignKreE+OHRVGxzU X-Received: by 2002:a05:6e02:16c6:b0:350:f2a0:5c44 with SMTP id 6-20020a056e0216c600b00350f2a05c44mr21640532ilx.2.1696854537387; Mon, 09 Oct 2023 05:28:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696854537; cv=none; d=google.com; s=arc-20160816; b=DxUuyABbY/zQ9NuU1lO3XNrnOy/FgAQmo6OfIrsKN14S+eGj8zH1JVs3oWCmU95NlF +tmnPHYxr9KegRdZd1tMb7cmy2gTS1h7djjDu1AYW4m+cj6oz8h//rwvcOye4z7StT3B F3kzOSMLCb6EBFabtDI/Ye0E1PbV6BhdT9uuFX1xr/+0NcWhoJCTKW1KWio+Mne7KSD0 nCCCDhBaCrkdVHnx+c5v9gO5yATbO/EmSoC+V7C0nnPzoo4fkiz1tpZd0rs7raYln0cP 4IRDw89XEyziCahsEOsXK2bEr47Mi5NolsOdMwciiDPwPq3T0xHC8UcpHaFE+iXBwuB3 NafQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Archi7+sI9Ew7JxY1G5PMzoMsd7Jm/0ZpBqU0FryHYo=; fh=nJfCUWqjxSCtn2B86MjjXQBs/ZYWcPK17KVhg8Blk8o=; b=0+0bK+f5I/aLby0XoaljRX44P49iT4A8ebTW4j/o36UHQCyEp6EQbktFqRrDROYgMe IpL3d3tiRhU236fjDB2JO8l/EaCUNCCBjO5zEhB1dDFm3RHXWzaEC/5dPi0h3ima40D7 WgcqnZD40DdA7tvcVQ3FehLp5z+z8fQjERmn1GYpO4mtJkm0Qq6Zcb9mNZ2+4ovPtRYK Tn7qNVPXLJZaZtVmx51GyUQSCUobebR3YuGI1j40ctmHtZ3Zu09SLjQ1ms8+LKEKjuOp dLtbDxQTe3RPFFKnLnurfqhWCH9JIJWypU9dXLupArkOgGtYneNN+jeYkCQn7E8sQSE3 vw3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fUDPshpf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id e65-20020a636944000000b005859d13f276si9643669pgc.569.2023.10.09.05.28.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 05:28:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fUDPshpf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id B5BD98057B25; Mon, 9 Oct 2023 05:28:54 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376277AbjJIM2l (ORCPT + 99 others); Mon, 9 Oct 2023 08:28:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346402AbjJIM2k (ORCPT ); Mon, 9 Oct 2023 08:28:40 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6699499; Mon, 9 Oct 2023 05:28:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696854519; x=1728390519; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=RfddNvi5x0wejZG5QzaCfI3Qcz87rv0fDzUvwx9WuLY=; b=fUDPshpfWyU0gstdvmwc7yu5vRQjt5H8WEwzNEyynd1VWg/F4XMp6Qhy Y7JOYJpT5EZv8imQGi8sv5IPX3QxVx6e6aZGjP5o9zimyj7r2jYMGp4UY tfeF0n3CxHlz9nCS1MG9uLfYC8Mb2/R+sy5zcrevYcRVWCnnmHG5ohvnB Kylf0jTO1+G3MruC70DrSnfFsOEkF39xiMdLUu3u/AU9la93Qa6FSLIYC 5NofFMSgsLm78Daos+ZIopxmRZHdDbIHGPPeLMgpruFJQdnHTtL5bMeZI 6aTM4zBVNqGJGFfwZPrzxQd3VxQrOXdL/pqDHihIsw8oOQ8j2laPNDUsW w==; X-IronPort-AV: E=McAfee;i="6600,9927,10858"; a="384004945" X-IronPort-AV: E=Sophos;i="6.03,210,1694761200"; d="scan'208";a="384004945" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2023 05:28:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10858"; a="746656325" X-IronPort-AV: E=Sophos;i="6.03,210,1694761200"; d="scan'208";a="746656325" Received: from ibrahim2-mobl2.gar.corp.intel.com (HELO intel.com) ([10.213.42.185]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2023 05:28:26 -0700 Date: Mon, 9 Oct 2023 14:28:20 +0200 From: Andi Shyti To: Kees Cook Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , "Gustavo A. R. Silva" , John Harrison , Matthew Brost , Michal Wajdeczko , Matt Roper , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-hardening@vger.kernel.org, Nathan Chancellor , Nick Desaulniers , Tom Rix , Andi Shyti , Nirmoy Das , Jonathan Cavitt , Fei Yang , linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH] drm/i915/guc: Annotate struct ct_incoming_msg with __counted_by Message-ID: References: <20231006201744.work.135-kees@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231006201744.work.135-kees@kernel.org> X-Spam-Status: No, score=2.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 09 Oct 2023 05:28:54 -0700 (PDT) X-Spam-Level: ** Hi Kees, On Fri, Oct 06, 2023 at 01:17:45PM -0700, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for > array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct ct_incoming_msg. > > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: Tvrtko Ursulin > Cc: David Airlie > Cc: Daniel Vetter > Cc: "Gustavo A. R. Silva" > Cc: John Harrison > Cc: Matthew Brost > Cc: Michal Wajdeczko > Cc: Matt Roper > Cc: intel-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-hardening@vger.kernel.org > Link: https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci [1] > Signed-off-by: Kees Cook merged in drm-intel-gt-next. Thanks, Andi