Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp1869920rdb; Mon, 9 Oct 2023 05:48:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHC579AjYZAaXXLQS68C9z+r+zUQrfsN3IWeIZhGuijYiAO0HgDAIn6yDj8g9JaC0l2iTI2 X-Received: by 2002:a05:6a00:1943:b0:690:d4fa:d43d with SMTP id s3-20020a056a00194300b00690d4fad43dmr12681931pfk.6.1696855715906; Mon, 09 Oct 2023 05:48:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696855715; cv=none; d=google.com; s=arc-20160816; b=mPaF/HqQzKXdzEEgqEGmgcVBZw71FJCgBstmRC9S3teVUrQThuVoKGjZlHh60X8kRl N5stYQCjiWQdBkUG+p78p3ts/R9py/IDX5zagtTGeMYE62IrdiOi2uNy+9gwCsKd5rDB sgZrOmh8v9/r9Ek4XJQ0kCwdmXIekhxrm3XHGOpcBtRK8PHPDvNP/sTWx+ISe5X1zvv9 hW7Xx0oAmY42eF+bf7bgAvaz0f4/G7S5Hi6h7O74lP1KIOPq6aW95rnz6+r3G2SJV5Gh ptwjskZXOfQT8Vej03OoBlafsGnh71ke0DI9Ly0yOvArSChXLiHiN+0evyGcZGV7uXMn FsoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=VzeKLax/6rILb+TWdJTPD7VTQMSLckbI1FQWiviqBo0=; fh=yis4kwteoCWiccm5rREYOk936PFyGMLZzQVS2Keg+w4=; b=SPtEtdAueEl2DKGtgCLewmikUCZZ4tmXgJYpjiugD0C1e/RkiIQe/rKjTe/OsEyssN 7+lAZtBSEyI6dOq3aLPNY6JHWnRWTdvHfpkX1ihireW6obk32ItLRYDxlk1CAa3U1mcD F0QMH/hG2s6jvlKAlDv1xAdMFzB9HfUBz/1/cepk0Rr8w2HXqRJZ6NJOlRDvW8DtbCsb KC5dYIUCevia0Up8MRVwcEg/fPjPwUcu6tAP+sLqbhXV2NgOUh+zQhQONA3WUx+qnNd5 1PcSZZCSLuKMjy+D61/4OB6FKKdd0X459tFogynxRvmZjVWcGZPOhHWPQ52+2xoCmmUi 8HdA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="uxBZMd/G"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id i71-20020a639d4a000000b0054402b987f8si9163611pgd.605.2023.10.09.05.48.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 05:48:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="uxBZMd/G"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id F09EC808692D; Mon, 9 Oct 2023 05:48:30 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376454AbjJIMsZ (ORCPT + 99 others); Mon, 9 Oct 2023 08:48:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376284AbjJIMsY (ORCPT ); Mon, 9 Oct 2023 08:48:24 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CA9194; Mon, 9 Oct 2023 05:48:23 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2EF6C433C7; Mon, 9 Oct 2023 12:48:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696855702; bh=DVz/vrk54ln8GcE3zkgj4i2m52T14DKd91nDa8/zhCc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=uxBZMd/G6vNwaWndhpPYbthGH+yaeeGqaMymhy+mvuTr39vA88/53vZej/88hzXtd atfSCRsd/nKOhYK891jnM0p/47E1RB4rTtmwl9OIFr+r6tvuCQThRLa6Ult4ri+qib rINV4gRtMCmXNGfuT6ZnFS80bp60EqdikZxvZjonnhGxwdIsaMtaNy7jOYAo4m5Zn3 EpWaWfRoT53mRK7nwpAx0+xVhSaNKugZ7RydkJGOYE85uI8N75QpYg5GeVhYHV/HRo eCq/PEShMx0Q67i1b4W7nUkJeY6Mp6FzErFDSXYc9ixFmhr56vhgk1ma6iCpDNCKVu QWJWaEjBIdOXw== Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-5068dab8c00so2772924e87.0; Mon, 09 Oct 2023 05:48:22 -0700 (PDT) X-Gm-Message-State: AOJu0Yz9GF9wPAuI+Zn+NK3tZVYO6AJY/9ZjjnOGYzvcGTiC/5wU76ve BOp4b0yAEcQyjXfZU0GON2hLByU5I+Mhod9zZg== X-Received: by 2002:a19:6456:0:b0:503:442:5957 with SMTP id b22-20020a196456000000b0050304425957mr11575125lfj.41.1696855701112; Mon, 09 Oct 2023 05:48:21 -0700 (PDT) MIME-Version: 1.0 References: <20231006224624.444857-1-robh@kernel.org> In-Reply-To: From: Rob Herring Date: Mon, 9 Oct 2023 07:48:07 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] fpga: altera-ps-spi: Use spi_get_device_match_data() To: Xu Yilun Cc: Moritz Fischer , Wu Hao , Xu Yilun , Tom Rix , linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 09 Oct 2023 05:48:31 -0700 (PDT) X-Spam-Level: ** On Sat, Oct 7, 2023 at 2:56=E2=80=AFAM Xu Yilun = wrote: > > On Sat, Oct 07, 2023 at 03:43:41PM +0800, Xu Yilun wrote: > > On Fri, Oct 06, 2023 at 05:46:24PM -0500, Rob Herring wrote: > > > Use preferred spi_get_device_match_data() instead of of_match_device(= ) and > > > spi_get_device_id() to get the driver match data. With this, adjust t= he > > > includes to explicitly include the correct headers. > > > > > > Signed-off-by: Rob Herring > > > > Acked-by: Xu Yilun > > > > Applied. > > > > > > > > static const struct spi_device_id altera_ps_spi_ids[] =3D { > > > - { "cyclone-ps-spi", CYCLONE5 }, > > > - { "fpga-passive-serial", CYCLONE5 }, > > > - { "fpga-arria10-passive-serial", ARRIA10 }, > > > + { "cyclone-ps-spi", (uintptr_t)&c5_data }, > > > + { "fpga-passive-serial", (uintptr_t)&c5_data }, > > > + { "fpga-arria10-passive-serial", (uintptr_t)&a10_data }, > > Sorry, one more. Should cast to kernel_ulong_t? Either will work. uintptr_t is somewhat new in the kernel and preferred now I think. Rob