Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp1870025rdb; Mon, 9 Oct 2023 05:48:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF9ab3Dz8DPW10Q30QLHjiHz/ge0NJhgzUsL5MFKTCb+OtV9CM//46KI3eCWA2H+nUTTWpO X-Received: by 2002:a05:6e02:1ca1:b0:352:61f2:8fd5 with SMTP id x1-20020a056e021ca100b0035261f28fd5mr19597292ill.18.1696855728198; Mon, 09 Oct 2023 05:48:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696855728; cv=none; d=google.com; s=arc-20160816; b=gzvTqU5Eyq5zBc2glDLxYxKCxhDuVrjhgCH9LRM37Nemy86nthv16ttzN6YNAMc2mv luRQuxHb20lB9NR/2DGAMO8Kk2RNX605+IGoPbXZyi51kdFRbZRPs611z+wwYDKXHRO4 1REKLn3USJBHEMBhGeMgY5E+if5fLlbUO7NFJBcjqNWkP6t1tC155aMhyljFaEE965wD eaFM7RIpvN1D47CtFqTSXquxZYH8RuzBX3ONWIpKsb5/TznwymoruQhiuUBpiuuii3rv ffRfV2wTPH3nb1r5xkomc73EtFcEZvgAHtXTC+YAWcg/l8tG1gsx7GXMpxm5YwD++aAz qfVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=jy34EsmsQ4zlGQIs0EyL60N40tSqUoCRP6CMCeIqR90=; fh=1ZkHVTCrfed7fnRZU7YVKqgFg7JK6z6sFbRMHNQqvQo=; b=rO1Ef2Z6DHcTD/lEs2fjwdwbnAUSLJQ9s5izDn22UTJfNbFgGl4EK+qBGX3WsMfp8A wGrUkflQdWWFMT8bVDiyQM35LG5Ld1KIE1AB8ShWkc01CWvJCHzyju3E/KTN3yRLrvY4 pTQauAtY/fYX2VdDikot0/bF8cd3zPI3NNy0oOdoZh/iWrMlaq2wCqZEDqnJLTV5SeF/ sc4pRKNUkKfQTyWUirb1OOWz6jnLYwqi55ek6Yua4GJNNKhHlADpgJOTuF0GPE0XlrHf bVKMFe+qbEYN9CHT3WO2HQ0q/NtYeZcUkIVg7SwrcJnFPSZfiGdW+w16e31Ljc+9wLD7 ILXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=CM+lnB7T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id z19-20020a63e113000000b005774a3b3efdsi4420969pgh.301.2023.10.09.05.48.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 05:48:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=CM+lnB7T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 386E7801F990; Mon, 9 Oct 2023 05:48:46 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376454AbjJIMsf (ORCPT + 99 others); Mon, 9 Oct 2023 08:48:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346619AbjJIMse (ORCPT ); Mon, 9 Oct 2023 08:48:34 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60A76B9 for ; Mon, 9 Oct 2023 05:48:33 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-3248e90f032so4439875f8f.1 for ; Mon, 09 Oct 2023 05:48:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696855712; x=1697460512; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=jy34EsmsQ4zlGQIs0EyL60N40tSqUoCRP6CMCeIqR90=; b=CM+lnB7TYV1/YX2c78qoI19iz6/OTKWazQeNXNyg2UhCpvQOAqdJh0VdWMYP8wRVYw tHIJvG5zHiIGXzZnKrQK6v5OC2hoiLjJ0FOFTxb9Eo+DyHAX5/sbn5EDIDB4CB+BXhdX S8JCXPAEaHfmvcsdIvxv7H5Cj9Vpd7CVIZlEhplZMW9PxapgW8z4cQWzXWE363lphJcn MryO4ea8Np0RQsaymL2WOWWk7rC34fHGRILB0bxdjXwcUsbZViefbrq5z/PiQrDU14b2 R5q+DuyPVHGXx9SMNXuCiQIdP35ejRKb4vsJq9wb6TH5tqpSD07BgrSynGlCm2nj28in ZpOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696855712; x=1697460512; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jy34EsmsQ4zlGQIs0EyL60N40tSqUoCRP6CMCeIqR90=; b=oW5MtyqlFI9CAeHJegs5YMjsVyST1qyMEaT8Z0Ni6W7K/ZcN+i/HcZU13XcpMGJxBi pLQH5dDLawhivkMtUcredxjMyV27zbsp2o4MH1AFaByHv6F0Gm2JJ7dV3ACrhqu021ag 2dzSRKTG33Zo0UX3s+S829F630YwvCT/7mIusmz8rxF7mknXaJGJz5uXq1G8Um68xGMz EmXPw4b5I8dcrg8XPReyxtHc+EhBrD2JWX8+GFZ0+Rcagv4HLsu+3DazjOzPOmd5mxsR 3fYWi0oPUJiZIerLVnTKt9x5vAAlufjfSY/SotfnuwUnWRE89AGowYnw7xrmoUaESdWn xFdg== X-Gm-Message-State: AOJu0YzzNfAY+ghYsBLCvHo2RnmwjjYnglbqzp9FPEx88rKqyAcdmG5q OpGrBAkDfSODpzjFbIWKipAp0Lcwhbk= X-Received: by 2002:a5d:62c6:0:b0:31f:d52a:82b3 with SMTP id o6-20020a5d62c6000000b0031fd52a82b3mr12894251wrv.46.1696855711563; Mon, 09 Oct 2023 05:48:31 -0700 (PDT) Received: from gmail.com (1F2EF237.nat.pool.telekom.hu. [31.46.242.55]) by smtp.gmail.com with ESMTPSA id b6-20020adfee86000000b0031f300a4c26sm9523141wro.93.2023.10.09.05.48.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 05:48:30 -0700 (PDT) Sender: Ingo Molnar Date: Mon, 9 Oct 2023 14:48:28 +0200 From: Ingo Molnar To: yang.yang29@zte.com.cn Cc: surenb@google.com, peterz@infradead.org, hannes@cmpxchg.org, mingo@redhat.com, linux-kernel@vger.kernel.org, juri.lelli@redhat.com Subject: Re: [PATCH linux-next 1/3] sched/psi: Change update_triggers() to a void function Message-ID: References: <202310092024289721617@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202310092024289721617@zte.com.cn> X-Spam-Status: No, score=2.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 09 Oct 2023 05:48:46 -0700 (PDT) X-Spam-Level: ** * yang.yang29@zte.com.cn wrote: > From: Yang Yang > > Update_triggers() always return now + group->rtpoll_min_period, and the > return value is only used by psi_rtpoll_work(), so change update_triggers() > to a void function, let group->rtpoll_next_update = now + > group->rtpoll_min_period directly. > This will avoid unnecessary function return value passing. > > Signed-off-by: Yang Yang > Suggested-by: Suren Baghdasaryan > Suggested-by: Ingo Molnar Thanks for the split-up! I'll remove the Suggested-by tags you added for me: I didn't suggest the changes themselves, only the split-up, which isn't credit-worthy :-) Thanks, Ingo