Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp1927230rdb; Mon, 9 Oct 2023 07:19:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH4OZ89gAoVb11AoJxsrZkVFfSp4GNnWMIEIrBDHAfi7r0LzhSctZQy72/NOkLVVSdPQo0n X-Received: by 2002:a05:6a21:3284:b0:16b:79b3:222b with SMTP id yt4-20020a056a21328400b0016b79b3222bmr12538921pzb.34.1696861182994; Mon, 09 Oct 2023 07:19:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696861182; cv=none; d=google.com; s=arc-20160816; b=azTthcitEWzfduCOAS6cB6Nr17+yEMkqcmuxkuto72/b16fakadbL1RxlL+qnkXUZ/ hKpHMO19dnzslBGduLCIremJrHM+OzQu5eUjBqKNdu5x/ST4Job/OxQAIGsG4TYQDSCj LENl1Y25K1/Ym7+ZJqQs9uAtakPh0UpJ7IqI/7CZGKleNIqkJz9hZ6jJNYPZ6g9tZHnP ypBkcoof1Ygcai1lr55qOoVhm1H3RypBjrDUWAybid9xH6jmU826vizImqCGqy4kWlpk bUxQj0DlnTVqdRONG92KHPf/an9Uetld5wlXUV091stBysgGsMqnAlitlUa8TOKm5X1g vHIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=aiXhVd+Skl1SDeXwfVwa1udc6/4a93csC6iL1H/Zlc4=; fh=ocKFAYXnDx4VTTGv96jforXecIDhYWw8gY1Cjoj8AGk=; b=KmiHScNtK26M6stGf+wPBYtF9+FudSIAT8Na38M6Uww9Bgr7AppY6Vz3Wmzf8o3Es6 Ps5iJ8A/8hVdzWDniEVQPXITJo8Q2LJ6rc/UT9wYLo6sp61B7RZq3Ec6Ibm4GR6c1pPc 3QfmOnc9lHKsk4R5qhMms7WwdVrpPKz7uzN9EkdlfbpDM8ugU226+CDt6b0YYllesug9 2qu6dP5XwYKRtauqgAIFnB+GxcIu35K/3Y1hgpfqHXqB4WHghOEkMXJPng9xsTZ36J74 SwBgELeHPO2xki11D10Pz2EVdbkKlkw0vi3vJQec/KNAelHmlw/gwnyyoXUtFYwOthyB buAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kceedgEg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id y11-20020a63e24b000000b00578ca751ddbsi9617079pgj.328.2023.10.09.07.19.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 07:19:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kceedgEg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 0ED7E80267E0; Mon, 9 Oct 2023 07:19:41 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377600AbjJIOTh (ORCPT + 99 others); Mon, 9 Oct 2023 10:19:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376999AbjJIOTe (ORCPT ); Mon, 9 Oct 2023 10:19:34 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5376499; Mon, 9 Oct 2023 07:19:32 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 254CEC433C9; Mon, 9 Oct 2023 14:19:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696861172; bh=5o5h5CgRG4H4Z5qjk2eknSticE7hPec++pW0EBNapec=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kceedgEgxB0UHzObI+BxpbPFb2TW/hw2iIrUfxd4PzxqAKsk4kc7/5bgS/m2df2Rr pFCHqRphEgn++36GwJAYtuus7JFWLWIczkpZmO8ULOzfpcOVbVhhfU0WeE+bEmKgUj elp7YAJXXhDCrh5P1qYP/SY0B0I0eXuzwXab3UJLZ2WiVyhmSZWiZyoU0gEjYGaiNL uAOk52d9TRaOqrwFHkm/9F2NHv+gZflDypnBwDFLQixvpwGwC3+rJthjdWPqhOu5y5 rLgnWgWUFXVO4Zoz7gNUUz03rsxjzwx+3MI9kAKzvMBPsvR4vtVlKnxGnF9VmkM35K dL4YZseD/J+Jg== From: Arnd Bergmann To: Jakub Kicinski Cc: netdev@vger.kernel.org, Greg Kroah-Hartman , linux-wireless@vger.kernel.org, Johannes Berg , linux-wpan@vger.kernel.org, Michael Hennerich , Paolo Abeni , Eric Dumazet , "David S . Miller" , linux-kernel@vger.kernel.org, Doug Brown , Arnd Bergmann Subject: [PATCH 03/10] ethernet: sp7021: fix ioctl callback pointer Date: Mon, 9 Oct 2023 16:19:01 +0200 Message-Id: <20231009141908.1767241-3-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231009141908.1767241-1-arnd@kernel.org> References: <20231009141908.1767241-1-arnd@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 09 Oct 2023 07:19:41 -0700 (PDT) From: Arnd Bergmann The old .ndo_do_ioctl() callback is never called any more, instead the driver should set .ndo_eth_ioctl() for the phy operations. Fixes: fd3040b9394c5 ("net: ethernet: Add driver for Sunplus SP7021") Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/sunplus/spl2sw_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/sunplus/spl2sw_driver.c b/drivers/net/ethernet/sunplus/spl2sw_driver.c index 391a1bc7f4463..bb4514f4e8157 100644 --- a/drivers/net/ethernet/sunplus/spl2sw_driver.c +++ b/drivers/net/ethernet/sunplus/spl2sw_driver.c @@ -199,7 +199,7 @@ static const struct net_device_ops netdev_ops = { .ndo_start_xmit = spl2sw_ethernet_start_xmit, .ndo_set_rx_mode = spl2sw_ethernet_set_rx_mode, .ndo_set_mac_address = spl2sw_ethernet_set_mac_address, - .ndo_do_ioctl = phy_do_ioctl, + .ndo_eth_ioctl = phy_do_ioctl, .ndo_tx_timeout = spl2sw_ethernet_tx_timeout, }; -- 2.39.2