Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
From:   Niklas Cassel <Niklas.Cassel@wdc.com>
To:     Ma Ke <make_ruc2021@163.com>
CC:     "dlemoal@kernel.org" <dlemoal@kernel.org>,
        "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] ata: sata_mv: aspeed: fix value check in
 mv_platform_probe()
Thread-Topic: [PATCH v2] ata: sata_mv: aspeed: fix value check in
 mv_platform_probe()
Thread-Index: AQHZ+rwN5B4BC+3D3EianOt6+pON8g==
Date:   Mon, 9 Oct 2023 14:22:37 +0000
Message-ID: <ZSQMqTos1/y0/eeC@x1-carbon>
References: <20231009124955.4046988-1-make_ruc2021@163.com>
In-Reply-To: <20231009124955.4046988-1-make_ruc2021@163.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GXY/yDfGO7UFL8FBImGYYPJYLSBEgyfNumJtsaI0Mc6BONv9Gxl97hHfm4qV?=
 =?us-ascii?Q?WrMGGmKvegauqzVPXd8863wRAyN1DZbG0QrG7+YbPP+tpfK/vO3u7uc7nCfd?=
 =?us-ascii?Q?VnMnYYFv7TPOl2X11lLUVwhv7zH0ANj78p+DwThLSL71Y6QPFcZADgREIK5R?=
 =?us-ascii?Q?pN7i+I4BlwsrEmwel0frjy9I9gsnGMi+rOjFV7XJdb5izrd2NgHiRbldpXLd?=
 =?us-ascii?Q?3SKSDfrOUJ16Yk2OqZhsNQbkZzW1yTEnWC1sUsHD/Mngjll1F2NpolRk1D+E?=
 =?us-ascii?Q?W2wJH07OFAfdBGGKemq9kLMLeCi16Dcc8lrPA/XnsxPnOcbwtmj2fm4II+O5?=
 =?us-ascii?Q?iDGz1aC27t9wmZSqEGw/Ic/4yK5KcyFpM8ZTKJiEdKYjVqWmliAGdlD7aa7o?=
 =?us-ascii?Q?gNhf5ewo58ZD07cPwZM3++ZNAcDiPmM60VnrAamUdLw8u2NrRe/tSVdAGPoB?=
 =?us-ascii?Q?JhS83GpWI7/QlZ4tg1UELHGt/+CAD9i9cMMrQYgrPAz/08EK73+7azwz5qHv?=
 =?us-ascii?Q?6YxWjDAfPzCvSHOHdTmDGy4olTILB1CyFa+Oh7+KhBV934Krhkv7vkBQZUC8?=
 =?us-ascii?Q?Xyb/68cJeG74jo2Eetk61dR/zOiIvRH7hHg8aJGVWlveHx2JKdjDTOugmqzy?=
 =?us-ascii?Q?9g/YXOUDbUpB3/mqYl18XdS67pWUeHjCHn/4eoJ4sTgccbhVnQ1M5MAPv6Wy?=
 =?us-ascii?Q?qMfiQnnvFHys0+Y+jiEMZqzaffOQGzMXGgCaUGyxrNUgW7Pl02113KqVXvtc?=
 =?us-ascii?Q?iXSR2W+YdI597bIR/dO8aI0o9V0XFGM5/PJe/oWw9TEV3JUVMsjohZ45nOlY?=
 =?us-ascii?Q?nEySe75RHN00uHQ3dCytlMN5rckSex/I4FF7E47Zz9V+kaCBhAIHwBAm49I8?=
 =?us-ascii?Q?AD5FolAE5jhP1wG8wjZN2HNVUXgJgS9zLtrkCMJniJeVTUILMau7DtAr3re8?=
 =?us-ascii?Q?2ldeWlN9fQtgf8H/kcnwkrIWxZKt1SeHNZQ2uvstulpMd+bADZ0JHXZLQf6Q?=
 =?us-ascii?Q?eI8N/1hw8N8+e3YrbiXhSD+7T1tkvZBN5lHrL8rL/11NwPU5fc/JIgmb/9LS?=
 =?us-ascii?Q?bhLMt/3b6/3Y+HrSlivPBRumJnBRfvmT7RxPycy0sfZF9tQItCpabShm+kOX?=
 =?us-ascii?Q?fM4xDMqUzToHhhnzBkvG/wgnxjBjJBiVzXiFQfSTKM3Gu4zuWH/Bm5iUW+d5?=
 =?us-ascii?Q?Q32cwGZAF+oefZl4OsRiNn7YaeXCj5VlWdlxdtxiOo7u+Y+t5Qva7ri+vL+y?=
 =?us-ascii?Q?yPlbWsTqhpJtQMByhx8PWTr/W93ORLAOn/kBG1SbkQ8/PEoMxFLB1dnQzQIb?=
 =?us-ascii?Q?wNYmjTNBMZtXd1xHvPffrdGZG+t5fAWMowGwr2mxxb1nPDfwXZOX4Lfhovk6?=
 =?us-ascii?Q?8VpqR8qHBMIdXCCz//65aXNPWvff9dglC+RIyBqRf7quZum4RcIiMBhwosZ4?=
 =?us-ascii?Q?ZXZ39GvSv2y3PRliXXMAeNSHgdJH6Mwn2K7c37iAbPcN1x9yAGHxHalKsLal?=
 =?us-ascii?Q?o/VYvGnHGR1McQsB7y2lLQB41F8HgCvwytmj4C5CaJNVJIApIf/Q9/Ry3A+y?=
 =?us-ascii?Q?+04MaHfHyc/kffgPI0Ci2nzmd4TNh6wDGIGOC4r8+Zlgy0Tw0t4SrIw5TRyt?=
 =?us-ascii?Q?lQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <D76A580830580B4B905046FD7A8498D9@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: a48H8+yfpS4VXFbfFHaAAkS6GYYtyNwCLH3Rj0llLOATw3GOKRCQ+rFC5MXVdOSV+Igf5i/k+vyNWwpmuQ+DGtqMm6RxRo26Agl2KYw9vQJpOq+995CzaRXGOFmz1ljjGF7Dpu70A1qaSRtc6Drp9NyN3YjJKSLO7YDeO9eReqPeJiXYeQoQrKijR3HqXEthmVpYBIbHf+z8nyJWsFH+688D+PxOLqI/rRsDoP/pRmpsK/bnbkNTD4HKURgoi0fkFv5ckw5UFcS89N3pzjD9WyVu+DMNzhwtI/mGh37cxRlJU8a4wWf/BvClcQ4i1s0vVS1oWdOuM34MPWsqfroqL+x7KvYgV+0lmV1x+3GZp5+vWmSkxAk5CGjnyTRpc6adNLG6mz7LUs2bfsiPL3sfLv6RZfoFLPlMZDFcMaImlshLRhaWQbeEdZNZBk44T/7l85tMkrJgWngQIRaQwmE1cmN7KgukzTFCFlQC05lTuJFwpv74e2Bn/RRuMVXOcVoobtHwF1Im6p7pdOADHslS9YC/DcXw1putR8YWcy/a40b+MLeVeX2vBTYxwxAM/rOOpx2FE/Ww9nITFd0IrAzXAtnV5miDsjAjyR3fdvTb9M1kX9FYuM945rJK6BrF6yBykU26WXVWmK71uYEs0u4I0/ghUXy4LyvF/z9/2RUxfDPfjrJNxjnKn23r7zQ36CYeH2LuWAn0tG2EANZiswvMZM2XVBqMqrLWZfNrt8AxAowEF4Dxa6hAplqzXSw6oh+sUIpBKNGCMVB2+aBTFW8rCpA8rsWh3Ixm1xKQ2QuN8x5zxwzw2FoOjZsmSePyokxsj3LXbEXsD5L+W1mSDnqiHA==
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN2PR04MB6272.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7f2edb1a-89c7-4b9a-105b-08dbc8d33049
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Oct 2023 14:22:37.6217
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: NgD4U5JS5fJk2UAp7nPqMZVoJzcd0QSNM7DFe9tolk8f9R4UAVPRA7Oq5TdnnogqfSfAS9RtsbiPFbqpd5zLdA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR04MB6807
X-Spam-Status: No, score=2.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,
	SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 09 Oct 2023 07:23:08 -0700 (PDT)
X-Spam-Level: **

On Mon, Oct 09, 2023 at 08:49:55PM +0800, Ma Ke wrote:
> In mv_platform_probe(), check the return value of clk_prepare_enable()
> and return the error code if clk_prepare_enable() returns an
> unexpected value.
>=20
> Signed-off-by: Ma Ke <make_ruc2021@163.com>
> ---
>  drivers/ata/sata_mv.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
> index 45e48d653c60..df3a02e7a50b 100644
> --- a/drivers/ata/sata_mv.c
> +++ b/drivers/ata/sata_mv.c
> @@ -4125,8 +4125,10 @@ static int mv_platform_probe(struct platform_devic=
e *pdev)
>  	hpriv->clk =3D clk_get(&pdev->dev, NULL);
>  	if (IS_ERR(hpriv->clk))
>  		dev_notice(&pdev->dev, "cannot get optional clkdev\n");
> -	else
> -		clk_prepare_enable(hpriv->clk);
> +	else {
> +		rc =3D clk_prepare_enable(hpriv->clk);
> +		goto err;
> +	}
> =20
>  	for (port =3D 0; port < n_ports; port++) {
>  		char port_number[16];
> --=20
> 2.37.2
>=20

Reviewed-by: Niklas Cassel <niklas.cassel@wdc.com>=