Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
From:   Niklas Cassel <Niklas.Cassel@wdc.com>
To:     Rob Herring <robh@kernel.org>
CC:     Damien Le Moal <dlemoal@kernel.org>,
        "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ata: xgene: Use of_device_get_match_data()
Thread-Topic: [PATCH] ata: xgene: Use of_device_get_match_data()
Thread-Index: AQHZ+r6tyqEqExIopkKdwhLCRrgP3g==
Date:   Mon, 9 Oct 2023 14:41:25 +0000
Message-ID: <ZSQREEr0WBk15fFJ@x1-carbon>
References: <20231006214433.339688-1-robh@kernel.org>
In-Reply-To: <20231006214433.339688-1-robh@kernel.org>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zW3PzYWEB21KB43Yy9JUHT4zUXyHaE/PsRe0L5YdO35xASqbTdGaBSLiPU2+?=
 =?us-ascii?Q?DKXWF76D+okxDuhPjFf09rKWvK5OAwB4vfh+Q50ammbgdN0YDSnktIKjPYlQ?=
 =?us-ascii?Q?3qkBlolAF4TUJWEM50TZWn4UsANp0Ge0AA/sRZ6COJ1cdpSz5yeRCXYV/RQU?=
 =?us-ascii?Q?CSLbVraMnrz92cGiatSEN2CZlMmYO2b24QpEiuaC31vX7SgEryJ7W1Ru+BLd?=
 =?us-ascii?Q?dwtJC+TfXwKi5dDQd6qCTpafnqWUYxI74r5F8aBpGVNGrtDUfIpgWB0q0fPo?=
 =?us-ascii?Q?K+pkrvtRC1E4agzxQZtmYBl2n+W7aWPFjOYGQpiqdN710qdynWYG2z5vJ0V1?=
 =?us-ascii?Q?UJSRABaI+IQzc5ZdVKMh52Dj95+P2a84Jr3+boYfEAvaKLDQ+PGK9XY9jYo5?=
 =?us-ascii?Q?OnCtri43J/uYtqzt2JKQ1xrSyBsOzMnHMX5rvPA5tTcO9PtPLxMEBZfg83ou?=
 =?us-ascii?Q?Eo7giyl1ue0B72nwbaXhIwVEaueRejgRbJ9z/dLuStI6FaP9zYGM68JPTuPd?=
 =?us-ascii?Q?J9bKMCS0awLL5cTkcaftCFasxNNdmHQrEY2/1i+sFgpyx0a2+aUXgHzG8Kmc?=
 =?us-ascii?Q?IY2OjNh9ovKnCQfJOX5rQHnDcGtPQudOEElafh04rM3apTSQ0lTE2BTNvUX9?=
 =?us-ascii?Q?vPYVANY33Fyjh3xGJJBdcpGHGJRWuuIFAKTrhrkbimnRBM4AzkcGIGv6iwh3?=
 =?us-ascii?Q?MgnYa4CHlbe88pv1FGIQdiTBpCxVkckRZn7aDkDx+6x5KFz5jrwenKHmmmcr?=
 =?us-ascii?Q?Ewwf11ehtKM5Knrm4/BIYOUvc3Ou5M6im21v1RLH1RJw2mlVY1dR1s7uGT8n?=
 =?us-ascii?Q?tSrKf+Ks6sa2yP2J4YHPtKhkc1UhL30RzD8RZKGDKVfFAv++0NCT7ck48kTX?=
 =?us-ascii?Q?dSRsh5vqoBkvvZG51gulDYrruAa081q2H71odQoVHqANTn2786P3KbZIJL+u?=
 =?us-ascii?Q?YV5XopvLf0oT58xAJQGeQ+Wunf9iLFQaBEzS1F79pFBYFneGJvt7GLaG6PUs?=
 =?us-ascii?Q?f8s6MlV3U9SiJWKmq0H20V/ZPcshQnR7flBBt/4dBY1nKKV4Zcyi1w2oDtMI?=
 =?us-ascii?Q?oJZn+Zw9PV7QFZEWeSNJeZkMNxTO2bDGZE1KmjO54Nd/LmVGsxzccUMs+cmO?=
 =?us-ascii?Q?qDQqXBGuF7IKGjPy3sGthrFfksN3VCB7dBfgjcRA3lVDZQak+T+K9M6n/Egq?=
 =?us-ascii?Q?nBZFm47olzBAdFJZuYLo7WVkCZixbBqcve6C58nzafLn80QDUlQA6tYH7OP/?=
 =?us-ascii?Q?1pOgaMW7JyvHpbE0f/3MCZrX2p/TcJgBJlJJEVh0jeqyX3P/sgvP7hz/VrPo?=
 =?us-ascii?Q?SCej9FGGcKOHIcQI/uK3/kKdWZbJgf5HetfsJTjEwj3P8Kytjwzuv0/R/eBA?=
 =?us-ascii?Q?Lf0sfABK6fp+gGz79opCO3e2GMp95DRlvdnD+FqPjd91U5LZrH46Ad3fIPnA?=
 =?us-ascii?Q?edzHJkUgGHl/EjDwPZ1l2gUpMe+X0lPTUlXN3eWTfSG9Jy+QgxVpbex+hWPO?=
 =?us-ascii?Q?4ldS2u0LBKWKuf3dMXu4DHXDVArcGrXZobQN6Oujc5WjXEn3lm4XoQgVMhv2?=
 =?us-ascii?Q?r6IyXQKKqFtZKp0uO3rIj7I5G1tBgBMTFXFM1RCCNkkbKwEFRN2hFsK5te9c?=
 =?us-ascii?Q?vQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3F3B4915C93ACB4E97A74058DB16D5C3@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Xz1pyvL+bqlHWC2MebmTdhRTcc9Lr4raG/lOrAZZaDtgLrR4+FfFJFmOr7BGEBnSBAOs383E1XD+lVL1h5mRpe1mNl4fMtztldPTT9OcyecNg1hMJ/vd8QhTSNW0SLptqx1uTIc1Msi2jAz89NmMssoZQcd8E+Eb5VhfwLcLzvIau6j8tv7pJ6MjKWX2hgKdFp4RhbxB2Ao6o/yDUvZqutFByHNdBZ5TFAd5tBW9MZgMBzhq4HsOJ1xo+iPzqX7k8szsS01dZvFXOJ8pwc05bqq6Rh6A/4ewj8lDOsGtfe49oQq2oPLXpZr2BIg3VL3if+ucbbMCn9fMjadK/GY/QJbIiD1JZ8nXDJlcIs7HlpGcxD+Re55neOMD+//WDQCSjwwzPbLc6QIuKYrU2a24HwEZLhEwUdpKVKN/ywrIDc08szj5FuzvR70JQLSr154crMqDh3jOS7VQqreSJ+zxlQyaJ666TnetIz+N1zad/lVcha90dA11wafNABgOJ28Ef8F5ogop4Iykh2c+YZaE3uXlArhNf6PGR2H5EwDZGv0g1NK1KhIi4FxYBQeG1JUcsnB6uC2ZnRjRdUqw/BwRJUI/KKyvKtDhDnzGp1zWFXvJY10+Da19+0AQrXtKyu0oUYkysUGzdp4E+gSQH7heP86dUmI1k/k2Yfi+Hbq5sOCQ7XtBZZvaromLSAX17dHK0OhfLQf5S6VNI10jgJ83VYRb9h9xestlBsoSaYqLNGQy6Ix489jrnfYTGabJ/OCpBlm4Du00+K0oLdKSc9J5U8tmcl4kMk5jcXc2bKyri8nbdxiZk6k2ThdDOO2XVvIx
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN2PR04MB6272.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5b598c93-0c0c-4373-9368-08dbc8d5d07d
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Oct 2023 14:41:25.3944
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: CMsOhZjHOdezeIMnSCBxq5bC1Xc1EbikucPo5qDgpc0hOLf6QIg1kDrKtrjBTL5KvdMLFdLbiOGDdRsD5m0h+g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR04MB8717
X-Spam-Status: No, score=2.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,
	SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 09 Oct 2023 07:41:39 -0700 (PDT)
X-Spam-Level: **

On Fri, Oct 06, 2023 at 04:44:33PM -0500, Rob Herring wrote:
> Use preferred of_device_get_match_data() instead of of_match_device() to
> get the driver match data. With this, adjust the includes to explicitly
> include the correct headers.
>=20
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Perhaps device_get_match_data() could be used here and all the ACPI
> specific code dropped, but not sure if all the ACPI code is really
> necessary.
> ---
>  drivers/ata/ahci_xgene.c | 11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
>=20
> diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c
> index ccef5e63bdf9..81a1d838c0fc 100644
> --- a/drivers/ata/ahci_xgene.c
> +++ b/drivers/ata/ahci_xgene.c
> @@ -13,9 +13,7 @@
>  #include <linux/module.h>
>  #include <linux/platform_device.h>
>  #include <linux/ahci_platform.h>
> -#include <linux/of_address.h>
> -#include <linux/of_device.h>
> -#include <linux/of_irq.h>
> +#include <linux/of.h>
>  #include <linux/phy/phy.h>
>  #include "ahci.h"
> =20
> @@ -735,7 +733,6 @@ static int xgene_ahci_probe(struct platform_device *p=
dev)
>  	struct ahci_host_priv *hpriv;
>  	struct xgene_ahci_context *ctx;
>  	struct resource *res;
> -	const struct of_device_id *of_devid;
>  	enum xgene_ahci_version version =3D XGENE_AHCI_V1;
>  	const struct ata_port_info *ppi[] =3D { &xgene_ahci_v1_port_info,
>  					      &xgene_ahci_v2_port_info };
> @@ -778,10 +775,8 @@ static int xgene_ahci_probe(struct platform_device *=
pdev)
>  		ctx->csr_mux =3D csr;
>  	}
> =20
> -	of_devid =3D of_match_device(xgene_ahci_of_match, dev);
> -	if (of_devid) {
> -		if (of_devid->data)
> -			version =3D (unsigned long) of_devid->data;
> +	if (dev->of_node) {
> +		version =3D (enum xgene_ahci_version)of_device_get_match_data(dev);
>  	}

Nit: braces can be removed.

>  #ifdef CONFIG_ACPI
>  	else {
> --=20
> 2.40.1
>=20

With or without nit fixed:
Reviewed-by: Niklas Cassel <niklas.cassel@wdc.com>=