Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <b8dca5f4-533d-4a9c-a177-fbdf3ad7848a@amd.com>
Date:   Mon, 9 Oct 2023 09:56:41 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v11 14/20] cxl/pci: Map RCH downstream AER registers for
 logging protocol errors
Content-Language: en-US
To:     Jonathan Cameron <Jonathan.Cameron@Huawei.com>,
        Robert Richter <rrichter@amd.com>
Cc:     Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Dave Jiang <dave.jiang@intel.com>, linux-cxl@vger.kernel.org,
        linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>
References: <20230927154339.1600738-1-rrichter@amd.com>
 <20230927154339.1600738-15-rrichter@amd.com>
 <20231002155658.00004ac0@Huawei.com>
From:   Terry Bowman <Terry.Bowman@amd.com>
In-Reply-To: <20231002155658.00004ac0@Huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?KzNJUXRBY3NHeEh6WmpteE1iM3ZYK082NzhQT2xsSUJFZVhOQVRLRXYwRDV6?=
 =?utf-8?B?eDhoaTF3UVRSbTBCWnBjWlFsQVJmMUlNMU51NDdPTk5Yc3lBbUk4MXJnR1dE?=
 =?utf-8?B?cndmRTFXTXFEdllPRWRaTWJJQmxDcGxYZVdoVWNzMms4VldSWlhLRVVueWN6?=
 =?utf-8?B?MVRjeFN3LzhlUVBBbjlHeVRmZldnYlFuU3JhdjdJbk41aGthV3VDenQxRTFl?=
 =?utf-8?B?ZHF0QW5ILzdqa2JoZXU5L0hEK0tEWnJLblNVeTZ4dXVFa2hwc0d0cmluTnF1?=
 =?utf-8?B?K1lqWmtYakdVQXNLWC9uTEw1KzZXQW02WE5SVGI4WlV0Yldtd1ZBQjFjVVZJ?=
 =?utf-8?B?cTFXczE5a2hJaVRrTkFlbWlHUllqRm5QUVVjYTJMY1lKTXZmMkNzcHZoeDRX?=
 =?utf-8?B?SUloa2lLMDhJNFVwTnZKMk5zSXh6OERab1ZEbjhTTFhxVmw4MWMyWVU3QlRZ?=
 =?utf-8?B?RmpYcWk0cDc3QTlMcE1NcUxkc2VLT1U2eURkS1Foa1NES29ldmw2aGc3MlJi?=
 =?utf-8?B?Z2FTYVZyVFNrc1I0elJTcmYzN0hWdmJ1REcxb0lkNWhqa3lyZk1Mb2ZhQzVo?=
 =?utf-8?B?dTdmWlJKMm1UWjZKSnI5NWI0bEh1ajhhZmw5Z3JsTFVxWFRRb3g4eVY4RVZk?=
 =?utf-8?B?OGVsVy9rN3BVc012NFdaK1NSb3VrWC8yblZKYlo5eVAxMzVjRkM1WkoyZDVz?=
 =?utf-8?B?U2gxRHJqcndJYkRPOU1CYm5ES0YyMVNjN29HcWFsVTJSenRNQW9QNVNYVDQw?=
 =?utf-8?B?Q3B6cVdzcUZuaDZDRzBuSHVZVmEyd0I0MHBvTFhLbFRYOGZQOENYeHJYcWpG?=
 =?utf-8?B?dUg2S3VjRGlmTDMvU0l0Mk1PVW9SSnFLZ1l4RnVmME9nVTBBcU9YK1VLYmVC?=
 =?utf-8?B?a1gyWG9oZUFNaFNqTGFCdTd5ZHp3UElVazJOOE1lQTRXVlgxZVcrMDZkV3cw?=
 =?utf-8?B?Y3pOTVZ3L1hzdFFQekVlaWVjbnErbkpzdVNxVGZYbllwcE81cTFYdURoQWtt?=
 =?utf-8?B?WmxPK0VyU3RmZVBIVDJnQWFWWUVSTEgxWDMzQUwxREkvc0xlcVR0WERoTDBi?=
 =?utf-8?B?aTAyWXNMUTg4MUlJWmtaWk9CQ3NDc0R5OWQ4cnZlVURsdTRaN01jcmRUS3Rm?=
 =?utf-8?B?RXJ5VlFwSUY5UFptSHBpc242WWZpVXNTb0g1K2s0VGtXYm1lL0t2bXVqb3Yw?=
 =?utf-8?B?c0tQVTRmRitiMnJVMi9CM3ZmU1RNV0dKL2JMVlRwR01tTGNDSlNjMzNqcUxE?=
 =?utf-8?B?SnlQckNxRG1iYm85WVJjd3JNNnNUaE9neXh3SUh4N21qUXc1NnFHZ2xaVTJS?=
 =?utf-8?B?cmkzRitGUkhNQm5lNGZBRFNKaEZsSWxhVmFPaDZ3amVNa0xKR0ZWNWRPK2Jk?=
 =?utf-8?B?cGtwdUlHbVh3dUxLQlltc0U5eG9ZY0k2aDRUcE5UYXZmMlR0eVZMTHNqTTBx?=
 =?utf-8?B?cHVsNkl3YWxXQWVyZGs1WSt2d2VDdjVoSG11cEFOUktKSGtjdWF0YjlQYmFz?=
 =?utf-8?B?Wjk1S0lteFZ2VndGbXBhcU5IQStabHZ1ejFUVkFrem1mcExqd3BsUUlrMHVU?=
 =?utf-8?B?ckJMTjJlSmcyT0kxZFIxOFlGQmlDYTRxcHdGRFcybjBwNEZLbXdGK1hGTmow?=
 =?utf-8?B?NmtiMGhtUEpMdTdRTHdrTkN1T3VPZWpNd0FtQ0d3VGIzcHR4ZE05aWpScWw4?=
 =?utf-8?B?QXpEdXpaLzVtaU1Hdnh6RXNHYnE1WEVWOWx6TUM0a0VHMGd3bG9rZjR6SDdV?=
 =?utf-8?B?VHlPRTAxRmlSeFdPOFF4MHZ0YzhNSWVSUWVIVDBpbCs1V0loMTdPMmtCK2pT?=
 =?utf-8?B?b3lJTVVVdHVzWDMyU01BaE5KdUxWUmNFNGVOekRVdHN4R05zNTBpdEkrMHN4?=
 =?utf-8?B?ZTluVkpxMi9kdFk0SlUyTlF4eFQrRW96RHdjemo3aFJHQ0hHcjBtL1kwTkpq?=
 =?utf-8?B?UndudU1jZ0x0NW9tcEFzd3YyRitRNTlST1FoUU1HOEkwelZvMC92TCtUSEpi?=
 =?utf-8?B?WU5kNnJ0QWpaN2UvbGhLMnBSQUVqMHovY3Z4Y2RpcFF3bW55Wm8raStUM25W?=
 =?utf-8?B?M1RuSVdiSGM1WmNUWWZweXB1dENVTmhYTldPYWRvZThLNlFaYVFHdXBNL1lN?=
 =?utf-8?Q?1GiADlOU8qRCJJr6TV7AskOpC?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 092fd3f7-ad67-4b22-c349-08dbc8d7f308
X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6390.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2023 14:56:42.5270
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pHQzSdy6cPGbunjikgLWajwg3fKGBc6Tu6YEXl7/E5ve0v6P1S9mpKb6hqz6w9vUWrWiTHnJlZz2/Mb9i5WIhA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5679
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 09 Oct 2023 07:56:57 -0700 (PDT)
X-Spam-Level: **


On 10/2/23 09:56, Jonathan Cameron wrote:
> On Wed, 27 Sep 2023 17:43:33 +0200
> Robert Richter <rrichter@amd.com> wrote:
> 
>> From: Terry Bowman <terry.bowman@amd.com>
>>
>> The restricted CXL host (RCH) error handler will log protocol errors
>> using AER and RAS status registers. The AER and RAS registers need to
>> be virtually memory mapped before enabling interrupts. Create the
>> initializer function devm_cxl_setup_parent_dport() for this when the
>> endpoint is connected with the dport. The initialization sets up the
>> RCH RAS and AER mappings.
>>
>> Add 'struct cxl_regs' to 'struct cxl_dport' for saving a pointer to
>> the RCH downstream port's AER and RAS registers.
>>
>> Co-developed-by: Robert Richter <rrichter@amd.com>
>> Signed-off-by: Terry Bowman <terry.bowman@amd.com>
> As before. Co-dev just before SoB. 
> 
> https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L521
> This example looks like what you have here.
> 
>> Signed-off-by: Robert Richter <rrichter@amd.com>
> Otherwise, LGTM
> 
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Yes, we will fix.

Regards,
Terry