Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Mon, 9 Oct 2023 08:15:13 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Konrad Dybcio <konrad.dybcio@linaro.org>
Cc:     Anshuman Khandual <anshuman.khandual@arm.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Xiongchun Duan <duanxiongchun@bytedance.com>,
        Barry Song <21cnbao@gmail.com>,
        David Rientjes <rientjes@google.com>,
        Miaohe Lin <linmiaohe@huawei.com>,
        Matthew Wilcox <willy@infradead.org>, linux-mm@kvack.org,
        Naoya Horiguchi <naoya.horiguchi@linux.dev>,
        Joao Martins <joao.m.martins@oracle.com>,
        David Hildenbrand <david@redhat.com>,
        Michal Hocko <mhocko@suse.com>,
        Oscar Salvador <osalvador@suse.de>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/8] hugetlb: restructure pool allocations
Message-ID: <20231009151513.GB3846@monkey>
References: <20230925234837.86786-3-mike.kravetz@oracle.com>
 <ddc10c41-515f-48c9-966d-4ae7756d208c@kernel.org>
 <20230929205731.GA10357@monkey>
 <ba5a528d-7e85-77a2-5096-5a143a3b1606@linaro.org>
 <20231006030836.GC86415@monkey>
 <5d14b681-a2c9-4210-a0c1-bf38708b7998@linaro.org>
 <20231006223512.GC3861@monkey>
 <20231009032926.GA3376@monkey>
 <070bd916-d4d6-41c2-9f51-af35e80c96b9@linaro.org>
 <20231009150401.GA3846@monkey>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231009150401.GA3846@monkey>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?s6f9D1C7ZmI5v2la8kG/SF5RtFW1u5Dj6vYlvaqIxFCp8QQrGYv4ppIY1eX0?=
 =?us-ascii?Q?eJqGdYqKINSEk5j8rvSSdKSwxTm5QnH77wPTK3JCfn7DOrRuYXyCd7AA/W+q?=
 =?us-ascii?Q?kuoI3SyBxgnPPCMrHcv4NvdNQeu9r/OL0pWwI1o9CzXh7adVqHRhocTr5yTP?=
 =?us-ascii?Q?Fpiknm2QKszg5qgRyFSEwyN1QUBMzTK6idY352n4iZhVjZ+eHAbnjc63kVLP?=
 =?us-ascii?Q?DHuPJo6DNaUTHBTK2Ab02A70pH20wT1GhXyfk5ZQORyO8SKdRe4lbAW+vusv?=
 =?us-ascii?Q?ckF74H2gco9yIK4ikAUy1FqzDb8eDMOiDCH5ijv0T7GA5HJesPeXTx5hWKOz?=
 =?us-ascii?Q?qyULn5s2tgwqZ1gCO4e39hXSkO0Ix/u2J9t/Av7kJ4zq9h8tFeft25fG8w9p?=
 =?us-ascii?Q?F7Yw4KHY7bXQ0qZIxLXSdsdqlTuZ3tmU4F4wHXxfYwbsAS1QUdLRLsbwI8tP?=
 =?us-ascii?Q?wz25C5NgjJy7CBGUUzOk3ibpvVxb3XYJmRHxSPwWae8TQpL//oG2tMyANs/L?=
 =?us-ascii?Q?/sqGT2mZf4FK2JwjBNKKzU8+AROjkPU+3WtHgO9tkJceSfip4nBPp4m00l6C?=
 =?us-ascii?Q?hT11WBOi7zWLPPyZWTjEejpyjyYXf1hXJjJw8X5ywhR7tQJ3ZdYE+M5scDG3?=
 =?us-ascii?Q?j8UkA9iU52pFS7JEtTIs+fWxB5+zDDzOt9ypWcq+ujhSCFfHcsiHiNCkB4IQ?=
 =?us-ascii?Q?j+Wei4Fq78ac2yjlFip1u50RKdMJURiwYnVs/wfRiziHce4hVYhky6BmVtcG?=
 =?us-ascii?Q?hKiISrqXNq8oE8TADoCtyENFVnVBhgN/2vDa2ldLrKqDdNbQ5Ksjzy4OxTBy?=
 =?us-ascii?Q?KyBa82B01wDZ1BnkfAVCGP+inavzQkWn3JL5ShRiElD3pf/VETYBHCIpIGja?=
 =?us-ascii?Q?gqALaPZNdClMluIObnX37Vp+4LxcCwNru1yiFpNOwHtorTt/hDucHVUtvoPy?=
 =?us-ascii?Q?x+sw2r/dQVSwpHRYx10r26f+PcsRXR0sKl02PD8a12H6ZM9v3Tz6H8KYsOOO?=
 =?us-ascii?Q?7HO4gy3Sj3Y7OGGkpO4BBijPT13Rm8dWFjL93BSzLZVlf2dzQvv7C+bW6Gy+?=
 =?us-ascii?Q?PEtvJaJQMQNhYZb9rFuwfQpp93U7nyZOdM9tPmAZsBg/7c9wusVryLReAXZN?=
 =?us-ascii?Q?Xx3WrN0c9u8+Y2askRXM39AH8rT/d7SdzCV2P+pCTdNdqR1rFjUEAW4OypwC?=
 =?us-ascii?Q?EFqZCDxeqsLUQ2QFvfcYfu+7BtFMQY5C1tqQNIaCANPhx0f3tIpA1dn8DBrq?=
 =?us-ascii?Q?7xXtvEQhgsr3CvLo+YzqYRTCOGAXrtEVJb3LP8rFbWSlxmvfif96uI69cOYH?=
 =?us-ascii?Q?zAfiNHrW9FnKgNx3Fd02OKWWQLpGyHswERACjckyAov+khv6uaFFUS/CLqAQ?=
 =?us-ascii?Q?TBE/pWHStjzzA1yorOgWvIm9ALE+HQF7sooC+r5B32n1GJy1UrVpOVgz9pUa?=
 =?us-ascii?Q?CPhV+7zSM6O0QFeqo3AFbQGKGR9vUNEZAhJcde2TveNc3jnmHKSaR3O4kdQY?=
 =?us-ascii?Q?cUYYR5P14VUPJeroArR8KS9UnzIcmk3jRitQANHu+73u2qshnJV/WaEQY3x4?=
 =?us-ascii?Q?1H3bpvZTk4lqkk7BGPNC4oQMmvUhc/vsm8jbWx2vj+/sLeS03XWgDb9/f1cQ?=
 =?us-ascii?Q?ig=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?TCiFuu1yeqLwtquPg1I4kBan6skFVwg+mCsyUv44g4nMA1k+YX54UIauU+q9?=
 =?us-ascii?Q?pVtNyKjbOt/3JtfTz3pHnIsgflr+UUQUchpPoqlaW/YGl/rWruTxn8J/aqBP?=
 =?us-ascii?Q?u9HX4aZoyKDr6BwgqsRwrtxWbSUxILfYsGoz5UncO2hZNaDOyayuxH9xnInK?=
 =?us-ascii?Q?VOOhUqPgrLcg9XjOYMVu/hzWIG92TYQOc9PcZ2OfJgBJ+mAytCprh8PHutEA?=
 =?us-ascii?Q?ubIKiXnhXzXklCW1nf/qbp6QH0gTfE3BFSRmlIBazTTqqz4rHBnOc46pKwxV?=
 =?us-ascii?Q?LQB8P4cV0jG/E/EvVOvH2Cb2DCnnrJaH1bh+v1gYF9vg2cdpK/4WegC9Qkf/?=
 =?us-ascii?Q?9rWlL0j/DvltukUDEt3H/5Zs6DII58wKJU/0t+PwXvxTPW5s7LzEMnwOSJEG?=
 =?us-ascii?Q?uvXQWUQoETGwrotOkgMkJ+TyNgO+c+SGA071itrjH4ZSAMGBdCoFXJLFOVsJ?=
 =?us-ascii?Q?ELvfpGKqwIR39qdaG3JAdVuGay1R+XJdye4pzuQORRQG4gDiO/oMNRmF7zJX?=
 =?us-ascii?Q?9mWmg676dhMAvYDa+swD9Ph/TpGbz5YkB6RCLH6WXbCiKTzbbvMBufGqP/h7?=
 =?us-ascii?Q?p4paFq/GJXxvKrKIinrzu5LYrfkCrzdW/yvx7hrHhxhhy2yHUROhD1O4rYqb?=
 =?us-ascii?Q?n0NMgu3ZhG5AFLsLJXQZV5cF5BXNEj1z784iz74997ZCqZxZdSPy7tZEUVZB?=
 =?us-ascii?Q?xAqZrJdFjjO4Nq6kcHSVWQNZKcsXHRtpyTWmA/l98R1YUVuJW7L/P3v0wlw1?=
 =?us-ascii?Q?AvQbT5gKHuVGyqqMwxPr9jbb0VmpZv4B8v1mlwxaP65pLmBeGz7XLGwDMdQ0?=
 =?us-ascii?Q?Ju82axl7cUFAgOvN1rr82IViPYGkzapfh98aUCJQG20LrxQ/nszREv+1yU7q?=
 =?us-ascii?Q?uRyJmmF/aayblAU8O0jVpZ2sv9Rvjl9kW6Hb/L2ACdoHD0qBw9lHCwb8Srj6?=
 =?us-ascii?Q?eaBEsA1ktenqZTFYiFHf8QwUh04DGL/H5qTxgVKbHv5yZC83jAf+3yiv7VtC?=
 =?us-ascii?Q?ALttV9AScyfvUpXe6wvjrYECCasdXfeY+TktHAngOFax0hYJFWm74Xgy2NUf?=
 =?us-ascii?Q?swPbHHTwh1zvEusR0S/EZuaoQU3JWT8P41M303qqCMAedhXekbzI1XNu970r?=
 =?us-ascii?Q?0d6gVEKTAGNf2h6Ay6UcPxLfgaTmKbl4LA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f9d910e-c126-4e94-45e8-08dbc8da8b6c
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2023 15:15:17.2568
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iSQ8S/EG4VrSO7XCqp7OxM7Hcg6cvnS8YL4UczdY1wZ0bAq2EKYdgqWrMOg3ggmcGs5DLynXH4Z4xCUUei+hwQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB5703
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-09_13,2023-10-09_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 spamscore=0
 mlxlogscore=999 mlxscore=0 adultscore=0 bulkscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000
 definitions=main-2310090126
X-Proofpoint-GUID: UdlL8MuQhJ_YQTsa7LBzpZu0TnaXjnVK
X-Proofpoint-ORIG-GUID: UdlL8MuQhJ_YQTsa7LBzpZu0TnaXjnVK
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 09 Oct 2023 08:17:34 -0700 (PDT)
X-Spam-Level: **

On 10/09/23 08:04, Mike Kravetz wrote:
> On 10/09/23 12:11, Konrad Dybcio wrote:
> > On 9.10.2023 05:29, Mike Kravetz wrote:
> > > On 10/06/23 15:35, Mike Kravetz wrote:
> > >> On 10/06/23 23:39, Konrad Dybcio wrote:
> > >>> On 6.10.2023 05:08, Mike Kravetz wrote:
> > >>>> On 10/02/23 11:57, Konrad Dybcio wrote:
> > >>>>> On 9/29/23 22:57, Mike Kravetz wrote:
> > >>>>>> On 09/27/23 13:26, Konrad Dybcio wrote:
> > >>>>>>> On 26.09.2023 01:48, Mike Kravetz wrote:
> >
> > I managed to get a boot log:
> > 
> > https://pastebin.com/GwurpCw9
> > 
> > This is using arch/arm64/boot/dts/qcom/sm8550-mtp.dts for reference
> > 
> 
> Early on in boot log before the panic, I see this in the log:
> 
> [    0.000000] efi: UEFI not found.
> [    0.000000] [Firmware Bug]: Kernel image misaligned at boot, please fix your bootloader!
> 
> Isn't that misalignment pretty serious?  Or, is is possible to run with that?
> 
> There are no hugetlb pages allocated at boot time:
> 
> [    0.000000] Kernel command line: PMOS_NO_OUTPUT_REDIRECT console=ttyMSM0 earlycon clk_ignore_unused pd_ignore_unused androidboot.bootdevice=1d84000.ufshc androidboot.fstab_suffix=default androidboot.boot_devices=soc/1d84000.ufshc androidboot.serialno=ab855d8d androidboot.baseband=msm 
> 
> So, the routine where we are panic'ing (gather_bootmem_prealloc) should be a
> noop.  The first thing it does is:
> list_for_each_entry(m, &huge_boot_pages, list) {
> ...
> }
> 
> However, huge_boot_pages should be empty as initialized here:
> __initdata LIST_HEAD(huge_boot_pages);
> 
> At the end of the routine, we call prep_and_add_bootmem_folios to
> process the local list created withing that above loop:
> 
> LIST_HEAD(folio_list);
> 
> This should also be empty and a noop.
> 
> Is it possible that the misaligned kernel image could make these lists
> appear as non-empty?

Actually, just saw this:

https://lore.kernel.org/linux-mm/20231009145605.2150897-1-usama.arif@bytedance.com/

Will take a look, although as mentioned above prep_and_add_bootmem_folios on
an empty list should be a noop.
-- 
Mike Kravetz