Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
From:   Biju Das <biju.das.jz@bp.renesas.com>
To:     Thomas Gleixner <tglx@linutronix.de>,
        Alessandro Zummo <a.zummo@towertech.it>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>
CC:     John Stultz <jstultz@google.com>, Stephen Boyd <sboyd@kernel.org>,
        Douglas Anderson <dianders@chromium.org>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Biju Das <biju.das.au@gmail.com>,
        "linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-renesas-soc@vger.kernel.org" 
        <linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH v2] alarmtimer: Fix rebind failure
Thread-Topic: [PATCH v2] alarmtimer: Fix rebind failure
Thread-Index: AQHZ7SyA4lmrPv0tQ0OIkUBZ8XwsyrBBqzEAgAAC0jA=
Date:   Mon, 9 Oct 2023 15:30:04 +0000
Message-ID: <TYCPR01MB112697A5D4B57101CDE27C88D86CEA@TYCPR01MB11269.jpnprd01.prod.outlook.com>
References: <20230922081208.26334-1-biju.das.jz@bp.renesas.com>
 <87il7fq1al.ffs@tglx>
In-Reply-To: <87il7fq1al.ffs@tglx>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?QS6Mbx/Qsq5jAfLCttPxfyNHAilRZ6/3hOFkrgNvc7Yj6yuhXMxHWiVopqC7?=
 =?us-ascii?Q?kpK8aoqFahWCGlBqlCsxQ7rcXy3Q+bDpuSLUP6fW3c+iniKZOf+XUbbkgnTB?=
 =?us-ascii?Q?cRBHaIPr7ALKlwMzED4SPjXuRbkOxlKOh1EsJ486VpAxtD6yp30FQtbbbSml?=
 =?us-ascii?Q?G3DhxBY/BBF8usdmGMtbZWmCV2kprZNgpWoA3rhoXg6c/vOTtY/eZ09+e2bw?=
 =?us-ascii?Q?LMDR/u/QjnJZbLtE7YL8eL85Y+hk6MprEf68eZVPApybyihUvEMq5Di1YFFC?=
 =?us-ascii?Q?diWaicd0H3aYk/+JXgq88PrPIb21ZT4lV441Io7iugk7dG0p62qqpECGzqV6?=
 =?us-ascii?Q?YAGLL6uw7XOlxO4ccPeeMDrnnWpENNGZwCWm80VC4JgEV8m4pYpAEPNDPxBf?=
 =?us-ascii?Q?EM8vBq0vMKTiO2TvJdCuQK277SF2SWJxzOujaA7HkH6gdqwLv21R7OpHsGc4?=
 =?us-ascii?Q?al/KRhQlImAP9CmlVvL0HaYnK32D7nYU6Gbla0lTUHa7GVODG3+0oQr3YIgZ?=
 =?us-ascii?Q?2kggI5u4Os3XdmwAQs2kX1Wj8pxLug24/gYudSwjSFyx0hdwep7IHUfpqEB9?=
 =?us-ascii?Q?7HVufkfvIS8Qb+zYIkj1xhfZNTNfZwGEfnb0k9akBptSxa25RtN04+bvqaQ3?=
 =?us-ascii?Q?Cw27l1SoYyXECvjiH2Q0GWVLwWID0JSnW9r1ZlF1GURoBtddb8HQ47pX3RQG?=
 =?us-ascii?Q?qOerwOlWsz9GKDlA/QKA3DfwifoKSN2VNGwB6u0OrRBBFBc/t6eeElT9ib96?=
 =?us-ascii?Q?+RXNHlm7oAcPiE57/8+5JKOm7P/+T9jqFmxl8C1UH7EeWTk7mkT4L7w4grZd?=
 =?us-ascii?Q?6hhNHLWzsCt7xJnb0V6+7elf2d9EGeUlGs52sDZglmB2r9Qhe2q2WkpaWqP5?=
 =?us-ascii?Q?GbCkl13TXskWv8MpKYjY/rSi02ccvmH9zCOFiTXtLeyJD7+j5m8yB84jOA+Z?=
 =?us-ascii?Q?XAUWfqbmT+N42kMMD8fqjB2rqtXHUGj/gaoPCcrzsozJ0cBgt+BoMf5VE8Ud?=
 =?us-ascii?Q?hw14teIb3Us5hMVb23DtzD4t1t2igL2ETwCJDyCaXfX81znSo9eX66uZmNku?=
 =?us-ascii?Q?6c06SlT9GUzZEcPiJUNTBZ9VNa2t0Elf0tmZz8dYhp4ku8UPHPmSopUS1BX9?=
 =?us-ascii?Q?m9UtI2ZA6c+Kal9MTuIiTP6t7i4MI69K+QMcI+R7hiIeyCvkDqkTuzH5Rl1W?=
 =?us-ascii?Q?j0BJqEVTnbsbCnkcPmkjhgD3rxYLvQdkdkfIjxR5WxeAI3npwlR+ZVBb7HZe?=
 =?us-ascii?Q?ezH/O5XuGukBH6I+Y7diGRHxhBC03ow2gkSPUCbWhrCN5A9W5Ykbys7tQsis?=
 =?us-ascii?Q?+5LcR3j8ZstYot8T7mXJoZrnVcfLsztsRheNFsPgw1+iNq7VGy336VC3UjDy?=
 =?us-ascii?Q?uVriY4Z9Vfp4q95me8mfhT3GwmxGXywbh/zitjCXF6IDpgExt5/9V4hPoWlJ?=
 =?us-ascii?Q?Ce3p0CUucnt+WMiVn/uPiIhI/13eayuUa79go+4WLGdKEO9OqhSMK7E30zEy?=
 =?us-ascii?Q?GhchFB+xxbjX3bi62LLfRbXnmXxQTiF2IAROHbZAei92AJbaWwRF3Mwttnko?=
 =?us-ascii?Q?RBDR5V6mijAqWfYJC89mbaZz4tTxRpCGtzTDz9tlJWnSqS01sdwbK2a2JEnq?=
 =?us-ascii?Q?hg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: bp.renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB11269.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6cd84f4b-b65a-4554-da71-08dbc8dc9caf
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Oct 2023 15:30:04.9727
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xuTpYhGPz+AgDwp5ETiKz7MnE3DYsi3nhoXC39vuvc2doQHD69nl5HBlaTbsByA+VbH9fY4ZsX+n/MlFtUG8Se+zRcDgYY3SfEEOudeHejk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB5935
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 09 Oct 2023 08:30:29 -0700 (PDT)
X-Spam-Level: **

Hi Thomas Gleixner,

> Subject: Re: [PATCH v2] alarmtimer: Fix rebind failure
>=20
> On Fri, Sep 22 2023 at 09:12, Biju Das wrote:
> > +static void alarmtimer_rtc_remove_device(struct device *dev) {
> > +	struct rtc_device *rtc =3D to_rtc_device(dev);
> > +
> > +	if (rtcdev =3D=3D rtc) {
> > +		module_put(rtc->owner);
> > +		if (device_may_wakeup(rtc->dev.parent))
> > +			device_init_wakeup(&alarmtimer_pdev->dev, false);
> > +
> > +		platform_device_unregister(alarmtimer_pdev);
> > +		put_device(dev);
> > +		alarmtimer_pdev =3D NULL;
> > +		rtcdev =3D NULL;
> > +	}
>=20
> That's broken versus alarmtimer_get_rtcdev() and any user of it.

You mean we should update[1] (charger-manager driver)as it is the one using=
 alarmtimer_get_rtcdev()??

[1] https://elixir.bootlin.com/linux/v6.6-rc5/source/drivers/power/supply/c=
harger-manager.c#L1447

Cheers,
Biju