Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp1970245rdb; Mon, 9 Oct 2023 08:30:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE2Er3GZaVpNCSD4TYB6TJ76l9YsxZyoC0blZGpKjpMOKvMPWvqZcad4uX3IcFuQvpmmOdv X-Received: by 2002:a05:6a21:78aa:b0:16b:9886:7eda with SMTP id bf42-20020a056a2178aa00b0016b98867edamr12685591pzc.35.1696865452282; Mon, 09 Oct 2023 08:30:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696865452; cv=none; d=google.com; s=arc-20160816; b=Pt8Wg8fwS3sFhPyB1b/tgwQwcxh9uDpcCLG60EftuXTYV4fN0SpLH9voPln4ir80aI vYSBjCMjsSh4424XdRa5U6DL8jVh8RdIXlUpMsk4u6Pnbx1P54CSQkCx/Zh3sBATN1ox TInxouWOJT7rSEneOO0kQX4DTYAKELGesOvxtnYAc4FPpuyXLvjp5ER8jrBTZFgBsH9m cgJO2F9Q5bDaMbVxCUsFoQBUFAbmA3NNvH1i1EYiFA4bG7QgosFQbUYTG4gRfwPHO/QI UHBa1emGdCPNYoUmksESUMliuhC8yPQZjhMUcsmUG3+t/DIV/WSzIUui0WA6mMO8a3wW 6VYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:reply-to:message-id:subject:cc:to:from:date :dkim-signature:dkim-signature; bh=1HqVDwiKT9mbTGEItnnXsmJW+0BorQwUwbFjLDILKpM=; fh=hD77oU1WBmsQX6A8j02ZPlACXMS0pnyWPduz5AxI0EA=; b=Y6vuQ3QfhSgQQjiXqctgH+PvoggeNbCgPF8OBbAl2zHOEphwoJLheDczM4TYGCC+3v +rMRcUB7vjZ1DwjD0hirIgTcKrMef3uDG0UMzxZjS5L283DuD5iBl+jwFr7KMUVqso1v Opzq94c+HWE0xABbV8vec6XznZkZQJSxI6JS1a/Iclx/MgHQN3OHkRaQVWziQkYWwWLm mkCz56GGWNTh3y2XhcEMrXcdfhUGqF4iDklvlfba661y2Rbk2zmGsz1Y1mdHKzEBXzpd vs6hWPMIiQh8ytJOMZwCHdAXEZzGughPxMPaECGYU18WEL7dTaki7geXNW52utcw9Zl6 yfog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=IBt9Zzx2; dkim=neutral (no key) header.i=@suse.cz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id q8-20020a056a00084800b0069338b22bfdsi7747390pfk.205.2023.10.09.08.30.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 08:30:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=IBt9Zzx2; dkim=neutral (no key) header.i=@suse.cz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 5BFC880ABFFD; Mon, 9 Oct 2023 08:30:32 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376553AbjJIP34 (ORCPT + 99 others); Mon, 9 Oct 2023 11:29:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346514AbjJIP3z (ORCPT ); Mon, 9 Oct 2023 11:29:55 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E13DA3; Mon, 9 Oct 2023 08:29:53 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 596911F390; Mon, 9 Oct 2023 15:29:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1696865392; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1HqVDwiKT9mbTGEItnnXsmJW+0BorQwUwbFjLDILKpM=; b=IBt9Zzx2vnJP6XRjCOrKnO5zaH9qGvhlvFzX23Np5EN62Oka65H94E02xzbrf2BF2j2hYP OkJFMDYyth0+YKWqpE8gZf/nEYM6P9u5OT5oGsQq8kLvUuQrnNMUOq+uI3O+dOkWhobYVE MBtaz7oU8HkN92ra4x/WuptgJ4+sRsM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1696865392; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1HqVDwiKT9mbTGEItnnXsmJW+0BorQwUwbFjLDILKpM=; b=FoC9feVo75wyhxH+ko20yCQhE2NzB0aY1NCI+iAyPXNH9DLlo/DznBcljU7/bC8PLaeqys oH9uSBdq6JhXmiDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 02E5A13586; Mon, 9 Oct 2023 15:29:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id AEc+O28cJGVpMQAAMHmgww (envelope-from ); Mon, 09 Oct 2023 15:29:51 +0000 Date: Mon, 9 Oct 2023 17:23:06 +0200 From: David Sterba To: Alexander Lobakin Cc: Yury Norov , Andy Shevchenko , Rasmus Villemoes , Alexander Potapenko , Jakub Kicinski , Eric Dumazet , David Ahern , Przemek Kitszel , Simon Horman , netdev@vger.kernel.org, linux-btrfs@vger.kernel.org, dm-devel@redhat.com, ntfs3@lists.linux.dev, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/14] btrfs: rename bitmap_set_bits() -> btrfs_bitmap_set_bits() Message-ID: <20231009152306.GQ28758@twin.jikos.cz> Reply-To: dsterba@suse.cz References: <20231009151026.66145-1-aleksander.lobakin@intel.com> <20231009151026.66145-8-aleksander.lobakin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231009151026.66145-8-aleksander.lobakin@intel.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 09 Oct 2023 08:30:32 -0700 (PDT) X-Spam-Level: ** On Mon, Oct 09, 2023 at 05:10:19PM +0200, Alexander Lobakin wrote: > bitmap_set_bits() does not start with the FS' prefix and may collide > with a new generic helper one day. It operates with the FS-specific > types, so there's no change those two could do the same thing. > Just add the prefix to exclude such possible conflict. > > Reviewed-by: Przemek Kitszel > Signed-off-by: Alexander Lobakin Acked-by: David Sterba We don't have any other code pending that would potentially collide with this change so I don't care when and via which tree this gets merged. I can take it by btrfs too.