Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp1979019rdb; Mon, 9 Oct 2023 08:45:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGUVPX3Ey4GE3Is3yWpIiUbs0UUjMQOUS37E1RP3eDvGfZ5ZR680V+D7GCKnw+h7BZ3UxpV X-Received: by 2002:a05:6e02:164b:b0:34a:a4a5:3f93 with SMTP id v11-20020a056e02164b00b0034aa4a53f93mr21102577ilu.5.1696866344892; Mon, 09 Oct 2023 08:45:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696866344; cv=none; d=google.com; s=arc-20160816; b=hPZSSLSUl6RGybcEmos+azb0O1W65GwqYZcFdaX//Gd0lb1nrdCzDeaq7U2M90OtRu HemEPLKHegBGsNegMz/ysPHc9xf9kwJxInkLvCa1sAk9lJSLXeCR8xJRGYPzIQi7B35/ xDqVkMDhxw8jDaX0jPoz7/Njk18FCQkJKGkkt0GyCaQb3kIuzZKDVnhl05djegRTHrDD 9G7gckPOKf55R/KWK76FucNFgm1bxPeZtk/bMpPTLkbtDJMgI5uCuVY8TW5iqXkoAeJR HIfgi8b9QUczPX4oJMOEjrU/J1DjySYVPDTw5z3uSROJZRVdPiYBnQiykLX6tbCmVk19 Q5Pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature:dkim-signature; bh=S82M4cXdk8Z0xWHX6NNe1YRF/yKvOMhviS3adL1UiMk=; fh=tZxW8bI8ETZY61H6quWBGFFZJzdsFoROME6X3oH/E/w=; b=yKRh77G68HKE9G9wg/qlyU8FSWGq/IulWy3ejdKIdM3FgTkP2+ZeuSchLcQgrjPqKM KqYZp2E1bAsfz8zUQi+c2lDPjMkgNJ5P5i8mc7YiSWOUMRu55Q5UY7ss0JCmqVpTvW1J Nj+mQ+4aY/bUCxeiUQe//pyQBYzfxTJk1fmUEt6vWyEHQLVPv/Llzga2oGnngweaSfsv 0USdAT/MtlHwUQwPD7eUTd4U0HsEDIpwK2e+RK52lvJHLTa3vaTB1/e8PTDU/v2y1zxR MIi8bf79/8Q7srUWtGkO0qrOiscB8hN3hGHMQDouXCFgSbmF8yLiaFtwLO8wvnGvCv7b 7e5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=0gfvqNDX; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id h70-20020a636c49000000b0058988340c60si7673203pgc.481.2023.10.09.08.45.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 08:45:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=0gfvqNDX; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 8783E80BC516; Mon, 9 Oct 2023 08:45:42 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346633AbjJIPpb (ORCPT + 99 others); Mon, 9 Oct 2023 11:45:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344542AbjJIPp3 (ORCPT ); Mon, 9 Oct 2023 11:45:29 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 938179C; Mon, 9 Oct 2023 08:45:28 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 42D6F1F390; Mon, 9 Oct 2023 15:45:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1696866327; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S82M4cXdk8Z0xWHX6NNe1YRF/yKvOMhviS3adL1UiMk=; b=0gfvqNDXpK5UNQw8epyNmfhAc6nESfxfl/NBut2G+ocnDdgeZ4ydY/ObcgbYCybrQQTDRs 2HfszLMcgJfRNI/SMpJkIRDv3dJfgHFYDqvYwJrOnmpQVdW9i8VBFpzIB0V/VQ82J6NEG/ fUegQRvsEPqqCricbAZbAJVO7CogauY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1696866327; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S82M4cXdk8Z0xWHX6NNe1YRF/yKvOMhviS3adL1UiMk=; b=eDy8sKhuhDyZATH5ozLnx3F6ah3AffkV+8FP/sQ6V6bbtzURdiUWpA3F69RWzkkeVYFCAQ 7IRUvssb90feKwCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 21F6613586; Mon, 9 Oct 2023 15:45:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id pPqJBxcgJGU3OgAAMHmgww (envelope-from ); Mon, 09 Oct 2023 15:45:27 +0000 Message-ID: <4d8968e8-a103-8320-fce6-d2a78fbf05ba@suse.cz> Date: Mon, 9 Oct 2023 17:45:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 2/4] mm: make vma_merge() and split_vma() internal Content-Language: en-US To: Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Alexander Viro , Christian Brauner Cc: "=Liam R . Howlett" , linux-fsdevel@vger.kernel.org References: <6237f46d751d5dca385242a92c09169ad4d277ee.1696795837.git.lstoakes@gmail.com> From: Vlastimil Babka In-Reply-To: <6237f46d751d5dca385242a92c09169ad4d277ee.1696795837.git.lstoakes@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 09 Oct 2023 08:45:42 -0700 (PDT) On 10/8/23 22:23, Lorenzo Stoakes wrote: > Now the vma_merge()/split_vma() pattern has been abstracted, we use it "it" refers to split_vma() only so "the latter" or "split_vma()"? > entirely internally within mm/mmap.c, so make the function static. We also > no longer need vma_merge() anywhere else except mm/mremap.c, so make it > internal. > > In addition, the split_vma() nommu variant also need not be exported. > > Signed-off-by: Lorenzo Stoakes Reviewed-by: Vlastimil Babka