Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp1979353rdb; Mon, 9 Oct 2023 08:46:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEMjOJ6qqhN5tZ2xNLlxKOpwgM3v8Y7DxlfZ2qJKaHSV2dCeY4BD0QpNZtAXghHju92hvMT X-Received: by 2002:a17:902:680b:b0:1c3:ed30:ce04 with SMTP id h11-20020a170902680b00b001c3ed30ce04mr12133916plk.25.1696866380330; Mon, 09 Oct 2023 08:46:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696866380; cv=none; d=google.com; s=arc-20160816; b=n91QS1W94vC8d0VvRw6mwUBv6pdL6xWvyWt488YHCHtowpBSj21crs75cbfXRmdnNg VcAcoUyECKzf2BNVMALtZQl81JtonZGg7ybc3OGLspELsvrWF6xCKT3q2g+BU5E94VJb IHxdhDnCz/wSn8/KStDvug2/n1EZqNm01Px1E1yijVvB3OfAwVafjv/fsk2mzLIOEevS FmkBi7ANUPwhIsdLWg5FPt/TlIN48GSbaiXdCdDOpHzCNBPLVBt6x6VuIYqovB9V8VV8 XnZNMHlBNUwJR+eXljhWZn7knNDwiuEySLJ6mq+eTkZ+d1w6fHB9N94r2rrWFX3Fwg8m Rweg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=XH23ZMvqgrmaeRSjhLmgU15jQm5qtsIZN6JJfhQAze0=; fh=8TboBWl6DxAK3KEWOpWaoqVD0IFbj1CnrDf4jGdynng=; b=IjUajbijN+JuPxrsejapB4Tq0Yrgnz/g0QRsa50xBHiZIscFD1k69mbUAoeAxoy56p WYqrWlJUs73ESFPIBNLc2lwAG8U8rOissWaWOl5vi1BNEreb91SboY3QJyR62m+p48xJ u4A6dy9HrCPp2aqgsdKK/2bjdJHSuN7Xv29w5lEHHIYiXIqRkMVpkV9Bg0oklCqttu+M l/RJKwxVtPOlJ5F/6j8n7CJZR9TF1gdmgcL7O8bw43SBzRET9esZtSaOyqRAIpQIblkZ WiZWMCn6eCW1xMS986EzvmQusPjnruAhDQMjr5T2MpvcYbMA1OcKa5eOZDFv62MkuoV4 VTBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=4b1lzjes; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id i15-20020a170902c94f00b001c72dbaf7b9si8163942pla.415.2023.10.09.08.46.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 08:46:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=4b1lzjes; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id C86E4806155E; Mon, 9 Oct 2023 08:46:17 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376463AbjJIPqJ (ORCPT + 99 others); Mon, 9 Oct 2023 11:46:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346635AbjJIPqI (ORCPT ); Mon, 9 Oct 2023 11:46:08 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AFBEFA6; Mon, 9 Oct 2023 08:46:02 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1696866360; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XH23ZMvqgrmaeRSjhLmgU15jQm5qtsIZN6JJfhQAze0=; b=4b1lzjesqSd+9oWwnDHeBz1GobWMhQ5zprubpgC55W1fswn45mIN6K8cR7ev20hWHGtx1D +ealOFOeu/GBFVfEI1M5ZxWjvitHYE/f24WMBm1qxP17mLKLwF5eDUaElyFhiKxJpgE536 KTnotnqIvWfRu4BWqAYPiMyKFxg4epay4Gy3h4cpA9g3IzC1WjGNml+Bew+fMA/A8sqw7c Spa1HA3cy5E6ro3rddIQbkCV+bInrIGjotbn3NnTT5iU8MZ27kB6ifAqZCEPEdTIx4NFIB I8z8EVKmto/39MI7wFfC07CaYuBget53aD06jZnI13ltseNLRWq3jQHFjrKJSw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1696866360; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XH23ZMvqgrmaeRSjhLmgU15jQm5qtsIZN6JJfhQAze0=; b=DrR9+n7CvmlYXklFRDhT9Do4W7N6vo99qz5PEq6P3PFaAZU727vzOjm8ZbrnYyqbiVsYPt 6gytuckpAXk54dAA== To: Biju Das , Alessandro Zummo , Alexandre Belloni Cc: John Stultz , Stephen Boyd , Douglas Anderson , Geert Uytterhoeven , Biju Das , "linux-rtc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" Subject: RE: [PATCH v2] alarmtimer: Fix rebind failure In-Reply-To: References: <20230922081208.26334-1-biju.das.jz@bp.renesas.com> <87il7fq1al.ffs@tglx> Date: Mon, 09 Oct 2023 17:46:00 +0200 Message-ID: <87fs2jpznr.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 09 Oct 2023 08:46:18 -0700 (PDT) X-Spam-Level: ** On Mon, Oct 09 2023 at 15:30, Biju Das wrote: >> Subject: Re: [PATCH v2] alarmtimer: Fix rebind failure >> >> On Fri, Sep 22 2023 at 09:12, Biju Das wrote: >> > +static void alarmtimer_rtc_remove_device(struct device *dev) { >> > + struct rtc_device *rtc = to_rtc_device(dev); >> > + >> > + if (rtcdev == rtc) { >> > + module_put(rtc->owner); >> > + if (device_may_wakeup(rtc->dev.parent)) >> > + device_init_wakeup(&alarmtimer_pdev->dev, false); >> > + >> > + platform_device_unregister(alarmtimer_pdev); >> > + put_device(dev); >> > + alarmtimer_pdev = NULL; >> > + rtcdev = NULL; >> > + } >> >> That's broken versus alarmtimer_get_rtcdev() and any user of it. > > You mean we should update[1] (charger-manager driver)as it is the one > using alarmtimer_get_rtcdev()?? # git grep -c alarmtimer_get_rtcdev drivers/power/supply/charger-manager.c:1 include/linux/alarmtimer.h:2 kernel/time/alarmtimer.c:10 Thanks, tglx