Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Sender: Tejun Heo <htejun@gmail.com>
Date:   Mon, 9 Oct 2023 06:32:38 -1000
From:   Tejun Heo <tj@kernel.org>
To:     Michal =?iso-8859-1?Q?Koutn=FD?= <mkoutny@suse.com>
Cc:     cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
        Zefan Li <lizefan.x@bytedance.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Firo Yang <firo.yang@suse.com>
Subject: Re: [PATCH] cgroup: Remove duplicates in cgroup v1 tasks file
Message-ID: <ZSQrJtNAw9K4nNiG@slm.duckdns.org>
References: <20231009135811.2627-1-mkoutny@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20231009135811.2627-1-mkoutny@suse.com>
Precedence: bulk

On Mon, Oct 09, 2023 at 03:58:11PM +0200, Michal Koutn? wrote:
> One PID may appear multiple times in a preloaded pidlist.
> (Possibly due to PID recycling but we have reports of the same
> task_struct appearing with different PIDs, thus possibly involving
> transfer of PID via de_thread().)
> 
> Because v1 seq_file iterator uses PIDs as position, it leads to
> a message:
> > seq_file: buggy .next function kernfs_seq_next did not update position index
> 
> Conservative and quick fix consists of removing duplicates from `tasks`
> file (as opposed to removing pidlists altogether). It doesn't affect
> correctness (it's sufficient to show a PID once), performance impact
> would be hidden by unconditional sorting of the pidlist already in place
> (asymptotically).
> 
> Link: https://lore.kernel.org/r/20230823174804.23632-1-mkoutny@suse.com/
> Suggested-by: Firo Yang <firo.yang@suse.com>
> Signed-off-by: Michal Koutn? <mkoutny@suse.com>

Applied to cgroup/for-6.6-fixes.

Thanks.

-- 
tejun