Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp2015413rdb; Mon, 9 Oct 2023 09:46:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG/1mV1CDgt5fhqruC4YxzU2wyM4UsE+M4AAU+uKT8BRY4ZPyM2uP8z7GrURZW8XV5BRVyT X-Received: by 2002:a05:6358:e49d:b0:14c:e2d3:fb2e with SMTP id by29-20020a056358e49d00b0014ce2d3fb2emr16551134rwb.0.1696869995078; Mon, 09 Oct 2023 09:46:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696869995; cv=none; d=google.com; s=arc-20160816; b=cuqqk3RiW7GVvxWbCRAhXdeKvFAiHsC3rxib5+lepv0UPeLTrCfzJz3gkK+EjOGZbi co3w6APWi/ACIHut8qiTfBptFMdJIhPNhhfkYhzamKClO4IDVQDKh0LZBPTLXS6HBclJ fgyenqgqF6D3Li5HavcKmkXlqnOHjTt5K7LjhS+xeS6LP1XGk2xQmwT6rMPtYaCVPPXF HgdWjbqwuVNyH3QsF6wDx3gdMBZSqGX7lmcXZYuRDK3UPTd0+pNoO07nkVJtkCd/6o7z LXzPTkcqAf+M/c/SeGqHAtr3OMfsNgx7dwiOwf+8671V0rxhDKC7qNEXQ1HYVGnaCBwx dnfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=0BER5/II7QEZwLppFswh2or4Xbt/VYhxLFWZawyoWRo=; fh=y/P4oWnbxQSD4zINfwr2oELzCbXCmPkmWEJqXs1Yty4=; b=xoSLMw8DIqrN9MeH4/ufeqvdnOdNYZ5Rfhfj9my0JR+bShLeWsjCifbpwja75nfiFg Ou5Ce9Ll1HlrpJZUFGYPY/3XgCIzTb8ZDxdNGXakEI5MmXcF/PsXqEogV0WgdbcNryYJ Is/u+Dsv3U9K0tB8NrcP9rCnRR6w86YA8AyTgJx/Jv5Cdqp+IlK7BWD80lbeyYDdoOI7 gYFxxtNPoXQUyza0DH3is9X3x8ybG2Z0RkavbPk+qddAjs6bhX6YE82Mr6yO/gP9/Utn uYkk3RGcwr01U6182RePxcPo8jlLIHNwp1Q66tVpjIkFWIim+0FnlJik3LMidP1Uq6Uo uFmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=mIfiaRlM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id z19-20020a63e113000000b00565e87d8707si8385444pgh.496.2023.10.09.09.46.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 09:46:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=mIfiaRlM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 17A8F802A919; Mon, 9 Oct 2023 09:46:32 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377283AbjJIQqY (ORCPT + 99 others); Mon, 9 Oct 2023 12:46:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376970AbjJIQqW (ORCPT ); Mon, 9 Oct 2023 12:46:22 -0400 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D8A5AC for ; Mon, 9 Oct 2023 09:46:21 -0700 (PDT) Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1bf55a81eeaso31177785ad.0 for ; Mon, 09 Oct 2023 09:46:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696869981; x=1697474781; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=0BER5/II7QEZwLppFswh2or4Xbt/VYhxLFWZawyoWRo=; b=mIfiaRlME+bHI7gUp7tCK5igw0QxKTltnqcbshK6OMlElzPwAQkR3ENgoS0pc4LS0+ 9zVRWSFOAiW8E9Nd1Zmgxc0w5drycUmKQZ8GDHymX6e/C21TmfZvR2ZzvQxdpXszs79E MHhO6Vq71h/WwZTYlaLJ9HKHF9wFWmgtrCk3pJzGfFDtjLyvlZzbfvRQ2DmFgOyqlrdm 8jgTt/ubxnQGKS6R9d7w04+ufLkuFiV18UkaSaySaogZrndtiXqjPvUViU3cfHS1Yvxp rBWE/sC0NHZ8pQWSAvTNSIloeH/Isr/J5ATRgBtTd+lKwHiIA90HoxeTFEkp0p0j/fzA da9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696869981; x=1697474781; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0BER5/II7QEZwLppFswh2or4Xbt/VYhxLFWZawyoWRo=; b=sWj3/wSzSgilNvqdUO0oRwnRXLl1bgAg6L3+/Afib9GIDe8dVWSeiAVZ4kdr9m76tM 0+EWplYJ5qMYeNIeHdvKAGQwJtzBv3q7kqdnq1ynbznACkBLqLgDY4vVLuigaT6/2FnJ Cjl/VhiQrU8DMzCbGKmcwaBPNWyYU38hdsMP4axGU9BFAWLK20+UrHJtFKDG5+hmg0Z6 QL9az9bucLmAkN8Up7SvbHSNdzb1Gimfsnq2M4KVC/3zmpBDo2QKcKHxwyi9FzsFRqE8 pZ0ixjKz5cWobFow6mipc4DCuEdHY3e5UiSsZBLNIsxO8v12d+NfIC8bX1APATENDEMm c3jA== X-Gm-Message-State: AOJu0YzfNXf8uLkT2Kc+Sflt5qITav1znJmUX7vTyjjoO4Vm9bU3NwNv 2ZgGEDB3in+EwHBvEC9aEAQ= X-Received: by 2002:a17:902:ea82:b0:1c7:48ea:86ed with SMTP id x2-20020a170902ea8200b001c748ea86edmr14380214plb.62.1696869980759; Mon, 09 Oct 2023 09:46:20 -0700 (PDT) Received: from localhost ([2620:10d:c090:400::4:cced]) by smtp.gmail.com with ESMTPSA id jj15-20020a170903048f00b001b8c6890623sm9889445plb.7.2023.10.09.09.46.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 09:46:20 -0700 (PDT) Sender: Tejun Heo Date: Mon, 9 Oct 2023 06:46:18 -1000 From: Tejun Heo To: Zqiang Cc: jiangshanlai@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] workqueue: Use the kmem_cache_free() instead of kfree() to release pwq Message-ID: References: <20231007113541.8365-1-qiang.zhang1211@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231007113541.8365-1-qiang.zhang1211@gmail.com> X-Spam-Status: No, score=2.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 09 Oct 2023 09:46:32 -0700 (PDT) X-Spam-Level: ** On Sat, Oct 07, 2023 at 07:35:41PM +0800, Zqiang wrote: > The pwq objects is allocated by kmem_cache_alloc(), this commit therefore > use kmem_cache_free() instead of kfree() to release pwq objects and also > make use the correct tracepoint("trace_kmem_cache_free") to trace the > release of pwq. This isn't wrong. kfree() can be used for memory allocated with kmem_cache_alloc(). Thanks. -- tejun