Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
From:   Biju Das <biju.das.jz@bp.renesas.com>
To:     Thomas Gleixner <tglx@linutronix.de>,
        Alessandro Zummo <a.zummo@towertech.it>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>
CC:     John Stultz <jstultz@google.com>, Stephen Boyd <sboyd@kernel.org>,
        Douglas Anderson <dianders@chromium.org>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Biju Das <biju.das.au@gmail.com>,
        "linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-renesas-soc@vger.kernel.org" 
        <linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH v2] alarmtimer: Fix rebind failure
Thread-Topic: [PATCH v2] alarmtimer: Fix rebind failure
Thread-Index: AQHZ7SyA4lmrPv0tQ0OIkUBZ8XwsyrBBqzEAgAAC0jCAAAcKAIAAFRag
Date:   Mon, 9 Oct 2023 17:02:51 +0000
Message-ID: <TYCPR01MB11269C6BF3934F9AAC44F855186CEA@TYCPR01MB11269.jpnprd01.prod.outlook.com>
References: <20230922081208.26334-1-biju.das.jz@bp.renesas.com>
 <87il7fq1al.ffs@tglx>
 <TYCPR01MB112697A5D4B57101CDE27C88D86CEA@TYCPR01MB11269.jpnprd01.prod.outlook.com>
 <87fs2jpznr.ffs@tglx>
In-Reply-To: <87fs2jpznr.ffs@tglx>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MqvlUUMP7xIaJsUH52GUGiLezao9JZ5UNItBhiRX5IhZFWNpOZyOA5I+8UDG?=
 =?us-ascii?Q?buiqHq6fMOiidw8IQYrTVLWS2fx8f3nr8h7ViLvvLuT1DkuzQn2dnx26qJ/C?=
 =?us-ascii?Q?XXtrdNzcODPMs/CHjKrfnSJqMy59EDD3//yy98GaaTiF9el/WLKRFdLmMfm/?=
 =?us-ascii?Q?eU2aRaGNsiFkAX6VWLCIhsibUmH2VXLnrq1VYHKnnhkh/JWDPlO3H/nuk3js?=
 =?us-ascii?Q?eSQPHM3EtCDBnzGxcrUD/y7dn+T5eTe3yhwGYWpnJ7PLxIk1oyySyt9/h6/L?=
 =?us-ascii?Q?cShqBlYvanDetF2Z/v3VEELNfqq/MzVDH9Jt6HvVv03T0AjpVvhlcBzEls/P?=
 =?us-ascii?Q?WoD7T9CRvAT2hyA93e9yGaN0LwKYzxSsYPIml8uVPXlm/arm3LZ9nRNj769z?=
 =?us-ascii?Q?ZRymuXLZFfZtTEVDn0+cb+J37L/CHC1VCrf/IZQNT426WbTVWCJn9b40HXfM?=
 =?us-ascii?Q?OrdUTKPUpRTlhnGLWP/6fT2D83NyXMoUxxDD9lkjAFSRNFrMhEZkhF0wOcz3?=
 =?us-ascii?Q?xrpxg/p11LOy8amfhL2Ufal+J38fg4v3LIxtz7GIPi+9LamWNJScXpKZ695Z?=
 =?us-ascii?Q?pQIDfv3fSx4cvnlBWiYbMhMzbrIzmYenzUXjtUfQTIgEmGaXRrtmc5kVofya?=
 =?us-ascii?Q?kw4KWQsqy3OoWQwAoyXw2otM4pEtCFqSoOd/0WpJLh67GfuDf2+UfbbVhDyg?=
 =?us-ascii?Q?crBgm3quhuiFosvrTgjJ7gBgSfDHLm3oUaTkEebTCPeBfKylTdBr41/UJCeZ?=
 =?us-ascii?Q?5McThN8YY/Yk3JwKHdYLAFfwbOmAqkbLNPTXQq0QaDhf5N/PePy6I1HHa9C6?=
 =?us-ascii?Q?0pbW0aMj1QyJD2aoR7odYQOS9HoM4qBpRG0BU8LO5Yhx6AZ8hqbnwsMI3gjJ?=
 =?us-ascii?Q?5KegXiSJqBI9d3hAAdL6QAOzWBIbobyM6KAeMhmXmlrEuLBWUHfkgQR3Nm4n?=
 =?us-ascii?Q?RN9pu19tq0KVAQ9a15GcwQo/4RjbVz6QTtMgODvu4XBEiCb67wslwv/hrrmP?=
 =?us-ascii?Q?LwuYCY7HHs9FLi8djlfi7MjvCnpL0sVWcuGTUAgwByagr33KSbuZxSJ7VXdd?=
 =?us-ascii?Q?VRw9KqlSFuzn0Y/p1NgkR9YzHdT7yZccZZvvoHYT2zdFC/YTZMWKEM+VfWwu?=
 =?us-ascii?Q?Fg8B7NKsVF7ptvi0rkjroI0l/pXYCNa30I1Ysd0bLQGiqbPGAkfODCw7czVt?=
 =?us-ascii?Q?ufgL/GWfiXS2K1ygI9bioesY2dE/+D+bheVGyuouv7hKLFBwtNYLQDSxVdn7?=
 =?us-ascii?Q?Iopxgi7MZNiZJpZ/4t+NL+L473uCBLzSu5xocHseeFzXT98ZS0iU2U0GO9CZ?=
 =?us-ascii?Q?DV0+DZAdnqFIGgIwv5YRsCAZtQii69/YQPNaEz1gwIi1LtygIcoNF3DIZ6CB?=
 =?us-ascii?Q?x1YwOUEeWciUycb0EUY/79LyUnMbRJMiL5/H67cdsaWsO8qEpVnvfkNT3VHw?=
 =?us-ascii?Q?BbAdnYMTZocPuN5lQljwQZuQRzfpQ2qktK1yFczU2CF/WqahE7CqwvpkqgRq?=
 =?us-ascii?Q?ccexzsdGNPqNQZ1uPis9tC+UrTftzxUZDQOYHhU8ljvBT0Yc/+mfbgK/UUJ5?=
 =?us-ascii?Q?zTMWvmSUbNGubFcClWoQMgg2qDl/cZ/xnfTyMjc4YifH5Hk+8qNL+cxanqoI?=
 =?us-ascii?Q?Mw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: bp.renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB11269.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 81b9e6ef-161f-4d3e-a0ef-08dbc8e992e0
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Oct 2023 17:02:51.9741
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 70av/RxjLonwRuKIBduMGesnTaeabAyKw1HZs/fKo3D5mKrH7hdd0xwm1U2/rwHF8oBbxtYinDNaGsKKu5ylBCJKz6a1sF3FsS6LJU35koU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB11638
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 09 Oct 2023 10:03:07 -0700 (PDT)
X-Spam-Level: **

Hi Thomas Gleixner,

> Subject: RE: [PATCH v2] alarmtimer: Fix rebind failure
>=20
> On Mon, Oct 09 2023 at 15:30, Biju Das wrote:
> >> Subject: Re: [PATCH v2] alarmtimer: Fix rebind failure
> >>
> >> On Fri, Sep 22 2023 at 09:12, Biju Das wrote:
> >> > +static void alarmtimer_rtc_remove_device(struct device *dev) {
> >> > +	struct rtc_device *rtc =3D to_rtc_device(dev);
> >> > +
> >> > +	if (rtcdev =3D=3D rtc) {
> >> > +		module_put(rtc->owner);
> >> > +		if (device_may_wakeup(rtc->dev.parent))
> >> > +			device_init_wakeup(&alarmtimer_pdev->dev, false);
> >> > +
> >> > +		platform_device_unregister(alarmtimer_pdev);
> >> > +		put_device(dev);
> >> > +		alarmtimer_pdev =3D NULL;
> >> > +		rtcdev =3D NULL;
> >> > +	}
> >>
> >> That's broken versus alarmtimer_get_rtcdev() and any user of it.
> >
> > You mean we should update[1] (charger-manager driver)as it is the one
> > using alarmtimer_get_rtcdev()??
>=20
> # git grep -c alarmtimer_get_rtcdev
> drivers/power/supply/charger-manager.c:1
> include/linux/alarmtimer.h:2
> kernel/time/alarmtimer.c:10

kernel/time/alarmtimer.c has alarmtimer_get_rtcdev()check everywhere, that =
is missing in charger-manager.c. I will add
the same, is it ok?

Cheers,
Biju