Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp2035004rdb; Mon, 9 Oct 2023 10:18:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGHpmvbXFckZqDYFToheUvbcLTVamrs1WzX/UBUMrCPYmbmJ1bvvJqAq0euXjO6kVLw3JgT X-Received: by 2002:a17:90b:4b4f:b0:279:856:b036 with SMTP id mi15-20020a17090b4b4f00b002790856b036mr12875146pjb.6.1696871917888; Mon, 09 Oct 2023 10:18:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696871917; cv=none; d=google.com; s=arc-20160816; b=SyLq1htKPQ1WHJjJXnwyxqTBizUmdRXy4cWi39LMAF2Iq70KSbwFXev8UPPBJmqswc 1pq97FVqMsM4wbuxW1gwrCjFnTUYXJEdZxz2vF+ojEXibaMmmwzb7/TpDrEUePciBbjb YVseAJ7ndnVrZwtjDEs4DFRciq+Avro6lIiovG/+FSWeI7ekFQ2AgE7WfJv9nkJov5yJ StQ6bIDO6UamPYFhxESltTD+S+N378nIL1irw2NQjvro4SC4kF3LVt1xZvXsv286hWnr BquBeY0US2eAdzohOeMo8EpnzXFulVl6XYYTxQNfPAEO45pFd1g+wF6wkPxXik63JU9d ThEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=HLGHt6Q8Th/XvNk9b1wnpnqK6x+L6c4E1vcH97tDF4g=; fh=lgkGYCPCxPNEH2slCecOSpqOdth89nTumSPoqZgvCyo=; b=hL2JzH0M0WDmnymLNroCmOfR8AU2GwNyOZUVZtHG0m2ElXGW337LLdSMOr1zxkXAMK iBO4v62lg7iFlB7/5su9IjF83ybbzu4emqxOizyWqJgbyMsxC+5Yl07shbmvIaGtaHy6 8o7bXxq24D/cC7rkcaW2OZLGlsUatWmsHqBHPZUfIfiOG97g21H1dFKCj2qFzJAFq2pA +Nnzr0I/ngId+mQkd+ULrz/Iv4QeZ9exMmtWBNWTd+2ju2M8V1ASZ7pVxFgqr6j77O3f 7IVyrs6cZ52ME4SJBPjrJyh1OpGIWRGWJY8yLOV0FmXxDvc9Utctdj9nKqjW+cMPR7qy okbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="NzXv/IHv"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id v6-20020a17090a778600b00268293118efsi9490607pjk.47.2023.10.09.10.18.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 10:18:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="NzXv/IHv"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 0798980320F4; Mon, 9 Oct 2023 10:18:35 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377402AbjJIRSZ (ORCPT + 99 others); Mon, 9 Oct 2023 13:18:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376772AbjJIRSY (ORCPT ); Mon, 9 Oct 2023 13:18:24 -0400 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7912094 for ; Mon, 9 Oct 2023 10:18:22 -0700 (PDT) Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-68fb85afef4so3478815b3a.1 for ; Mon, 09 Oct 2023 10:18:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1696871902; x=1697476702; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=HLGHt6Q8Th/XvNk9b1wnpnqK6x+L6c4E1vcH97tDF4g=; b=NzXv/IHvwSfzgiJnuYb1Q5Zivv5ScCpE0Qk6BhNylLGX0diT4IKSxvuA7JwKD/2n70 Pmad4WIpcEfpuNyg3EGM0NSl5jQ/4OYGZJsoMn2e6HLAWRwIjxsxU1JVe6PCqow5z8eZ xfyPpIsK7sICJmMTiofqKXCbCgcLR6P2oSooI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696871902; x=1697476702; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HLGHt6Q8Th/XvNk9b1wnpnqK6x+L6c4E1vcH97tDF4g=; b=biaUymG8K3K06dvF7MP3GvE6YtISDp+e7chPsNLuS6+cE8m6DsgT8/+X5ik1ibDbFM jlH+EzEQntvn66qka9IDyC0EobB8o3+sg0PQikK/OhMjixaJiDJPVtwPUwmDxzre2U+j ZVakZ9XhXCDiEo4gMeDXR24VglJGWSknLBP8VaPdIKyYHlNx7fqLrYBDGkkYUOrvX3y2 8VCL0egALVb3Xa78DqvGX5Z/TXQHGvAi7j0kRZYLk3OY6tP16UoEvzHb+wDkZM0XK25t hhz7tmRrpNd21ebtHTBTATJMGs1WGZeKYecYJTJ5yAPh4R6+2+gj8BkUE4MHulb1Krmg iKNg== X-Gm-Message-State: AOJu0YzaPGu5C3Gt4czbNmwfqAM95WtSkOyjy1lQCSKlbfP3FdLuS0f9 kWAfvR0zKAcHNte8q5rXzEMrLA== X-Received: by 2002:a05:6a00:b84:b0:68f:ccea:8e14 with SMTP id g4-20020a056a000b8400b0068fccea8e14mr16264330pfj.32.1696871902030; Mon, 09 Oct 2023 10:18:22 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id z9-20020aa785c9000000b006926e3dc2besm6674235pfn.108.2023.10.09.10.18.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 10:18:21 -0700 (PDT) Date: Mon, 9 Oct 2023 10:18:19 -0700 From: Kees Cook To: Jakub Kicinski Cc: pbonzini@redhat.com, seanjc@google.com, workflows@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH] KVM: deprecate KVM_WERROR in favor of general WERROR Message-ID: <202310091018.85576DC@keescook> References: <20231006205415.3501535-1-kuba@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231006205415.3501535-1-kuba@kernel.org> X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 09 Oct 2023 10:18:35 -0700 (PDT) X-Spam-Level: ** On Fri, Oct 06, 2023 at 01:54:15PM -0700, Jakub Kicinski wrote: > Setting WERROR for random subsystems make life really hard > for subsystems which want to build-test their stuff with W=1. > WERROR for the entire kernel now exists and can be used > instead. W=1 people probably know how to deal with the global > W=1 already, tracking all per-subsystem WERRORs is too much... > > Link: https://lore.kernel.org/all/0da9874b6e9fcbaaa5edeb345d7e2a7c859fc818.1696271334.git.thomas.lendacky@amd.com/ > Signed-off-by: Jakub Kicinski Yeah, best to have just the global option. Reviewed-by: Kees Cook -- Kees Cook