Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <f9bd5402-0377-6d75-5782-8bef29759c90@intel.com>
Date:   Mon, 9 Oct 2023 10:40:32 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH v11 05/10] x86/resctrl: Unwind the errors inside
 rdt_enable_ctx()
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>, Babu Moger <babu.moger@amd.com>
CC:     <corbet@lwn.net>, <reinette.chatre@intel.com>,
        <tglx@linutronix.de>, <mingo@redhat.com>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <paulmck@kernel.org>, <akpm@linux-foundation.org>,
        <quic_neeraju@quicinc.com>, <rdunlap@infradead.org>,
        <damien.lemoal@opensource.wdc.com>, <songmuchun@bytedance.com>,
        <peterz@infradead.org>, <jpoimboe@kernel.org>,
        <pbonzini@redhat.com>, <chang.seok.bae@intel.com>,
        <pawan.kumar.gupta@linux.intel.com>, <jmattson@google.com>,
        <daniel.sneddon@linux.intel.com>, <sandipan.das@amd.com>,
        <tony.luck@intel.com>, <james.morse@arm.com>,
        <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <bagasdotme@gmail.com>, <eranian@google.com>,
        <christophe.leroy@csgroup.eu>, <jarkko@kernel.org>,
        <adrian.hunter@intel.com>, <quic_jiles@quicinc.com>,
        <peternewman@google.com>
References: <20231003235430.1231238-1-babu.moger@amd.com>
 <20231003235430.1231238-6-babu.moger@amd.com>
 <20231009172517.GRZSQ3fT05LGgpcW35@fat_crate.local>
From:   Fenghua Yu <fenghua.yu@intel.com>
In-Reply-To: <20231009172517.GRZSQ3fT05LGgpcW35@fat_crate.local>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N1pjT2NLVm5acDk2dGFjbW4zWUJrWlA5MEhLeldodkc3Y0VWS2ZibG5FUndD?=
 =?utf-8?B?UUhVV2x4NEd4TG9ETFhGb2pudWJzckhpMTBzZDczYUtNNnRXemxQYmRHNUlk?=
 =?utf-8?B?cE4xN2swZU8xZ0VaZG1MSmc1OFV5UkdBTVJOdGhBdWR1Yi9PclUwOXhjM3g4?=
 =?utf-8?B?SFVjZUthQUlFSUs3ZSt1UkZkVUhxSDNUS3RtT0I2OFhybGRHRlowTjVlTnZm?=
 =?utf-8?B?YXgzLzVkemRSbFI1bVNHV2tWVlVLR05qT1JyM0EwbnRBMVNPUXE0QUxXcmVE?=
 =?utf-8?B?QkZoZmNNYlVVZEU2czhZOGx4RlF0UGprUFduRC9xVXBFR2lNVnpCbVdJM2Vq?=
 =?utf-8?B?VHNqYkR6N3QyKzhML1JtVVlSZksvbVlkaVRkeVgwWW95Y3pYZi9zQURMTEEz?=
 =?utf-8?B?bmFmVXZ2RWJpcERFbTFZSU9tUDhFRlhzY09DOSswN3llVGJxR1J1dXpURXRD?=
 =?utf-8?B?bWh3endnVHdqTno0b3Z0Mno2K1E4T0pHNjhzbXBQM2tLbWc2STEyOG5BTkVu?=
 =?utf-8?B?MnNkVDFTMWdrZFNobHE0M1ZNaUZxVmx4TEt1eGdaTmxxa2tvYnRsSkVGR0VV?=
 =?utf-8?B?U1RYcUNQNVp3elVvUGZEL1hjTW1nUWZCMFhObTdkZytrY1FsaWlRUVo3V0JZ?=
 =?utf-8?B?YUJ6dGtjZjBOYkNjZXZ6SHlEQ1JsdDg5QS9mdWZlaEZaTi9UZ0xYZC9IM0gw?=
 =?utf-8?B?d3pLRGp5VG1UZW15UmNvY3FwSGF0RHh5SjhNSmlJZW82WVFQa3ppbm5idXM3?=
 =?utf-8?B?RU42SFZyeWZWRThzbXZVY0tvbk9YZkwvbmIyRG9maGV1NUI3YlVLOENTcGtK?=
 =?utf-8?B?Q3huREdvdEtsL3hNckl5RDlhaU1ObENZUkplb245Z2kva0MzNWVGZThqVUxp?=
 =?utf-8?B?WmR3ZzZGTmdmU2xqdUFFbGVVekJSVEw1WVdmZ3NubERZWFd6QXhpVFF6Mm9h?=
 =?utf-8?B?VlZnQlNmK0dCNUNVQUJjbWhJRXN1U2Ztck14NmtiWEticHhYdGJFdFdMRXg4?=
 =?utf-8?B?VHltNU13aEVuVzRoaFlHWWk0TFZNbmhlTkNuWFE3NlRxQ1ArNlNFeFY0aUdQ?=
 =?utf-8?B?bUlKQ0ZPdGVMVzI4aU4rZnNlVFdvSHQxdm9VM0pseHo0eDJGekxBSDFhTnYy?=
 =?utf-8?B?OS9PMnF4N1FleDV1T0FaZHZUcVRTeU15dGpPalYrMnVEUmN4elIwWXRleFFE?=
 =?utf-8?B?MlZwN1d3RWo1M0FvUWdNVjhiSzFDcHkxem16SzRGbnpPdHBhV3EwMlVOR1Fo?=
 =?utf-8?B?aXFiYldPcTJmZ0hYcm1GQ1hLbENiSytjc0YzT01QZ3BQVnA3SWxkUnQydFBy?=
 =?utf-8?B?U29mV2xiR1MrZ2F4elNvdDkvQTlhMFJmYW5NUFV6eTFpTUVIbUVwM1VTU0dR?=
 =?utf-8?B?Q1kxbTRtd3JiQ1RHdi9NV3FRZHBhUERZRzZTeXExeWtYd2lBODZTaHFEdDZi?=
 =?utf-8?B?eTZFWEppYVFtWC81U2duQ0M4NU1ORUUzRVAwcDBzbEJMcklsZzY1dUcvTkR2?=
 =?utf-8?B?eUl4cDRlWDZwSVRySE8xbndHNHIzUjZqL0xaMmJjUHdUOGJNSGxzZmM2dnRX?=
 =?utf-8?B?UlRZMm1DbDl4NG1jTml1Y0RoYmdXMm5ScWJ0OVk5NFQ1bkJwT0FMZ04zcXIw?=
 =?utf-8?B?SGJvbXQ1Q1c5MHdsczhiVHNMWlJpVHBHU1RPYUZ4V1NwdGpwVDh5UEJ6MlRk?=
 =?utf-8?B?ZkxSVElQQnFyNmREWksweTE0TzZTZ1lBeVJPNFhEcXN6WjRxUnNqY0U5bmJS?=
 =?utf-8?B?dW1YMnZuRUUwUXgybUJWejZYTmZ5UmNKc3ZodVd5cE5kUy9zSm0yNVRJTzZD?=
 =?utf-8?B?REQzdkl5aGQ4QmtPVFlIamRURkdPR3hhaWxuYmgzRldoVmlYRVZITUQwWFYw?=
 =?utf-8?B?UldRai9JNXVNbEtGNk9LMHdtNGVmemlIcUFCVmRkYTJ2QnRabzBHWmJrejUv?=
 =?utf-8?B?TmxmRHJWNERkemF3SXFQTkpETXROZUpmbFJtK0RQb0tUUmo1bzZPUjF4RWF5?=
 =?utf-8?B?bVM5d0YzSlV0M09UYjBUUFhkTVBlNmFRT3YrNTVnYXB0U0RpamxacitkU3M3?=
 =?utf-8?B?c1pHRnh0MUZueGpmOUhZVE82YXhDeUNEVWdTQ0kvdGdrUlFHa012SU5WM3Zy?=
 =?utf-8?Q?v2fkidA1Yf+sL/FWXi6sGJQ1n?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1852f688-e7ae-4c47-d202-08dbc8eed63a
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6097.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2023 17:40:32.7000
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VhSCbuiKSvP77ap/7yzDekHFfktw2zoql2ZEInXBys8abyWZuiW6mBWmDU5Jn5Aa3h55lk/fcdO0tkveyyOdMg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7686
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 09 Oct 2023 10:40:52 -0700 (PDT)

Hi, Babu,

On 10/9/23 10:25, Borislav Petkov wrote:
> On Tue, Oct 03, 2023 at 06:54:25PM -0500, Babu Moger wrote:
>> rdt_enable_ctx() enables the features provided during resctrl mount.
>>
>> Additions to rdt_enable_ctx() are required to also modify error paths
>> of rdt_enable_ctx() callers to ensure correct unwinding if errors
>> are encountered after calling rdt_enable_ctx(). This is error prone.
>>
>> Introduce rdt_disable_ctx() to refactor the error unwinding of
>> rdt_enable_ctx() to simplify future additions. This also simplifies
>> cleanup in rdt_kill_sb().
>>
>> Remove cdp_disable_all() as it is not used anymore after the refactor.
> 
> Do not talk about *what* the patch is doing in the commit message - that
> should be obvious from the diff itself. Rather, concentrate on the *why*
> it needs to be done.
> 
> Check your whole series.

When you send the next patch set, please add the change log in each 
patch after the "---" instead of in the cover patch only. So Boris and 
others clearly know what are changed in each patch.

Thanks.

-Fenghua