Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <1f571145-90ac-45be-9da1-681dc200051e@intel.com>
Date:   Mon, 9 Oct 2023 10:48:38 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v11 03/10] x86/resctrl: Rename rftype flags for
 consistency
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>, Babu Moger <babu.moger@amd.com>
CC:     <corbet@lwn.net>, <tglx@linutronix.de>, <mingo@redhat.com>,
        <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>, <christophe.leroy@csgroup.eu>,
        <jarkko@kernel.org>, <adrian.hunter@intel.com>,
        <quic_jiles@quicinc.com>, <peternewman@google.com>
References: <20231003235430.1231238-1-babu.moger@amd.com>
 <20231003235430.1231238-4-babu.moger@amd.com>
 <20231009171918.GPZSQ2Frs/qp129wsP@fat_crate.local>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231009171918.GPZSQ2Frs/qp129wsP@fat_crate.local>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OTVkeEtZVSsyVktoN0RwNzRZWklRVmFpRGp4RUFoM3VaZ3d3Z2x5b0xpVENo?=
 =?utf-8?B?ZXl3ejRnRWZ6UUNDRkhRS1EzZzlqVS9GeUlvaXhFVkZxSzVmY1dLcEVoUk4y?=
 =?utf-8?B?WHdrWXJ3V2NOUjEyQlRWTzZRTHprbzlKOWdJU2xGaXVBMVhyWTZET0FxUEJs?=
 =?utf-8?B?UEk4alJ0SGxGVVFPaGZibFJFSHRDMUdTajBtZ0VHOHdmVXd2VENhUHA1Z2Ey?=
 =?utf-8?B?WmdWM0hmdnA0cUVtYW8vaXZXRzlHU3JWSkZzMkE5VW5rZjI4UWhHY3FUbDRH?=
 =?utf-8?B?UVRWY2lTQnJtMVZFMzJuelV0ckFTY2x0bXR5c1pMOUFZQ3Bidm4zWm1vYlM3?=
 =?utf-8?B?bmswb2VodXVBUk10Y3N6cGxUYTJTWHBZUUdNdXNlMkhHVCtCb3Jpd1FycnZz?=
 =?utf-8?B?RG43WEdzbzZyUHlrc1VNVnNyYlNhTXU1ZTJHc1UwSEFGZTF6NFlUOGpnMzlt?=
 =?utf-8?B?bWFqT09WcXJzTVllZklENEFmUTIvTVh1SkpPQmhBdDR2UHM4WnJiVTZsK3VL?=
 =?utf-8?B?bDlnR09rYW50UWdBOTRuTys0UzIvc1FMVVB6eEVKWUNYSzVZdERBRWFtUmg3?=
 =?utf-8?B?ZHFHbHV6UVpDVWdwTDhJTmdDMGo4SWlBdVZ6SDd1cnpWVGJnUlZpRG1uZmFC?=
 =?utf-8?B?VXA0T0pxTE01dGo0T0xZYkY5NkhpcC81b0dyOWc5eUZYVkEyQ29td0RKSy85?=
 =?utf-8?B?NzMzWGYwRWc2ditXTTFLcjY2MzFjUysxMGRmeHhvWWtEN1N5ZExWYXQ5WGQv?=
 =?utf-8?B?dlBnMkFrZTNtN0U5M2FZSWlHS0xjNTkyVjJtalFtbHVOb290K2NNSmJyME9Q?=
 =?utf-8?B?Mkl5bFdjWmdWbi9SczNWZzVERHRKdXFpT3ZSN0RNa0dDUjdIR0dQYkVQODVl?=
 =?utf-8?B?L0xaKzFwck9TMFQ1WXNjMDE5L3BEMHFLYnlzdFNnaWJHMmVaZkNDdkVLMkFO?=
 =?utf-8?B?TzlldHBsaHJUalZIdGRSU2lkdHB4QUt1MUQ2U0N6RjhyeklYeVZrQzlESmNs?=
 =?utf-8?B?b2oxaitSSFY2RjJiUGVWVVkyQU10dzA2b3hXcXBrZFlhTU9CQzJIUEw3SDJX?=
 =?utf-8?B?djQ2ajczMXgza0IxZ1grWXVnN1c0SHJ0eXNFcXh2aDJXM2ZwK0JvdTZVMUht?=
 =?utf-8?B?cWtQakppQVJFRE5XbU1xeUM0dkZBS01zMlV0dTNiVUExS21vNUlRbmZPQTJQ?=
 =?utf-8?B?aFJkQVFBUGplaDBpYUxoYnFMaVliN3N1SDVVK1hRVDN3eUEwaFl2TytXcytT?=
 =?utf-8?B?TGRlN1RRaUEya0lGYVBKSU03Tm9qRXFNV2tDK2V0TXRmWlBsSkZkdm9tZ2h1?=
 =?utf-8?B?MVpMUndrWmE5cHFTcWZOMWlUVDR4b2x0OFRkUFk4QkhUT0oyN1d4dU42d0dh?=
 =?utf-8?B?ZlIvNFFjZEdhOW9GZ3lxMVVJeFRXSUZvNElwNFlFc0h1Y1llbnBTRUNmbXBG?=
 =?utf-8?B?d2wvMXVrb282L0NyU0ZDS3hSS2YrMUlPTXVaWDJQOXE4Nmd2enlNdEN4NzdO?=
 =?utf-8?B?SHhHODRxWk55bEhFeDU0bEgreTZPQUlrbXd1OHJjTjk1eVQrdFhzVnA2REls?=
 =?utf-8?B?RTRyQ3Y2ZEM5aGJsd2Q1QTMyTWtXdXFrbHdWSnAwT3BEMEZpbzlQU1prSVB4?=
 =?utf-8?B?dUhodFpFUVFvalhjOVd1S0IwUGdGQjlmU1JTWUZob2UrcERFc2RPUWZ3aVZk?=
 =?utf-8?B?R1ZHaVpDM3IyNzIxc3RNUDlvN2FUb2xWbzlZS2QyVGVlektteTlSYVpZaE9F?=
 =?utf-8?B?OWJTK2hIZjJ0aDltUjMza0tpUmhLWEw5dC9VWXNyOHZlRkhZRVJPVEZ3Znlx?=
 =?utf-8?B?ZHFYT0N6TkRaK3dNVDdKbE5lMm04OGRybUpqUWlXYWN6UEs3dmptM2V0QXAx?=
 =?utf-8?B?bnNNM05zdVRzOVcxaTNuRFFlS2FXUi9UNVh1RlB1L0VpTGNaQy9RQUZ2WDNx?=
 =?utf-8?B?TnhqT2RvaENhL2lJaHVDMW84cXZMWHZIRjFUWFdMdU5RRGpCbGtkSjl0N0lY?=
 =?utf-8?B?cnVrcXkwNlUzWDBXMHk4N2E1ZXc5enhrSDVNVVJlbjhTOUhsZ1FWQWpORzZR?=
 =?utf-8?B?SFJHcGxrVzNpU2l2UW9RWHJtbTZ1ODdWSWFpbHlpdEhjamc1c0g1WkdHMHQ0?=
 =?utf-8?B?VnVtSzJRclgzYlJrUmRkVXVJRGdkWVZwa3A5ZW5vbm9OWGYzZEp0UCtIWExT?=
 =?utf-8?B?Rnc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7d7b19c9-edad-45eb-5092-08dbc8eff9a9
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2023 17:48:41.6484
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dN1a7LAGCXzUSZScszLGKtd9TASv5L6AWCjGHgfbid8uCs8oTWMfOLYi/IPnTZ2lPZFcrXRbKfTSh6h74p5gi84HF4VUe+PCJGQdn6PAOTg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7709
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 09 Oct 2023 10:49:14 -0700 (PDT)
X-Spam-Level: **

Hi Boris,

On 10/9/2023 10:19 AM, Borislav Petkov wrote:
> On Tue, Oct 03, 2023 at 06:54:23PM -0500, Babu Moger wrote:
>> resctrl associates rftype flags with its files so that files can be chosen
>> based on the resource, whether it is info or base, and if it is control
>> or monitor type file. These flags use the RF_ as well as RFTYPE_ prefixes.
>>
>> Change the prefix to RFTYPE_ for all these flags to be consistent.
>>
>> Add RFTYPE_MON_BASE that will be used in a later patch. RFTYPE_MON_BASE
>> complements existing RFTYPE_CTRL_BASE and represents files
>> belonging to monitoring groups.
> 
> First of all, the concept of "later patch" has no meaning when the
> patches go into git, depending on the listing order.
> 
> Second, why isn't this define added in the patch that's using it?
> 
> A patch needs to be a logically separate, possibly self-contained
> change - remember that.

My apologies here. Babu was following my guidance on this. 

Reinette