Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Mon, 9 Oct 2023 19:20:36 +0100
From:   Lorenzo Stoakes <lstoakes@gmail.com>
To:     Vlastimil Babka <vbabka@suse.cz>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Christian Brauner <brauner@kernel.org>,
        "=Liam R . Howlett" <Liam.Howlett@oracle.com>,
        linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/4] mm: make vma_merge() and split_vma() internal
Message-ID: <3b46dabf-b9d8-46bc-8cec-3b7aa3b7a609@lucifer.local>
References: <cover.1696795837.git.lstoakes@gmail.com>
 <6237f46d751d5dca385242a92c09169ad4d277ee.1696795837.git.lstoakes@gmail.com>
 <4d8968e8-a103-8320-fce6-d2a78fbf05ba@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4d8968e8-a103-8320-fce6-d2a78fbf05ba@suse.cz>
Precedence: bulk

On Mon, Oct 09, 2023 at 05:45:26PM +0200, Vlastimil Babka wrote:
> On 10/8/23 22:23, Lorenzo Stoakes wrote:
> > Now the vma_merge()/split_vma() pattern has been abstracted, we use it
>
> "it" refers to split_vma() only so "the latter" or "split_vma()"?
>

I mean to say the pattern of attempting vma_merge(), then if that fails,
splitting as necessary. I will try to clarify the language in v2.

> > entirely internally within mm/mmap.c, so make the function static. We also
> > no longer need vma_merge() anywhere else except mm/mremap.c, so make it
> > internal.
> >
> > In addition, the split_vma() nommu variant also need not be exported.
> >
> > Signed-off-by: Lorenzo Stoakes <lstoakes@gmail.com>
>
> Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
>

Thanks!