Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp2068330rdb; Mon, 9 Oct 2023 11:21:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGmcQzcr8/bDk0AmYR1+FShXL+wh1nVwa81xNF8sdmChxMlmFl/gDwHsDKJ50Jxsblpt2kn X-Received: by 2002:a05:6358:6f06:b0:13c:eea2:d021 with SMTP id r6-20020a0563586f0600b0013ceea2d021mr15822406rwn.9.1696875713657; Mon, 09 Oct 2023 11:21:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696875713; cv=none; d=google.com; s=arc-20160816; b=R4VWFy6FQEYh68r3AnASEyapI4xo/ymybpKZHQQ5XVhFyBDMzfnd9kvd3xaK00YHvg IF/aHzms8HpyFzoeWk3M497pPvHbMGWnWjgAHhAW5uX3CqGA7LddxlhITto0caGROvpe uYDgDJ+PqNSPjeh4qDsAi0SeJrJ4Abrdpwi8KEWNpum1ZOLOuw/bkwsHinPneVsK6U0p Q5sOCfv6T1H9YF87NDKxZzm75eTEu6xLGV9iOYLqXDiZh7s35/zK4eRl8hgqBZ4wFDqq ImdxOC0Kiud+/u5yR95dLM5gghlEVVDRwzbRIJATpLSg7EaWHjOuBnRfMLEms+g2o6VT kULQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=oc0nbYwvTpqhRguEfQQTyDgA4rUKYn1mDLi3z4hzlZ8=; fh=AA4/zokb6swv8AtW32A31qX+WsrsQ7UByX60aefp6A0=; b=O9GD3LhG+xdUUKaDWN9VBYcaHU+1vyKorcY7FWwZPo1XFKsfbIVxcnzLBgpM1e1u7q 2NPXacd3N8uLVU+/9KMUX3aIPJarfE4hy+WwgnBlfcU5Ypx+GDN25UKgOLxQnuCJdFrF en3BVT8MhKD9qRqR8/6a1/sOy7XRrbiF3e2Jo+W8/mQro/G4+zLJOC8QSo5d6N2O5FlS w3jB81Pv4dxjM85fGTlSCcFHA7hiHJx3Gy6JOWnReCWIbg7C2xEeAURdozSzW8cNYh21 vu0BTxoXll+ZsUCMSp9li1Smsu1A7OBbMosWLONhq+7QAcG9s4dsly9+zKF7Yhu38jLM qEIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=AbQAaApa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id y18-20020a056a001c9200b0067ff1a1ccbcsi7529110pfw.63.2023.10.09.11.21.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 11:21:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=AbQAaApa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id BBCF1807D243; Mon, 9 Oct 2023 11:20:58 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234593AbjJISUo (ORCPT + 99 others); Mon, 9 Oct 2023 14:20:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234547AbjJISUm (ORCPT ); Mon, 9 Oct 2023 14:20:42 -0400 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C35A9C; Mon, 9 Oct 2023 11:20:39 -0700 (PDT) Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-406402933edso44999455e9.2; Mon, 09 Oct 2023 11:20:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696875638; x=1697480438; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=oc0nbYwvTpqhRguEfQQTyDgA4rUKYn1mDLi3z4hzlZ8=; b=AbQAaApaxHS+fhZNxFsksxu6iLB8TXptb0PuyO4I5glC+rCW5dpebOWtkY/He1lEcD B+P29quuOFenfPh1PUeiTiE7aTv8soc7yPiL9aEJHDwBSsRHFs/LnFVhKnilaIdR9DRu Lx9rdS/Lr5TdhWUz1XzSuSoyIZpTPeFmUUO5ms38eBJSjM/PrUG+CcgVUYjCjs9K/NuR w1IJk3BCvYQHEED5dwb1VXkf+X5UUADMS9UVTqNu5uxcLdvwXptmtFsSg62oMftiYR3p 8QXdSERbroA32fDDPJbyB7vKhD+RUEI5ouP8worKzmCQyHL0cW/3CqXaPLSPJabKH80u BJxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696875638; x=1697480438; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oc0nbYwvTpqhRguEfQQTyDgA4rUKYn1mDLi3z4hzlZ8=; b=FvxX0KdgVKH66OmWvz+UTX7z2xvPsm12vHvFxIEpN2MtUbyBxGQaDefDlPsmeJKKzM AtEVmBknHoVlgNAzpqtboO9DN3rXK87k3DracMTuvFs74P5eGWvbv3WtN/lSBN/vt+PC 7cLAktaVdnngjXJnmiFzazA8LSluc2CNgsRrIZQhi9K63fQbFqTE+hSo0EiTlYRjSGrf CQx6YpE5WJhXSENuiVSZa1IQHhwxIg234LBqZKcqFHHAAVUAPp/zFI9lVL0Px818ZLRg +H3SuqWQ7pS7ifSiFOrD/Yq4VkqNA38BRQSVnaXIJDdephHCnHvLDCQe4WRaQjpCO+/U kQ+w== X-Gm-Message-State: AOJu0YzY3Nn+pZkEoxhQfRDURfC8O9vbyvmnJ+9JdUfuqZ2GBV827C7/ crtOMY01NBp94wbVOGvhYlk= X-Received: by 2002:a5d:4c8a:0:b0:313:ecd3:7167 with SMTP id z10-20020a5d4c8a000000b00313ecd37167mr13988616wrs.42.1696875637878; Mon, 09 Oct 2023 11:20:37 -0700 (PDT) Received: from localhost ([2a00:23c5:dc8c:8701:1663:9a35:5a7b:1d76]) by smtp.gmail.com with ESMTPSA id bd5-20020a05600c1f0500b004030e8ff964sm14235674wmb.34.2023.10.09.11.20.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 11:20:37 -0700 (PDT) Date: Mon, 9 Oct 2023 19:20:36 +0100 From: Lorenzo Stoakes To: Vlastimil Babka Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Alexander Viro , Christian Brauner , "=Liam R . Howlett" , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 2/4] mm: make vma_merge() and split_vma() internal Message-ID: <3b46dabf-b9d8-46bc-8cec-3b7aa3b7a609@lucifer.local> References: <6237f46d751d5dca385242a92c09169ad4d277ee.1696795837.git.lstoakes@gmail.com> <4d8968e8-a103-8320-fce6-d2a78fbf05ba@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4d8968e8-a103-8320-fce6-d2a78fbf05ba@suse.cz> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 09 Oct 2023 11:20:59 -0700 (PDT) On Mon, Oct 09, 2023 at 05:45:26PM +0200, Vlastimil Babka wrote: > On 10/8/23 22:23, Lorenzo Stoakes wrote: > > Now the vma_merge()/split_vma() pattern has been abstracted, we use it > > "it" refers to split_vma() only so "the latter" or "split_vma()"? > I mean to say the pattern of attempting vma_merge(), then if that fails, splitting as necessary. I will try to clarify the language in v2. > > entirely internally within mm/mmap.c, so make the function static. We also > > no longer need vma_merge() anywhere else except mm/mremap.c, so make it > > internal. > > > > In addition, the split_vma() nommu variant also need not be exported. > > > > Signed-off-by: Lorenzo Stoakes > > Reviewed-by: Vlastimil Babka > Thanks!