Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Mon, 9 Oct 2023 19:21:03 +0100
From:   Lorenzo Stoakes <lstoakes@gmail.com>
To:     Vlastimil Babka <vbabka@suse.cz>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Christian Brauner <brauner@kernel.org>,
        "=Liam R . Howlett" <Liam.Howlett@oracle.com>,
        linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 3/4] mm: abstract merge for new VMAs into
 vma_merge_new_vma()
Message-ID: <ec520a80-4b4f-4eef-ab17-1ee3ebc2982e@lucifer.local>
References: <cover.1696795837.git.lstoakes@gmail.com>
 <f38b4333badbdabdb141d5ecc59518f50e5d3493.1696795837.git.lstoakes@gmail.com>
 <e0300e5a-394d-0cdf-4044-a9a67a24c9b3@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e0300e5a-394d-0cdf-4044-a9a67a24c9b3@suse.cz>
Precedence: bulk

On Mon, Oct 09, 2023 at 06:04:47PM +0200, Vlastimil Babka wrote:
> On 10/8/23 22:23, Lorenzo Stoakes wrote:
> > Only in mmap_region() and copy_vma() do we add VMAs which occupy entirely
> > new regions of virtual memory.
> >
> > We can share the logic between these invocations and make it absolutely
> > explici to reduce confusion around the rather inscrutible parameters
>
> explicit ... inscrutable
>

Ack will fix up in v2.

> > possessed by vma_merge().
> >
> > This also paves the way for a simplification of the core vma_merge()
> > implementation, as we seek to make the function entirely an implementation
> > detail.
> >
> > Note that on mmap_region(), vma fields are initialised to zero, so we can
> > simply reference these rather than explicitly specifying NULL.
>
> Right, if they were different from NULL, the code would be broken already.
>
> > Signed-off-by: Lorenzo Stoakes <lstoakes@gmail.com>
>
> Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
>

Thanks!