Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <66b7cdbf-7f47-4a2d-9f3e-dfc783b53d9f@amd.com>
Date:   Mon, 9 Oct 2023 14:24:56 -0500
User-Agent: Mozilla Thunderbird
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH v11 03/10] x86/resctrl: Rename rftype flags for
 consistency
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
Cc:     corbet@lwn.net, reinette.chatre@intel.com, tglx@linutronix.de,
        mingo@redhat.com, fenghua.yu@intel.com,
        dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
        paulmck@kernel.org, akpm@linux-foundation.org,
        quic_neeraju@quicinc.com, rdunlap@infradead.org,
        damien.lemoal@opensource.wdc.com, songmuchun@bytedance.com,
        peterz@infradead.org, jpoimboe@kernel.org, pbonzini@redhat.com,
        chang.seok.bae@intel.com, pawan.kumar.gupta@linux.intel.com,
        jmattson@google.com, daniel.sneddon@linux.intel.com,
        sandipan.das@amd.com, tony.luck@intel.com, james.morse@arm.com,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        bagasdotme@gmail.com, eranian@google.com,
        christophe.leroy@csgroup.eu, jarkko@kernel.org,
        adrian.hunter@intel.com, quic_jiles@quicinc.com,
        peternewman@google.com
References: <20231003235430.1231238-1-babu.moger@amd.com>
 <20231003235430.1231238-4-babu.moger@amd.com>
 <20231009171918.GPZSQ2Frs/qp129wsP@fat_crate.local>
From:   "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <20231009171918.GPZSQ2Frs/qp129wsP@fat_crate.local>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TDdTN0ZxK0ZhYmhsSTBIUURZaDdQR0V4RkxsbGx6ZjRWUHVwUlY3S25BN1BJ?=
 =?utf-8?B?cVR2aVVGWGt0bVQ1TmxzR2x1QlR0UUtBK2FXNG9OQnJ1QUFMTVBjZEEycTFn?=
 =?utf-8?B?WStVSzg2eHBRUWpvWkY1Y1djRXp0alpvaHJaVjY1Uk0wWUkxcHByczBkRkVG?=
 =?utf-8?B?Rm1GT3dpSWRJR1VBaFI1NVFzZnlFSlpxY2xPbVV4UXhBT1JiQW1IRHhDL1Qw?=
 =?utf-8?B?bitwaXJSTnpReER3RVRzbUdQZDAxN1BDdUNCZFVEd0hGeTVZVmJBNFpIUktR?=
 =?utf-8?B?VnBMTFkxSGgrS0VuNzhXZEF1aWtaem9BcUljdEl5T3ZXNjNscGVUamRPbmxT?=
 =?utf-8?B?Z3ZIT0RxbENUbDNJNUIzcXBWbExEaFJaNHF3ekFZV284K3hQVmw1K3VLL205?=
 =?utf-8?B?WkRjQjJmU2hDY2R4SjdDKzZTN3g3UjN5eFZTcGpHSUEraUhBdFNQTmJzaktv?=
 =?utf-8?B?OWZSRllSa3RHMUZZL1ErU2l3K3FwWjdQTlZMSXhNeVVHSHUvbHUxOXcwU2cz?=
 =?utf-8?B?MDZZVFBmY1lIMzlCUzljTTNmUDFlaTQ4MTREb3FBa2dKYkhxcHpKVGdDWUox?=
 =?utf-8?B?azJRSkt5emZoczZ5NldPUHZUTUFIL1dlNG9Na2lPY1hmejFrUlEvcUNZRlF5?=
 =?utf-8?B?WURDY2ZQNWZGWTRLd05JbzVPUDFrQTY1YjN6VEdxWitnVzlEVFdQNjlkTVdq?=
 =?utf-8?B?WUlvL3drM0d0RWQ4eGtNOUNudnUyRmJ5eWNWcUNwT2pnTFVhWVJ2d1BkNHRV?=
 =?utf-8?B?MDYwUjJPYmpXUW9KbzM4a1V4ck1kVFVUdE1WdWlMVHlZdWU4RnJORjIzNTFo?=
 =?utf-8?B?dlFsaWFDc2dIL1Z4ZEowKzdXQTVUZXZZVlY5MkR6elU1K2J3cXBrcE1tdXZx?=
 =?utf-8?B?USt3V3hyVzl0LzRYNDcvYW0xdkYvYUE0aWUrTGRGUmlWWE9QTE10eWE5NUNW?=
 =?utf-8?B?RU11ek1oTEZubGNoRys3Vk8waDhRa0YvendEak1KY0hTVjB2UzYyVlJYdVVn?=
 =?utf-8?B?dDVocW1rQnA5Y1BnOTZtdVIxWEtpb21XTTlRSnhDTCtxK0hubE5iVTlBdmtX?=
 =?utf-8?B?ODFDYkdhY1R2QnlyRUd1dkZJNzhWYlExYXF4MlhSTUQzN2EvbGJQOXhUdGRK?=
 =?utf-8?B?dWROdEhaZUdrSlRWaS8waGpQakdsUndrYVY5KzZZZmx6MGwrY2V2MHpSVEtS?=
 =?utf-8?B?a3lZZUdMeUU1bGVsb2ZPU1ZUK3JoY2pGdklxTTh3T08xYmQzK2ozNUZOUFV2?=
 =?utf-8?B?YVBLYUpqUThDaHhjOU84SmdJMys0bkRyY1NXQXhxTmRkTE1ibS85dk9TSDIv?=
 =?utf-8?B?d1pWaDVyUVR5S1VKSFAwWTY2cU01WThKS3IweUVvWlg2akVmS3g1Slljd290?=
 =?utf-8?B?bWQ5dXRGZnFOa1JOdVNhWUVTQ0s4RnFONkV3NkhkTVFnekFjZnJ1aW5xWnli?=
 =?utf-8?B?elQzdU85Yzg3aUNvR1JEb3NOdlc3b0lxZDBOZitvVVpBT3ovdVFUeHprQndZ?=
 =?utf-8?B?ZWxmaHhnNThoeHVoa0NJOENua1g4bjVsai9pNGUzU2tra01wOVdMYnlVR0xx?=
 =?utf-8?B?WlZOUDVmS1pJQlBMbzgrUDZDVG51UFhFQm5HejRSenVYbERYU1IzTmdOdDUv?=
 =?utf-8?B?ZUFQYUlLbWQ0NHJOYjNzNUd4a3RqMTYxR2dRY21SMkFRQ3I2cUdtcGVQN21v?=
 =?utf-8?B?U0VEZDczVU9neXBoL1F5ZU5LYzg5RTFJUmhBOWQ1TWtxbUxCVTRRWUw3Nlhr?=
 =?utf-8?B?MGZ5Yzd3QWJPdUJpUWJHQUNvOXJ6ZWhDUWhrbWhxRUJUOXJmb1ZHMUJaTGdL?=
 =?utf-8?B?NGdFaU80S3dmQlZpS3hKS2trYWZFSEpJUUMwQk1pOVFVRTFaK0xXSzhIcjdI?=
 =?utf-8?B?cW42dXhVMmw5VlBQZmV2UVdDYVVXaisyRFQrUGlKcUMxU0JLcnpQdU5XWmhl?=
 =?utf-8?B?Q0tQRFZlZEVYa1IwRXBkN3dERkpxR29IWWUyMWtvR2hwUEtFUGJLQWQ4bzZ4?=
 =?utf-8?B?dnFkU0xLZlJPeGE2cnBieE16SmpBS1R1RTRhL3BwRWtDY1NORGFwYS9PV3lq?=
 =?utf-8?B?MEdkRWhUN1l6OE9lNjJoSjkzMngxcVBPMzB6UG1DZ0RmeDVFc1o2dlNqZEQw?=
 =?utf-8?Q?t6bU=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ada35935-4ec8-485e-f9f3-08dbc8fd6dbb
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2023 19:24:59.7491
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kEsSIXjoYlD6r8NqP+1or5qIr5KVVnSQwHS6k7OrzsvLPxxAci9EIKRktrR1eQWH
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5807
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 09 Oct 2023 12:25:35 -0700 (PDT)
X-Spam-Level: **

Hi Boris,

On 10/9/23 12:19, Borislav Petkov wrote:
> On Tue, Oct 03, 2023 at 06:54:23PM -0500, Babu Moger wrote:
>> resctrl associates rftype flags with its files so that files can be chosen
>> based on the resource, whether it is info or base, and if it is control
>> or monitor type file. These flags use the RF_ as well as RFTYPE_ prefixes.
>>
>> Change the prefix to RFTYPE_ for all these flags to be consistent.
>>
>> Add RFTYPE_MON_BASE that will be used in a later patch. RFTYPE_MON_BASE
>> complements existing RFTYPE_CTRL_BASE and represents files
>> belonging to monitoring groups.
> 
> First of all, the concept of "later patch" has no meaning when the
> patches go into git, depending on the listing order.
> 
> Second, why isn't this define added in the patch that's using it?

ok. Will move RFTYPE_MON_BASE to patch 10 where it is used and will
changes the text accordingly.

> 
> A patch needs to be a logically separate, possibly self-contained
> change - remember that.
> 
> Thx.
> 

-- 
Thanks
Babu Moger