Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp2104842rdb; Mon, 9 Oct 2023 12:41:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF6T3Y97YjSPOSmueRHBY6bG4kBgVBkFLlEwdqV2zXB2hyGS6cK6XWY4rliaU4NTUNkha/N X-Received: by 2002:a17:902:ecc2:b0:1c7:8678:e4a4 with SMTP id a2-20020a170902ecc200b001c78678e4a4mr15736890plh.66.1696880513649; Mon, 09 Oct 2023 12:41:53 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1696880513; cv=pass; d=google.com; s=arc-20160816; b=y9lxYaZXmgGh5MCC3h3KPHkDiQzz/gab0nk0JAfIz5CONQMYxfF/UMrDVFR3iWO9xz wejwqYxspVRTAj8KGol0HyGfMQbVy38LZreQIzFMdF0I9IuTGoWS+0YOLg6c2NQ/fn3O N85dlTH3xM44hlT0YNLTx3GjzCjAoKihnegdDWXnFUEDD+tMYG2dkp8dPoMjn/jqiB5S zkTsy9EUPQlJXLDw3tCem2N4HTR2oPbA00XG8pgfCpg028iaxecCsDzLV2hsTE67AZjy Nxsp5uvEMQkUrERi9KrwvfL0hBVTV/yyzEO+xAZeJzd318MNadYdmFayZ6U5+7fZ6GoO momA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from:dkim-signature; bh=RDMMqxH85fLmcdCIBZFXzefqCnwprD99MF/4DLVFG7o=; fh=ypOpPRh/c4S3fnYAr7xgyDmKB3uZ8dOPQv8guu9eBR0=; b=iQzK25hvgHto9kSgP3llDYb4LT7Y547ZJk0FutRBk94CuMzcbYIwVmb6rmG/QcgpcV K7FGpjp9tep4+HWXJpi44udgWXbX1i8iaozwC221SpRggaidUvSjElKu2NG/nIyOEgoc zPgOk7GOiGvs8Q7DdpYhzGMmhL/2Hn77/yovogXirUbQXKPq58cyNI/k7bQplbchh3ZG 2LliLBmyih2lEYtNGyq0ttPY1xe84Flwnz6Y0yA7TczQgO82WG3k3iF5odDpR7cGYjDX CfYARxTpYfQ30b4L3f7tktsFfDZALXwV4wc5P67psIaD9oKZcGy3WmkZ+d/qaMN0uP9c 7gWQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=xkJkVuNc; arc=pass (i=1 spf=pass spfdomain=amd.com dkim=pass dkdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id kw11-20020a170902f90b00b001c5d09c7b0dsi9846604plb.458.2023.10.09.12.41.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 12:41:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=xkJkVuNc; arc=pass (i=1 spf=pass spfdomain=amd.com dkim=pass dkdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id B838B804C19E; Mon, 9 Oct 2023 12:41:49 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378443AbjJITlm (ORCPT + 99 others); Mon, 9 Oct 2023 15:41:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378445AbjJITll (ORCPT ); Mon, 9 Oct 2023 15:41:41 -0400 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2078.outbound.protection.outlook.com [40.107.243.78]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3646893; Mon, 9 Oct 2023 12:41:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eGU1GsBYsMfDNKq/cnzhpMxOZwSRQ5zSmhBza22ajCxyTKAChP//oeB8xFDL7NFde7tImnJFkIQOUxTdNCFJeCH91XYZkpNq4mpKn1mRUqQft7bcHBgvWtK32+MDigPaiV71NgIMQc7+nv1JccZHxy5KHUxn26K2GOyqRajnxGVzcm92jkLwE7gD2ogWK/zHi5OdYXr5T3CsPaXz3arghd0b5vbbZj4TIJjQLFxL/9mEpW8hqQ3wxvdv9NqpYX3yKI92eKcSIK9R7d2fE0exsPrYeV+M52m/CyWcsU5oaz2OXpV1Zn3SKK1dbMJABiQ9IWlM80R5axIHkZtE+LdUhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RDMMqxH85fLmcdCIBZFXzefqCnwprD99MF/4DLVFG7o=; b=TFSUys6d9bhrksxPluyC9MQWo646P+NtKKXWzYWtj/lGUWTF9Gyoy8ZWB9HeiHLEysMfyb6SEkLRxRwO7qAJjyVph4Z9/gAhHZBclQk+oy+RZl68ZPqdYyG/7QE8/2Ox+Pzfwx+PSgUgjpoASdb1ncsmIyNbZnAlLo/PxtkMnEVOPSnXjOtWN0sdIhA9xP8nm7PADoBcbC7kZm1a+Y7bdY6ntQhL66Cv8NwJJ6tATuP/KsJikD/S1Q+20Bf0nbvMkmlLyTSVGgufyg2lfViZjOFuXqcFn4aOJdTotCDC7U51hjRPmL0OQqpJ6YtKVVm4nXKlOzSqTeoubcTuFYYTBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RDMMqxH85fLmcdCIBZFXzefqCnwprD99MF/4DLVFG7o=; b=xkJkVuNcWYjdfBPDrD+6qfEfSXKyN/DLQK3Sc7g0PO4abovIzDKms0ozA6fihgXu9qW5j9Ng5BalqIpZELBOtxwYDgFYaX3FtWJCL7mLK2i4yWQYbltlIqa89LBwcF+YT6FJJ2o/B/L6W6TrgBVL3oq2ER1Z4RQ2o/yGzmAaKaY= Received: from MN0PR12MB5953.namprd12.prod.outlook.com (2603:10b6:208:37c::15) by MW4PR12MB5643.namprd12.prod.outlook.com (2603:10b6:303:188::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.38; Mon, 9 Oct 2023 19:41:36 +0000 Received: from MN0PR12MB5953.namprd12.prod.outlook.com ([fe80::5e1:64bc:e8da:e22f]) by MN0PR12MB5953.namprd12.prod.outlook.com ([fe80::5e1:64bc:e8da:e22f%7]) with mapi id 15.20.6863.032; Mon, 9 Oct 2023 19:41:36 +0000 From: "Pandey, Radhey Shyam" To: Jakub Kicinski CC: "davem@davemloft.net" , "edumazet@google.com" , "pabeni@redhat.com" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "conor+dt@kernel.org" , "Simek, Michal" , "linux@armlinux.org.uk" , "f.fainelli@gmail.com" , "netdev@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "git (AMD-Xilinx)" Subject: RE: [PATCH net-next v7 3/3] net: axienet: Introduce dmaengine support Thread-Topic: [PATCH net-next v7 3/3] net: axienet: Introduce dmaengine support Thread-Index: AQHZ8XmjDysNxqIG3UGZtitzZHc+JbA6JqaAgAL7GNCAADSGAIAEbQqw Date: Mon, 9 Oct 2023 19:41:35 +0000 Message-ID: References: <1695843151-1919509-1-git-send-email-radhey.shyam.pandey@amd.com> <1695843151-1919509-4-git-send-email-radhey.shyam.pandey@amd.com> <20231004135317.2b460acf@kernel.org> <20231006143230.4230fdc2@kernel.org> In-Reply-To: <20231006143230.4230fdc2@kernel.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN0PR12MB5953:EE_|MW4PR12MB5643:EE_ x-ms-office365-filtering-correlation-id: b04800bc-306e-40bb-5cb2-08dbc8ffbfa5 x-ld-processed: 3dd8961f-e488-4e60-8e11-a82d994e183d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: O/SqrOx1U046nHE/OaxT+vheymgOQ2WDDj3kP1mpRGqaddYyAn7kCk4Fl6yV9Q1OiH+npzj2vTOHyKTbebFV1X1IhU4NyoJJy6Rk93F8Cy6u4ePtDVaGsJ4vzMig1CDSVtNpI2wqoSiAGY0/q60ewZZYagXm5/sjtwhBadtopsVhaEKrf5Gcc7MxCKE6AIVAgC5TfvA18DnoUkakYkcObDNmWXM826D1Zq86ymIHDdeKDxFoJsBGwIW8u0eGJE5iECprNRC/CBvrEUR53AXOpgTSZpyJQsZ38r+ApQ7lfDLsPw/QqqSwd26KBc9e8MaDEHAE+3sG/U4NS8I01HVnKyVTQg1DB68gwjX/XUgHUdCoSabXiq8bIUjFLHkDhdOwaAqPqG0EGOFLeQhcwR9UxEoe7iPvL20iogtOjVOxdM8h8ObDJgHSGZIdoVtH7zWiXmm2e6zssFm8mzOadObGf/XX6dAnQUF875+PWk2pdTOSG6YyyNryrn9CaOOUd6ryNDX9xQas9WY42OFHg6d84xD0GmPBmwrsK98EVxATBucPxdLR6lHInWfgeWyCl/Rv6CGEyKeQ4iVD9Pc/Y18dU06Lcrtyl1tzxWr0+PbHIGcaPWf2d1/zkeCvUqaelADk x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN0PR12MB5953.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(136003)(376002)(346002)(39860400002)(366004)(230922051799003)(451199024)(64100799003)(1800799009)(186009)(83380400001)(52536014)(8936002)(8676002)(4326008)(5660300002)(6916009)(9686003)(38100700002)(53546011)(41300700001)(38070700005)(316002)(7696005)(6506007)(66446008)(76116006)(122000001)(66476007)(54906003)(64756008)(66946007)(55016003)(66556008)(71200400001)(86362001)(2906002)(478600001)(7416002)(33656002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ei6rOXaAuxspWq2/6jFA3z6c1auLiP/ANqsUJ1gSLbdENR/V9qxeBzKZXI9x?= =?us-ascii?Q?Rpxj2dT1vfOCi2lrH1o3iYAEUJn0hwav3y7CvaxsE2DHSKWHTV9ej4BT/hx4?= =?us-ascii?Q?fXPe4f+qplf0blHAl32SIt6q5UgEGtYI858kXMliw6ocTzGNrtIRDwlZNPKg?= =?us-ascii?Q?L8lYYO2gl+rGjvlMV1IB5LgYnCytJX9FjP1fUv9M4gL/vKPTw7HMa3chC0FA?= =?us-ascii?Q?Jgj+j02b9PoQlVNMRuM82TfeK7iu9SYuvgcJxWoCsAPmLmnagfW7RqrJifcN?= =?us-ascii?Q?8eSYrOid7JEKOJRPJ+U4a7tOnIY4g3jNC5KqoN1GnZKj1VfHMWiQZQ0I/n70?= =?us-ascii?Q?vsqPZo+vM7Fh5r02+us3gNt6eoDPVtQ2mbqHu+iYCc8g0aIvrCP+EJkI1Nec?= =?us-ascii?Q?cQc+6WzzJxtwhgktRwVJyB3EEBfRvrCQw71zoynSdw2JSaUF0kTKHzRvG0T5?= =?us-ascii?Q?RXb8KzByYpjuXOhJ0SKc0QvnOV0Uxneuh5BODocGCLkwofEBqxjb93Yz0lUj?= =?us-ascii?Q?Mb5g0mHdyi1kbEmEP1lErYURR93qhhKii5wBPoSRIkY1V6SZREa0YLdqNuwA?= =?us-ascii?Q?Z9EsSiESnuto3TaM28dZ+I8jEyJDyBHpojXHN74ZSRjgqcUPJfz28KhLOja9?= =?us-ascii?Q?5Ao/n7iQCYGWGVzoazuGkwrbuLW07TRD4exHMq0ifcScTG0fQMiT+hdVmBAI?= =?us-ascii?Q?i9P+CF7uisJSTDKdFCaSm28TftORTCF/8W5L0Zx+hLf2yVOIdrjsgZtfE3jH?= =?us-ascii?Q?Gj4HQdsALJ7M8CYRvY6/t4sovZU+jQSR8PF3eKHKPys1Vvx6nMZPlyT4QaWN?= =?us-ascii?Q?Ewwls3CX8A0TanThSPLR5nE8WcczzXv+mFtNkcv8iU6wgINTShwhtuDkyyRg?= =?us-ascii?Q?+QFpvAr/Lmxo+JbkDemmp6dCuToLuMik76h2q9l1ZU8HkzABRu6d+A+Fxv57?= =?us-ascii?Q?VkNdu/hXJYctC7JdSUEkMvSBpdpd9a1ZjoVp3NmXD6wXNXwqOd2gipYrFu7y?= =?us-ascii?Q?ReJ07UWxniO+qcFTe16U9ZxbXWXf3P3ToWnBsOIW2ZGbsUClwouIHF+dF6Ta?= =?us-ascii?Q?gkrRHOJJy54tvOugCM/wZdGhBfFTfMfLDIc8d+RhRI6yiWI7z43mTZojyaO1?= =?us-ascii?Q?EvHSKqfUB5bR5L2ACyKLLCgMZNszGB6EtKgHjc43Kmqc0E1rSTYAUHzEo5Dn?= =?us-ascii?Q?XUZunvPte9mFZqHv2DZYK/oKnca2aL12QvIAVM9AWPyp5VYrXcQ1AnzsccAp?= =?us-ascii?Q?PznhQfBBjSRBWiHoaq2HjH0rp05X7cPArr7vBMlWeLzk8/1K16nBlFW9MRd+?= =?us-ascii?Q?/AGVBKtTnZ5RGakTFEPgN38CZgz61EO2ewuzHIgs+J8dzJ/Ob95R1H9PgfWY?= =?us-ascii?Q?uZU4cvzYvZWUKNV4xQfdHfJRdcVRgebCYVPcWW1yzp4i6qF57WfAyoh+IT6k?= =?us-ascii?Q?iqEqwQMGxaPzssojfSb9qSSZ1FlQbkT0SvZCdBm12qs7Fca7rp+gb20gCL5e?= =?us-ascii?Q?ke1uw23B1PpLMI819pYCNpYQvXCvOjUj+jUyqorVS5VhDeNJI4H/IZyzPJB1?= =?us-ascii?Q?lFylHuid9Eh44K+Jny1mOF4qNEC1mLVbsqfF0jUnb4Jl0L0dXyibbj4PYy28?= =?us-ascii?Q?a+J1MuEtqDSsdRE901VJ03k=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB5953.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b04800bc-306e-40bb-5cb2-08dbc8ffbfa5 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Oct 2023 19:41:36.0251 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WfGwNBkDTxbQVUapvy7I6QyGwymOZiEjDvxW1rx7/c64ZMUyrgRwJai2Ra+0+Cdz X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB5643 X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 09 Oct 2023 12:41:49 -0700 (PDT) X-Spam-Level: ** > -----Original Message----- > From: Jakub Kicinski > Sent: Saturday, October 7, 2023 3:03 AM > To: Pandey, Radhey Shyam > Cc: davem@davemloft.net; edumazet@google.com; pabeni@redhat.com; > robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; > conor+dt@kernel.org; Simek, Michal ; > linux@armlinux.org.uk; f.fainelli@gmail.com; netdev@vger.kernel.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; git (AMD-Xilinx) > Subject: Re: [PATCH net-next v7 3/3] net: axienet: Introduce dmaengine > support >=20 > On Fri, 6 Oct 2023 19:04:29 +0000 Pandey, Radhey Shyam wrote: > > > > + netif_stop_queue(ndev); > > > > + if (net_ratelimit()) > > > > + netdev_warn(ndev, "TX ring unexpectedly full\n"); > > > > > > I don't see you stopping the queue when the ring gets full, am I not > > > looking into the right place? Otherwise this is sort of expected to > > > occasionally hapen > > > > We are calling stop_queue if TX ring is full. Is that what you meant? > > netif_stop_queue(ndev); >=20 > But somewhere else or just here after printing the warning? There is call to netif_stop_queue(ndev) just before this netdev_warn. I copied below for quick reference. + sg_len =3D skb_shinfo(skb)->nr_frags + 1; + if (!CIRC_SPACE(lp->tx_ring_head, lp->tx_ring_tail, TX_BD_NUM_MAX)) { + netif_stop_queue(ndev); + if (net_ratelimit()) + netdev_warn(ndev, "TX ring unexpectedly full\n"); + return NETDEV_TX_BUSY; + } However, I noticed above check doesn't account for all frags - so will=20 modify the if check to see if available space is less than sg_len. If yes, = then=20 stop the queue and return busy , else continue with xmit. >=20 > The recommended flow is to stop the queue after enqueuing a packet > successfully, if the remaining space is not enough to hold an skb with al= l frags > populated. That avoids ever returning BUSY.