Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <bdfa67bb-2553-4674-a615-e3bb2b49f133@amd.com>
Date:   Mon, 9 Oct 2023 14:50:12 -0500
User-Agent: Mozilla Thunderbird
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH v11 05/10] x86/resctrl: Unwind the errors inside
 rdt_enable_ctx()
Content-Language: en-US
To:     Fenghua Yu <fenghua.yu@intel.com>, Borislav Petkov <bp@alien8.de>
Cc:     corbet@lwn.net, reinette.chatre@intel.com, tglx@linutronix.de,
        mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org,
        hpa@zytor.com, paulmck@kernel.org, akpm@linux-foundation.org,
        quic_neeraju@quicinc.com, rdunlap@infradead.org,
        damien.lemoal@opensource.wdc.com, songmuchun@bytedance.com,
        peterz@infradead.org, jpoimboe@kernel.org, pbonzini@redhat.com,
        chang.seok.bae@intel.com, pawan.kumar.gupta@linux.intel.com,
        jmattson@google.com, daniel.sneddon@linux.intel.com,
        sandipan.das@amd.com, tony.luck@intel.com, james.morse@arm.com,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        bagasdotme@gmail.com, eranian@google.com,
        christophe.leroy@csgroup.eu, jarkko@kernel.org,
        adrian.hunter@intel.com, quic_jiles@quicinc.com,
        peternewman@google.com
References: <20231003235430.1231238-1-babu.moger@amd.com>
 <20231003235430.1231238-6-babu.moger@amd.com>
 <20231009172517.GRZSQ3fT05LGgpcW35@fat_crate.local>
 <f9bd5402-0377-6d75-5782-8bef29759c90@intel.com>
From:   "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <f9bd5402-0377-6d75-5782-8bef29759c90@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aXlKZEdDU3lMcng5V05QRmlpYmFlbUI1VEtkMFF0Zk9vcVRxUHlkSjkxV2RQ?=
 =?utf-8?B?VTYraXF4N0s4OXZLaTkxVVRHVlpsRUhLZE5ONWI0TzlLeVJiNzdMbWJpRzhr?=
 =?utf-8?B?L0U4Q2JPc25xNUxDRlQ3SFhTNzlTdERVbTIvTkZFdmtnUFBnbEZza3lTcE1G?=
 =?utf-8?B?b1RZOHVZTXRjN05jQVlPVUdaRnpCczNOd0VtRTNjNlV0NnhaaVU5SjhNL2Vv?=
 =?utf-8?B?djBidGdPYXFQNTgwK3UvR0cyajZYWlVEQXVWaGRMaW52RTNFb3pVVlRURWd4?=
 =?utf-8?B?SHFjZjl0OXQwa3pucy9NOFBrN28yN2VOdk9zMlhiTFluNnJsNFh1bGIwWkFi?=
 =?utf-8?B?aVNyS1V3d2pYOURsVWlsSDZkRjU1dUlzcmhrczJNYmUvNlMvbHg1cGhLTjEz?=
 =?utf-8?B?QjdMUXk1VG85SlNwWVFxQSthUlplQnBlbGZjd3ljZVhWVlFUZ0ZDMWQ5WVd4?=
 =?utf-8?B?VEdrZFc4eWF5enB1RzNYQ0FGVjVwMEtta2d2QlRuT0ovdlpZWjU5L24zK3VS?=
 =?utf-8?B?Snk2RHpQR0xxNEVrY01tSFMrbGVoZm95RWRGQVFpby9FYktvNHlGbWN2S2ZQ?=
 =?utf-8?B?TThwcHJKbXRPR3NNVFl1bU5qQ0RjV0piNndTWk5MZnRobVpPWkczVGxXcC9a?=
 =?utf-8?B?U1pyU2FBYmlJbm81TzNOdHNLZG9RUHNGQ2dxRmRKcGRoOEh2ZUVzbTZlREdj?=
 =?utf-8?B?Wks5Wi9VVTNzaGRvV1l0N01ZMnlYV0RqVkx2ei9KeG10K0xORTNEcUhJMlRl?=
 =?utf-8?B?ek5oOE9mbG82NG0yRHdPUWlmd1JiQnNGajloRElkZG5WeG1rNk5kWm1UKzFv?=
 =?utf-8?B?eXRveWF0NmJQZFlZaG5LMTRVTHd4QlU1R0RkelJYaXlhY0hoY1Q5MmNabklW?=
 =?utf-8?B?SHV4S0h2QW1zS1puaVE4cHlvaThoeWEwYUhkZ2dNVGpRaDlqWE1vK2NaSHlI?=
 =?utf-8?B?RDVVb1VkQ2JZOTlkUCtOTjRoWHJ5dDVBNlZuZHdESVFEc1cxaTRTeDhNYVdk?=
 =?utf-8?B?STdyQ2UxNWZaTm1zSDVhNXlJTlV5NnNmak5kdjVHYkRBNUFOd0dzZ0dyYkY2?=
 =?utf-8?B?OUtQSmFFOUFZaXp0aUxkdHdZaVBlM09jRzEyeEF3ajJYOGFQbVlOSE5hWkNa?=
 =?utf-8?B?clpvK0pRS1BMNGhzQXVTcmVkemdialpKTFAwQlpXWmdhWUZLaGtYVmFTbzFz?=
 =?utf-8?B?QjFSU3ZSYnYvNDNKSHNveVk1TWl0aCtmK1RlcDVHd2x3YktyVzFNKytqS1Bk?=
 =?utf-8?B?Nmp1d25ZYWlMTWt1TjMvSEtnOTBCVE93QXZHWldKOUVCWmExaXFFTkFqREwy?=
 =?utf-8?B?T2NuUEQvQzZHVHBQKzRPc21sVGc5OUFYZ1BNQUhzZjc4djE3ZjJCRFV2ZU9H?=
 =?utf-8?B?RlRvdThVWGxHQkNVclRybTQwY1lITURRenJLWHVmVHRCUUwvQThYSmdpbW1w?=
 =?utf-8?B?d3lZalJCM0R1ZU1wRURIZG5YV1F6dVNCMGkyY0FRUFZIMDdKaVorNzFQUFA0?=
 =?utf-8?B?L0dUcGZKZEJzSitNVDY3OERINlF4czdLNDNjbWp5UnN3YmwvdU9aY1R2Q1l4?=
 =?utf-8?B?UGdyeXR2bTZyaGVoM0Nra2N0SnNDWVlRVUpPLzBPeGZwSnl1SGNkb2ViNXhZ?=
 =?utf-8?B?ZVRLOXN0eTJsRENwQWFQT1VvWkt1L3Y0Q3d4QXNFa21DZ3MzQnhpRDJqV3ho?=
 =?utf-8?B?bXR1a2RoRkQra1k0TkpENWFrd3dFRmg3a0RQVlFOMW14UHM4ZnNtWTVJNUt5?=
 =?utf-8?B?OE9CK3AzbnlmL2t4QUU5a25VN3ppTjFTaWNvdXJqN055U3V2TUQ5SU95WldT?=
 =?utf-8?B?eXo1ckdxQzd2Q3A4MDdHb0lsZ2MxM3h6L1ZTY2tqSno2TFhEWFRKc0FBSVBZ?=
 =?utf-8?B?WWI0Y3VyRG9nSEJqUGt4Q3M2b2FncnZkVVFEYXVldC9KSUlPVGN2dGdwZ3Vt?=
 =?utf-8?B?bFZDanR2aGpULzZOdW16U3pQNkxVMFhzclRkNEM4U0hkcVhWUkV3QzNpWTgy?=
 =?utf-8?B?T282Y09kM3RwanZRNFhnYWJlcE5ZdjBwYXZHcytLTHNPUzRDaGJBQVZ6eC9Z?=
 =?utf-8?B?a25tWFUyUFVzdFZjSlRxVjA0cXUxaUNZZnduRlIzTWlnbC9mcmt6aDRuRTB5?=
 =?utf-8?Q?QxIA=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 26026062-2709-4641-3df4-08dbc900f68f
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2023 19:50:17.8154
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ivyJlc0wjh39BcJ7D7XD9OC8m2H9ND+ZgRA2DGSdHIwXGur4aOVuiWXMpDTcGflN
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8918
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 09 Oct 2023 12:50:46 -0700 (PDT)
X-Spam-Level: **

Hi Fenghua,

On 10/9/23 12:40, Fenghua Yu wrote:
> Hi, Babu,
> 
> On 10/9/23 10:25, Borislav Petkov wrote:
>> On Tue, Oct 03, 2023 at 06:54:25PM -0500, Babu Moger wrote:
>>> rdt_enable_ctx() enables the features provided during resctrl mount.
>>>
>>> Additions to rdt_enable_ctx() are required to also modify error paths
>>> of rdt_enable_ctx() callers to ensure correct unwinding if errors
>>> are encountered after calling rdt_enable_ctx(). This is error prone.
>>>
>>> Introduce rdt_disable_ctx() to refactor the error unwinding of
>>> rdt_enable_ctx() to simplify future additions. This also simplifies
>>> cleanup in rdt_kill_sb().
>>>
>>> Remove cdp_disable_all() as it is not used anymore after the refactor.
>>
>> Do not talk about *what* the patch is doing in the commit message - that
>> should be obvious from the diff itself. Rather, concentrate on the *why*
>> it needs to be done.
>>
>> Check your whole series.
> 
> When you send the next patch set, please add the change log in each patch
> after the "---" instead of in the cover patch only. So Boris and others
> clearly know what are changed in each patch.

Sure. Will do in future.
-- 
Thanks
Babu Moger