Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <3369d0f6-8da2-42f6-a579-c8219d13b0fc@amd.com>
Date:   Mon, 9 Oct 2023 14:58:57 -0500
User-Agent: Mozilla Thunderbird
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH v11 05/10] x86/resctrl: Unwind the errors inside
 rdt_enable_ctx()
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>,
        Reinette Chatre <reinette.chatre@intel.com>
Cc:     corbet@lwn.net, tglx@linutronix.de, mingo@redhat.com,
        fenghua.yu@intel.com, dave.hansen@linux.intel.com, x86@kernel.org,
        hpa@zytor.com, paulmck@kernel.org, akpm@linux-foundation.org,
        quic_neeraju@quicinc.com, rdunlap@infradead.org,
        damien.lemoal@opensource.wdc.com, songmuchun@bytedance.com,
        peterz@infradead.org, jpoimboe@kernel.org, pbonzini@redhat.com,
        chang.seok.bae@intel.com, pawan.kumar.gupta@linux.intel.com,
        jmattson@google.com, daniel.sneddon@linux.intel.com,
        sandipan.das@amd.com, tony.luck@intel.com, james.morse@arm.com,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        bagasdotme@gmail.com, eranian@google.com,
        christophe.leroy@csgroup.eu, jarkko@kernel.org,
        adrian.hunter@intel.com, quic_jiles@quicinc.com,
        peternewman@google.com
References: <20231003235430.1231238-1-babu.moger@amd.com>
 <20231003235430.1231238-6-babu.moger@amd.com>
 <20231009172517.GRZSQ3fT05LGgpcW35@fat_crate.local>
 <51277249-2351-4933-98d5-2cb74a14c7dd@intel.com>
 <20231009192340.GEZSRTPE9b9hOtu0JJ@fat_crate.local>
From:   "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <20231009192340.GEZSRTPE9b9hOtu0JJ@fat_crate.local>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Tmszd0NITW1SL1BTbzhGcHNPRm9TR1RWc2loWHZ5S1JZR1ZJbytRZTAya3JH?=
 =?utf-8?B?WFFJc0RzZkpzREdFcnN6M1lsRmJINnkxWS9kTkU5QlRTaS9FZTg0UFZZN0ZW?=
 =?utf-8?B?cVVGRENqcTNUeFZ0bWpkcERhWVpLSDd6MGl4M3VlTGQzdE5nUE05dyt1MFN4?=
 =?utf-8?B?UlI3RFM1MXFmbGo3MXc5dXN5cldacDNhbXF6WWhBclF4MlF2Q0lQd0IrVXkx?=
 =?utf-8?B?dVhVR2t5K0IvVEdHYnl0Yk8ybDVEK3RlSVRNTmZwcHczTTloNCtuZGxHTncx?=
 =?utf-8?B?ZWdWamdiSmZpaGl6bW9DZ2VLcFpmc0ZPYnd4bE02TENzV3Y1VWdNazV3SmFC?=
 =?utf-8?B?SnQyanZ3QVg5bHBSNTZEWktaMDFBSXdLTW1VbmVVRlBTSXBYcDNVWWlNQ3Fn?=
 =?utf-8?B?bW5LMkFGRTlTZityMmptcm82WFVTdlc1U2cxT01ObjVHT0pxK0F3OUdsbGZi?=
 =?utf-8?B?Y0NIbVlQa0VhQVltZEpkK2ZoVlorNVJBMWZYT1duRDZwZDBoeWFPdjFFcDB4?=
 =?utf-8?B?V08vVkNxYmV4Zm5jdm9vcTZML3ZkdjNJcjJUUldQZFFCam5NSnNDYkNxV25V?=
 =?utf-8?B?eG85VUVKZHNPRnV6Q1pUK21hTU9yM3JOc2FSTmJvcHo0eU1MNlFmc1ZHejhJ?=
 =?utf-8?B?eWo4R0FFR3dpR3BMbjlZYTBnTTloTGN0dGZHSkRKODJKUGJua0U4Zm16ZXFm?=
 =?utf-8?B?dTg0OTloZkFuVWJ3ZEJVTWVlZ3UzbmpPcjFGS29idnJ5anpwM2Y5YVo1aDFQ?=
 =?utf-8?B?dlpvYVlTRWFKTHBqVjd5Umk3U21yTHpCczVFOGdpeFVGK0tlbzBtbXpKOWkz?=
 =?utf-8?B?Rzd4dFZBMFl2djRPblR2b2xNdDB1RlNoN2VrcVU4RXN0amxoRkMvaEkrc0ll?=
 =?utf-8?B?bEw5MWRuVlJLaWdlaTZYMHhHdHo3YW5FYUllYlJWdU51TWxrbnI1a1BiZFlS?=
 =?utf-8?B?MnRRM3N0SUk3VVNsa3NXaVRwaGw3TzZSZHZLU3BzUDh5WXdrYVc1N0pxc0pX?=
 =?utf-8?B?KzBHcDVpWGNOMkM3U3AxMkpzUnFvRmhWUXEzRldSUTFHZ0M4dlpNQmI0aHhX?=
 =?utf-8?B?SmlmSkxrMGZTaExnQU1zM3NLZWdzWmJEaDFrQ3VyY0lHUGNvbnlJYjAwemxn?=
 =?utf-8?B?NmN2TnlYQ1RLa1dCZmFwRlJFclNOMFcxYVBPaUV4a0taREhwZjN6ekg2K1lL?=
 =?utf-8?B?QngrOEpCejMycW1YKzRNZitvWUVmSXJhN1VtTVlsYVpESUNuMUE2NFcrc2ds?=
 =?utf-8?B?NFhaWmM4bkZoRlFBUE1RdlFaZEpxYWhxNFlZOUdzM2w5OWptUVJSU25KUmFv?=
 =?utf-8?B?bjNmSmE1SVVUNXptbWFyY1k3QnZoaGpUUXpJMzNNS21ZZlBML1YrVG83VU9l?=
 =?utf-8?B?UCswZ3J0TnBNSktNbitleTk1aDBrK0paV1QyRDljelFqVnRsajI5K3pBNmhX?=
 =?utf-8?B?NXVYVHp1RXdsRnhRZXFaN0NldFZ5cWpmNGEyVmgwTGNoeVZzb0hkKzA3dkRY?=
 =?utf-8?B?UHVLdjloV3JhdTRaZHNVUTNQclQvMmNpQ2tXZDAvdTJSWUpjY2JWUi96c0pI?=
 =?utf-8?B?SEZlcUVudjJXc2R3NUhQcUtTRHBRcjdBN3Jtdm9lcEliMVZTMnQxY01yMnlB?=
 =?utf-8?B?aC9QQWRJRlp0OWVTRTRyaWI0NEN6azA2Q3lBdUQrdEFtWk5UdXI5ZmJjWFAv?=
 =?utf-8?B?Q3FmU29ZSWRkdzQrbmsvUWFmK2NLdXpsZmhtTXkrU0s0TGFzWklaZGhmVHpm?=
 =?utf-8?B?dVQvaXNTV3p3SWpsbGVWWGlDeHJ6dW9pY0V2c3NpcW9Xb3g2K0pRS2dqV0FO?=
 =?utf-8?B?UWlCcEJMZG10T1FvKzJEc054aThRNTNnMzl1N2M1MjF5K0xYUHBnaDNabUF4?=
 =?utf-8?B?REZrcTVzUE5ZOS9vaGFCeHhIcmJTcVVraWN0eTlPQlo4dzVOZWsyT0t3Sjdt?=
 =?utf-8?B?SGNIK3F5citjdmRtWmpBRCtOS2UvOUJoeVJIdGV1eml3S1BKVGFjdk95bkg2?=
 =?utf-8?B?UHQ3MWhiRE1vTVRyQkFoMXpKSHdzaXlST3RnaGlYNFN5dDRvdXJxeERzTXZx?=
 =?utf-8?B?bS9xaHNPZDFHY2JTa3pVUnh5dTRnWXJTY21rQ0lseTBwSW9HbG4zb3NNVk9i?=
 =?utf-8?Q?dI3Q=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bae8d280-af32-4b2b-38e5-08dbc9022eae
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2023 19:59:01.4866
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8HxhP+BYhfi9gBeaqfBit7n/WpsDgZqp16Mx8Dl3v7fAq6orNYjK1kBe23XmzMvo
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8317
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 09 Oct 2023 12:59:15 -0700 (PDT)
X-Spam-Level: **


On 10/9/23 14:23, Borislav Petkov wrote:
> On Mon, Oct 09, 2023 at 10:59:27AM -0700, Reinette Chatre wrote:
>> Is it the fourth paragraph (mentioning cdp_disable_all()) that is annoying? I
>> can see that it is redundant. Would it be more palatable if the fourth paragraph
>> is just dropped?
> 
> Yes, basically you don't want to explain what a patch does as that
> should be obvious from the diff. Rather, it should talk about why
> a change is being done. Sure, sometimes, you need to talk about the
> change in case you want to highlight certain aspects of why the code is
> being changed in the first place but explaining in text what is already
> visible in the diff is not very useful.
> 
> I always give the example about git archeology here: put enough info in
> the commit message so that any future reader of it can understand why
> the change was done. The "what" of a patch doesn't belong to that text.
> 
> I hope that makes more sense.
> 

Sure. Will drop the last paragraph in next revision.
-- 
Thanks
Babu Moger