Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <07e8d51d-6e40-44ba-8223-9f2af36a8bb1@intel.com>
Date:   Mon, 9 Oct 2023 13:10:24 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v11 05/10] x86/resctrl: Unwind the errors inside
 rdt_enable_ctx()
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
CC:     Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <fenghua.yu@intel.com>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <paulmck@kernel.org>, <akpm@linux-foundation.org>,
        <quic_neeraju@quicinc.com>, <rdunlap@infradead.org>,
        <damien.lemoal@opensource.wdc.com>, <songmuchun@bytedance.com>,
        <peterz@infradead.org>, <jpoimboe@kernel.org>,
        <pbonzini@redhat.com>, <chang.seok.bae@intel.com>,
        <pawan.kumar.gupta@linux.intel.com>, <jmattson@google.com>,
        <daniel.sneddon@linux.intel.com>, <sandipan.das@amd.com>,
        <tony.luck@intel.com>, <james.morse@arm.com>,
        <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <bagasdotme@gmail.com>, <eranian@google.com>,
        <christophe.leroy@csgroup.eu>, <jarkko@kernel.org>,
        <adrian.hunter@intel.com>, <quic_jiles@quicinc.com>,
        <peternewman@google.com>
References: <20231003235430.1231238-1-babu.moger@amd.com>
 <20231003235430.1231238-6-babu.moger@amd.com>
 <20231009172517.GRZSQ3fT05LGgpcW35@fat_crate.local>
 <51277249-2351-4933-98d5-2cb74a14c7dd@intel.com>
 <20231009192340.GEZSRTPE9b9hOtu0JJ@fat_crate.local>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231009192340.GEZSRTPE9b9hOtu0JJ@fat_crate.local>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NzRzRFAwQU1FKzZ5REJwODJyaEdlbElNdkw5SVQyUWpDazB5amw2bkNic3hz?=
 =?utf-8?B?YlNhTXlSdjl4ZjRKYXYvZmtySyttdkRlekVkM3BrOEQzVW5OQW9tVnBZak4r?=
 =?utf-8?B?M2xteFdwV1RPSlR0NkFkRVdQYXpLbGlKTThZb2p4ZmhuYXBLVjVIbnNlYStp?=
 =?utf-8?B?VDdFODMxSTNKSWZQZnloYloxM1hkSG5kOWNQRUhLN2MvUzlMaHVKb0lNTzF0?=
 =?utf-8?B?aW5wUGhwTGg4YWxCZXgzbkNNOFMvR3BWZVV6dG5ieHlCNE5KVXM4RERaVTk5?=
 =?utf-8?B?cG9nSEZmM1dJSlJLKzNNVUpsb2g4dUJ3QzRndXBxMFlLNm1iclRoTHAvV1RU?=
 =?utf-8?B?M1g2Szhrb0NrMHZ3MjZwdVRIK1RWSHN3QVVMTVgrMzBvRWd1bWtRNnp1eVJz?=
 =?utf-8?B?dVl3WGVkVDlXS1UzZnY0ZFQ2LzFvbWQvYzZIbmlwSVU1MW94ekFUNG5DaEto?=
 =?utf-8?B?ZnIxYWo0Z3RRd0JrclNoUEtKUGsyWmJaWFRtNWl4NisvbXBhTk9tVVpBWE9p?=
 =?utf-8?B?aHNlcTNUMEhNVGM2NlBJamlteHFFaWxld2ZLSFNMbGxLTiswMDhBYTVvaWZ3?=
 =?utf-8?B?dEVUNkhRc1hHN1RZbTVxV1ZUWDVMQUVIK01BYUtqU3Z6SGx3VEZnSDQ3Y0Vt?=
 =?utf-8?B?NFdQaEIzaHNmK0xKcW1sV3VYNDhlZThuR1VSbEYxRkx6Nm40MDdtWG5ybGxV?=
 =?utf-8?B?U3JJWEF2V3NxVXJzYzUyTjNvQktyd0pvYnpOM09iNUtONnlOWnFqVldEeUor?=
 =?utf-8?B?N2xjWFZxSkhmVEVCT2c3ZWc1dGg2VmhBZ2dQYVB2WlNBZVE0aWgvRzM5eVBE?=
 =?utf-8?B?a0lJY1kzMjBnTldhYml3Slhoa0k5QkJQSldGZkFKNlRWTjJ3THp4SU1PeC8y?=
 =?utf-8?B?U2dzaDVoRUVZdWZRQVRoZG9yb3hNNTRPT3VCOHFzWWZpdXQrSE5mQytSTWlW?=
 =?utf-8?B?K2N4TDRhN3NYT3R0VHgwUUk5MWJpejNGVTI4cTBST0dSZ1NCbFg0eENRTlN5?=
 =?utf-8?B?blJBeEhZdUlMVHd0Smpid2o1OE1JOTUvVmlHdGhITkZPaG5KV1R3b0g4eS9q?=
 =?utf-8?B?LzA2VlJGYkZ1blJjNHFIM0RMWGJKTVVsWjRkUFZNaE5WalNpb3dRSlA4eTZZ?=
 =?utf-8?B?V3RHVEFxTUVHWGt3ckhta05qR0RyclJ2QWxRcnJoRHRpdUx4dVVwMGE1L1Rp?=
 =?utf-8?B?U3VKeURVMEd4c2pYZ2RtUFVtL2lrOW5McUVteFljR3FKSmttb24wZWpFcDlE?=
 =?utf-8?B?Z2dUamJUcVhrdDdUN0xBc2FpZzVZTGVBb0hyU0pEK2xUT1R0V0hxcHQ2a1lq?=
 =?utf-8?B?dFBhOUtpNnBBQ0tENjlHUGdHMm1hZVBYL2xpR1dhT0VqWS9WcnlQWUJvazRy?=
 =?utf-8?B?a3NKd1ZwYnFuMVJ5UXF6ZStkS3JTbmpRRHhaQ0EvUWxNL3h4TzhySXA5ekx0?=
 =?utf-8?B?K29xeklTK2lkVWg5NmUxV05pNVdrY2dPNW5VK1ZGYWZlSDF2OG15WGhkWEFM?=
 =?utf-8?B?MUdSNXdNRjNQSFRaRzQzTTVNTnh3OVdUeXZIaFNDd1lBYVhJUDBPU05MTkUv?=
 =?utf-8?B?SVRGMm5QbzBscnB4UUhFMU5HcW1CeEZWZHlVSkExV1gwOXRnU2t2YmZ1eEdq?=
 =?utf-8?B?MTZXRUEzNm02bXptOHp6VlNhT2Nyd3BVb2VOZ25ITmxMcGVSTzBUbTZmbm80?=
 =?utf-8?B?ZjgwTjNoaGIxVmlreGNwMGpVR3lhRHVnUXdPNzBZSVpFZ3hQSGlPZkh1SHli?=
 =?utf-8?B?WDNrY0dPNUpFNW1kU1lKZnF0SW5pSkxvcUJZTkxaRVM1bVdXSGhNS0phSTBn?=
 =?utf-8?B?aVRmMCs0elVVc25VN2E4c2NxdXdhWjc3dmVtemxjTGQzZTVpUDlLcVFLaEZa?=
 =?utf-8?B?VG5tb1hIdkRRMElZbmNaeDNTbjI0ZzVjTGNrRXJaQmRRYllHZzVhV0x5bDFW?=
 =?utf-8?B?YUgwZWppUTZsb0ZHSHBSSUppVDg4dXlmVjYxVWNVY0wwVHNaeWxtWmp2dWNu?=
 =?utf-8?B?OFFabXAyT3ZxVmVQb0xPd0IzMWkzTUhDWTBvQ2dhSytNT1EyMGMyVDJ4YzJh?=
 =?utf-8?B?RlhibHR5MlVmcWhCVlR4VWd0N0FtV0JGckh5Nk9XRlRnQks4Q2VTZ2ozZm1F?=
 =?utf-8?B?Yzh3WUNFOEhtVVZreDlGVlhuQVplVlhVa2dHcGEwbE1KcWJ2bnVKQU9yQjYr?=
 =?utf-8?B?dkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 864a43ac-355c-4d5f-b350-08dbc903c8b0
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2023 20:10:29.5691
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4VH1wMvYvBFaJGA0VpLetXvOmgfZdpWqN2K1ktWOLxb/199jABbkAb9KxR3pQg4xYYuNQHaXY9/U9l24h7XXRyQWajZpx92Vy1EEORWSVQE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5061
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 09 Oct 2023 13:11:17 -0700 (PDT)

Hi Boris,

On 10/9/2023 12:23 PM, Borislav Petkov wrote:
> On Mon, Oct 09, 2023 at 10:59:27AM -0700, Reinette Chatre wrote:
>> Is it the fourth paragraph (mentioning cdp_disable_all()) that is annoying? I
>> can see that it is redundant. Would it be more palatable if the fourth paragraph
>> is just dropped?
> 
> Yes, basically you don't want to explain what a patch does as that
> should be obvious from the diff. Rather, it should talk about why
> a change is being done. Sure, sometimes, you need to talk about the
> change in case you want to highlight certain aspects of why the code is
> being changed in the first place but explaining in text what is already
> visible in the diff is not very useful.
> 
> I always give the example about git archeology here: put enough info in
> the commit message so that any future reader of it can understand why
> the change was done. The "what" of a patch doesn't belong to that text.
> 
> I hope that makes more sense.
> 

This is clear. Thank you very much. (I am still working on getting it right
in practice though.)

Reinette