Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp2137373rdb; Mon, 9 Oct 2023 14:02:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHwdy1gOqD5D1nhjUBNtFW/P6gMGMjtvE0BETyb3pUHC/07mxwAxwOuW/XGZhXnWZ91hQhi X-Received: by 2002:a05:6a20:7d9d:b0:15d:4cf1:212e with SMTP id v29-20020a056a207d9d00b0015d4cf1212emr18501817pzj.4.1696885379013; Mon, 09 Oct 2023 14:02:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696885378; cv=none; d=google.com; s=arc-20160816; b=uShbvkY8KucxvE2GA8DsYUY7rHhTc/dl58+P/Hsk6uLZcwYQ0qjc8BQAuVVQm+03oH xqflj/1FvFZMVbLeZSJE4NxYynJcZ50YYSJJiM2k5pddVotMCOmHKRxLjpBG4xAdEidF J1SjkKG35s+tL7UrBfNNncHh2/Ez/1t5K5jnyioGF4/4HBZCBN+PhUWhQg+gnekqW1uF YnbXxiJPpxZvZJRp8fKwnJZw1cY/wLWGc4ARLzq2Hg+D0KZ8XEQ+up0gWOfYgeZpvFP/ U8aY7joE1lWJszhGBr3FqwlIdJy7KQpsbEwc0+NJ32FRiOQH47ZQL2QXJe0U6FIIz1fz OZXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=SJz0h0Tx8tbmQIBwQkViScvt69REAVK+f5XbSP6AYKE=; fh=uNCvdM9CNBgMs0AVqQ/LvmmZgkIaH/fVbYy+/UNOn6U=; b=BYxz0Q7iwV7aWNxMSqj8H//KTebJkVQDKUl7F6cCZ7GYzVn3Cl58IyoQ++qNmfNBcJ OpHuoGK2Zu5aU1hZSIs62oJX1HPmr1w0ge212ZWuWNofjwPs8pXq9RkpyNt7yihw1HaJ hVafehxicbJiOfM9U/L134WznqfIXxIm+m5fDGSM6Diwi0mfBZhYVNngh8xK5F/pi3pZ lCjxQQyNt662DTd9auGRI/brTMQtgA6uO79zRzhwaAXFQ0cr/SFG1fLcXzZnDXt5Bos5 xURsDDPIDSA2wwRiunporC5eJVeStP+4k5mAKgVZ1GLB8qBoEfXm47w8foTpd9ZGcm2R C9ug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zUDlbyAE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id j63-20020a638042000000b005655e87c8aasi10215686pgd.192.2023.10.09.14.02.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 14:02:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zUDlbyAE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id E4B83804DDBF; Mon, 9 Oct 2023 14:02:57 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378137AbjJIVCx (ORCPT + 99 others); Mon, 9 Oct 2023 17:02:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377082AbjJIVCw (ORCPT ); Mon, 9 Oct 2023 17:02:52 -0400 Received: from mail-yw1-x1130.google.com (mail-yw1-x1130.google.com [IPv6:2607:f8b0:4864:20::1130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53D83BA for ; Mon, 9 Oct 2023 14:02:51 -0700 (PDT) Received: by mail-yw1-x1130.google.com with SMTP id 00721157ae682-59f6492b415so43023057b3.0 for ; Mon, 09 Oct 2023 14:02:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1696885370; x=1697490170; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=SJz0h0Tx8tbmQIBwQkViScvt69REAVK+f5XbSP6AYKE=; b=zUDlbyAE84bS8JysuwtlFOlOCAIWHq5vzlBdmzHuLZHTu9Su55E3ZOHSlochmwe4ku jUA+nBDgJjp5jJot7wg1c5nQdLExC35cCoWHvQS/AE9DqudRhIwlBxbNaDP5yy6GuK3k gn6JHPIjOS8no3KV+MCnjIamgwIABXgze4vo00hH2wRYKc+gaKukjamaSsq/QjUqbEyZ N98niBdGNGk90sjPdMYWvgAODLTESYfa37pxPF+38K9T83mGNoV0fAaW+jeUhbXOC4zZ cNg01NNqtizcd40c26dWJt3yPK7VEl8abjTF9eOtd41mV5IdgAK+YdqSeZKYwdgT38Nm Quzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696885370; x=1697490170; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SJz0h0Tx8tbmQIBwQkViScvt69REAVK+f5XbSP6AYKE=; b=DBFh06CkkttP/46HkNIrWYX3njNpM73vG+munAnlE34rIG6g3DU/6oDArelzGZGRjm vPITUVlsmlM8LWOJoQSmv75/bVTxkmfTlpLxkrDTy38FBnsnknP2x7ACrqCp6lDXh7wq FSUQnZS0j3DPt9ldqve/dSpTsHrh3VDHMT2Sk2iur7FWTALvE4jCvmRpvE1yj3KykloF Rvy+ZtbE8EoWf6AxOfqgpEMCmZYzFikKhzMn+X/Fg0C3BjSV+b06JJsVPna48FO0oxpD BLohhE5GJ9B5Ku8u6dj6SbA86NIB66O+p/IzXmeIjMTxKcTZx1hHWgq77ywKHLhcBRY1 TTKA== X-Gm-Message-State: AOJu0YzjomlKi5CtWWObEyPD4LyRpR6eD8yr00A465slvxqfeG+4mWBf 783ilh/hLOSi0VAS9+7NdX3qsA0tmlapivKf7JWFcQ== X-Received: by 2002:a81:49d0:0:b0:56c:f0c7:7d72 with SMTP id w199-20020a8149d0000000b0056cf0c77d72mr10143379ywa.4.1696885370504; Mon, 09 Oct 2023 14:02:50 -0700 (PDT) MIME-Version: 1.0 References: <20231007060639.725350-1-yangcong5@huaqin.corp-partner.google.com> In-Reply-To: From: Linus Walleij Date: Mon, 9 Oct 2023 23:02:39 +0200 Message-ID: Subject: Re: [v1 0/2] Break out as separate driver from boe-tv101wum-nl6 panel driver To: Doug Anderson Cc: Cong Yang , sam@ravnborg.org, neil.armstrong@linaro.org, daniel@ffwll.ch, hsinyi@google.com, swboyd@chromium.org, airlied@gmail.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 09 Oct 2023 14:02:58 -0700 (PDT) On Mon, Oct 9, 2023 at 10:53=E2=80=AFPM Doug Anderson = wrote: > Also: just as a heads up, Hsin-Yi measured the impact of removing the > "command table" for init and replacing it with a whole pile of direct > function calls. She found that it added over 100K to the driver (!!!). > I believe it went from a 45K driver to a 152K driver. Something to > keep in mind. ;-) Sounds like Aarch64 code. I would love a comparison of the same driver compiled to ARMv7t thumb code. Just for the academic interest. Because I have heard about people running ARM32 kernels on Aarch64 hardware for this exact reason: so they can have thumb, which is compact. OK OK we definitely need command sequence tables in the core, what we have now is each driver rolling its own which is looking bad. Yours, Linus Walleij