Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <0343c1d5-8706-4cf8-a17e-25ab27f654d8@linaro.org>
Date:   Mon, 9 Oct 2023 23:09:55 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v6 2/8] hugetlb: restructure pool allocations
Content-Language: en-US
To:     Mike Kravetz <mike.kravetz@oracle.com>
Cc:     Anshuman Khandual <anshuman.khandual@arm.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Xiongchun Duan <duanxiongchun@bytedance.com>,
        Barry Song <21cnbao@gmail.com>,
        David Rientjes <rientjes@google.com>,
        Miaohe Lin <linmiaohe@huawei.com>,
        Matthew Wilcox <willy@infradead.org>, linux-mm@kvack.org,
        Naoya Horiguchi <naoya.horiguchi@linux.dev>,
        Joao Martins <joao.m.martins@oracle.com>,
        David Hildenbrand <david@redhat.com>,
        Michal Hocko <mhocko@suse.com>,
        Oscar Salvador <osalvador@suse.de>,
        linux-kernel@vger.kernel.org
References: <20230925234837.86786-3-mike.kravetz@oracle.com>
 <ddc10c41-515f-48c9-966d-4ae7756d208c@kernel.org>
 <20230929205731.GA10357@monkey>
 <ba5a528d-7e85-77a2-5096-5a143a3b1606@linaro.org>
 <20231006030836.GC86415@monkey>
 <5d14b681-a2c9-4210-a0c1-bf38708b7998@linaro.org>
 <20231006223512.GC3861@monkey> <20231009032926.GA3376@monkey>
 <070bd916-d4d6-41c2-9f51-af35e80c96b9@linaro.org>
 <20231009150401.GA3846@monkey> <20231009151513.GB3846@monkey>
From:   Konrad Dybcio <konrad.dybcio@linaro.org>
In-Reply-To: <20231009151513.GB3846@monkey>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 10/9/23 17:15, Mike Kravetz wrote:
> On 10/09/23 08:04, Mike Kravetz wrote:
>> On 10/09/23 12:11, Konrad Dybcio wrote:
>>> On 9.10.2023 05:29, Mike Kravetz wrote:
>>>> On 10/06/23 15:35, Mike Kravetz wrote:
>>>>> On 10/06/23 23:39, Konrad Dybcio wrote:
>>>>>> On 6.10.2023 05:08, Mike Kravetz wrote:
>>>>>>> On 10/02/23 11:57, Konrad Dybcio wrote:
>>>>>>>> On 9/29/23 22:57, Mike Kravetz wrote:
>>>>>>>>> On 09/27/23 13:26, Konrad Dybcio wrote:
>>>>>>>>>> On 26.09.2023 01:48, Mike Kravetz wrote:
>>>
>>> I managed to get a boot log:
>>>
>>> https://pastebin.com/GwurpCw9
>>>
>>> This is using arch/arm64/boot/dts/qcom/sm8550-mtp.dts for reference
>>>
>>
>> Early on in boot log before the panic, I see this in the log:
>>
>> [    0.000000] efi: UEFI not found.
>> [    0.000000] [Firmware Bug]: Kernel image misaligned at boot, please fix your bootloader!
>>
>> Isn't that misalignment pretty serious?  Or, is is possible to run with that?
>>
>> There are no hugetlb pages allocated at boot time:
>>
>> [    0.000000] Kernel command line: PMOS_NO_OUTPUT_REDIRECT console=ttyMSM0 earlycon clk_ignore_unused pd_ignore_unused androidboot.bootdevice=1d84000.ufshc androidboot.fstab_suffix=default androidboot.boot_devices=soc/1d84000.ufshc androidboot.serialno=ab855d8d androidboot.baseband=msm
>>
>> So, the routine where we are panic'ing (gather_bootmem_prealloc) should be a
>> noop.  The first thing it does is:
>> list_for_each_entry(m, &huge_boot_pages, list) {
>> ...
>> }
>>
>> However, huge_boot_pages should be empty as initialized here:
>> __initdata LIST_HEAD(huge_boot_pages);
>>
>> At the end of the routine, we call prep_and_add_bootmem_folios to
>> process the local list created withing that above loop:
>>
>> LIST_HEAD(folio_list);
>>
>> This should also be empty and a noop.
>>
>> Is it possible that the misaligned kernel image could make these lists
>> appear as non-empty?
> 
> Actually, just saw this:
> 
> https://lore.kernel.org/linux-mm/20231009145605.2150897-1-usama.arif@bytedance.com/
> 
> Will take a look, although as mentioned above prep_and_add_bootmem_folios on
> an empty list should be a noop.
I'll try it out atop the series tomorrow or so.

Konrad