Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp2145402rdb; Mon, 9 Oct 2023 14:21:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEL4r7jgKU2IGrTcYZm8CfhiaR0r0pHGOSh5DsJk1thExqozfyzuCkQ0oqKd9RMjKxCJM4v X-Received: by 2002:a17:90b:3109:b0:26b:36a4:feeb with SMTP id gc9-20020a17090b310900b0026b36a4feebmr18063388pjb.8.1696886511607; Mon, 09 Oct 2023 14:21:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696886511; cv=none; d=google.com; s=arc-20160816; b=R2LtAl+cTooGoEbtMy87QhywzOo6iE1NFXoHLhcEU3seLvEjCs7nREPkcAqabZbQDC iFh5uKsyjKYg6W+7OosG8Tsp/3UcoUYaIY3dUXkp6GY6VVo3kz0pnmV87zB9AVYJBVrF 0TvelA+shA3+A7lGvQRPuWcr5fqonC0H0+drRNO6De+xJPzD1kIElGXc8GPr6lecGCep +KVknzpo//p7e5aFvpQsUTQLxT1lvxZ9zNg5fdHt9IbWoanEYy4GhNCfubWqR/VOti7F rA4gPUV9yxiVVro6PPshQierqLUURpVtSHOToNEG1d6JHxvAAID475KxUGVFe0FBWyGp PAHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=6GIvl5PoWrAVOSl1skxX2k81lXpuJ+wOLCzKYVASjsU=; fh=egbD3fZEoqguwapaE+RZ40Fo6w4+zAjMn/QBe/dk9L8=; b=A6Bs2XoogZIcRl18AUYoXEEkAbHY5v+YyD2OxykkIZAYry0T131tUKlARGgxA1c4ct 3vFxFxiFDHnYXzLgKUgBiGMrGQgqCzCWF9YojAfVAcME6LJNpNEBuhRxzML1zwezFoca ypFlFPaw+LOZ8/J7Hbl/c90zpxS+H9gVeAVrdk/jL/KRRw7ash+Bp8esJ1m66CBY6G2D L9ryo5PkGRUopMCtWmgARhQuhtgw/P3uan5bn7OdLNyWfDhwz5m+eqrvUKrP3jiTzoy6 1U5ky56XbalUd+g5H+fOllSCcMSqPNUMOhHi1g3WAOyeFtkA3d9pIrpccdRRRwLGa/wU c0Zw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qCk3Bgdc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id q2-20020a656a82000000b00585a5e9a965si10628075pgu.161.2023.10.09.14.21.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 14:21:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qCk3Bgdc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 381918098492; Mon, 9 Oct 2023 14:21:49 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378797AbjJIVVf (ORCPT + 99 others); Mon, 9 Oct 2023 17:21:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234638AbjJIVU4 (ORCPT ); Mon, 9 Oct 2023 17:20:56 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CEBF132 for ; Mon, 9 Oct 2023 14:20:25 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPS id CFF51C433C8; Mon, 9 Oct 2023 21:20:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696886424; bh=sKVXctHEh62JJk3vAH4XnrG9P6djuHmpEHt96khoJ9o=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=qCk3BgdcSQI+q6NsahWBwtVfYMV1x4ZCHzyFTKTZNBk7oXEg3KPKBk47NTYfoVs2J /Y5L1GmR4WOLuBiKPHnAk0hmGaFNSpS4HgalKedJ2VI3AncH5BLzqZ22JrX0mgB1HV 1HmSmATn0bTgvYkf2e81aHzRAtZJBDxmH4f592OQRSHStclvgEQhz8ohqWHHxA6bhy +Qj9L12V52GVgSSgjBjcwIqZY3/SQMFurktusMkw1bIMHHbBR8CETYth+VvTi7ABNk Rcljl6DBarIwbO934qxp6raP3FDCzO2qeqjPOVdd50vQ7YpSuqrLTS73fhDhkFo9BR Y1TY7BLVjBjNw== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id A4D58E11F47; Mon, 9 Oct 2023 21:20:24 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH bpf-next 1/2] bpf: Fix verifier log for async callback return values From: patchwork-bot+netdevbpf@kernel.org Message-Id: <169688642465.32608.1593187002988701901.git-patchwork-notify@kernel.org> Date: Mon, 09 Oct 2023 21:20:24 +0000 References: <20231009161414.235829-1-void@manifault.com> In-Reply-To: <20231009161414.235829-1-void@manifault.com> To: David Vernet Cc: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, yonghong.song@linux.dev, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, jolsa@kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com X-Spam-Status: No, score=2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 09 Oct 2023 14:21:49 -0700 (PDT) X-Spam-Level: ** Hello: This series was applied to bpf/bpf.git (master) by Daniel Borkmann : On Mon, 9 Oct 2023 11:14:13 -0500 you wrote: > The verifier, as part of check_return_code(), verifies that async > callbacks such as from e.g. timers, will return 0. It does this by > correctly checking that R0->var_off is in tnum_const(0), which > effectively checks that it's in a range of 0. If this condition fails, > however, it prints an error message which says that the value should > have been in (0x0; 0x1). This results in possibly confusing output such > as the following in which an async callback returns 1: > > [...] Here is the summary with links: - [bpf-next,1/2] bpf: Fix verifier log for async callback return values https://git.kernel.org/bpf/bpf/c/829955981c55 - [bpf-next,2/2] bpf/selftests: Add testcase for async callback return value failure https://git.kernel.org/bpf/bpf/c/57ddeb86b311 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html