Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Message-ID: <d11a47c9-c422-47d8-9049-2743314a9924@kernel.org>
Date:   Tue, 10 Oct 2023 00:45:32 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] debugfs: Fix __rcu type comparison warning
Content-Language: en-US
To:     Mike Tipton <quic_mdtipton@quicinc.com>, gregkh@linuxfoundation.org
Cc:     rafael@kernel.org, linux-kernel@vger.kernel.org
References: <20230922134512.5126-1-quic_mdtipton@quicinc.com>
From:   Georgi Djakov <djakov@kernel.org>
In-Reply-To: <20230922134512.5126-1-quic_mdtipton@quicinc.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 22.09.23 16:45, Mike Tipton wrote:
> Sparse reports the following:
> 
> fs/debugfs/file.c:942:9: sparse: sparse: incompatible types in comparison expression (different address spaces):
> fs/debugfs/file.c:942:9: sparse:    char [noderef] __rcu *
> fs/debugfs/file.c:942:9: sparse:    char *
> 
> rcu_assign_pointer() expects that it's assigning to pointers annotated
> with __rcu. We can't annotate the generic struct file::private_data, so
> cast it instead.
> 
> Fixes: 86b5488121db ("debugfs: Add write support to debugfs_create_str()")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202309091933.BRWlSnCq-lkp@intel.com/
> Signed-off-by: Mike Tipton <quic_mdtipton@quicinc.com>

Reviewed-by: Georgi Djakov <djakov@kernel.org>

> ---
>   fs/debugfs/file.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c
> index 87b3753aa4b1..c45e8c2d62e1 100644
> --- a/fs/debugfs/file.c
> +++ b/fs/debugfs/file.c
> @@ -939,7 +939,7 @@ static ssize_t debugfs_write_file_str(struct file *file, const char __user *user
>   	new[pos + count] = '\0';
>   	strim(new);
>   
> -	rcu_assign_pointer(*(char **)file->private_data, new);
> +	rcu_assign_pointer(*(char __rcu **)file->private_data, new);
>   	synchronize_rcu();
>   	kfree(old);
>