Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Date:   Mon, 9 Oct 2023 19:16:28 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Lorenzo Stoakes <lstoakes@gmail.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Ian Rogers <irogers@google.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Oleg Nesterov <oleg@redhat.com>,
        Richard Cochran <richardcochran@gmail.com>,
        John Hubbard <jhubbard@nvidia.com>,
        Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 1/4] mm: make __access_remote_vm() static
Message-ID: <20231009221628.GB3952@nvidia.com>
References: <cover.1696174961.git.lstoakes@gmail.com>
 <70436dcf596565770e604a4fc4e8f27a14c85166.1696174961.git.lstoakes@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <70436dcf596565770e604a4fc4e8f27a14c85166.1696174961.git.lstoakes@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?q5lWqJbNjXSGImesy5kbTpuFiPOWO9p4g4z7sQfGAQL0mJrwzxPa9llcEM/Y?=
 =?us-ascii?Q?CbQFTiBfq/CD7VwnoyTcUe4nPNJQJyrQj0t5YUgcsT40i4KaPNcqjLpPcZDX?=
 =?us-ascii?Q?uALj0qiFT7WrPCZJgsiBS8+mp8wINJbeOK4c6fLfvPypHeDA3FeRUjn3tngg?=
 =?us-ascii?Q?Pva5okLbxHl8y52fxNWMYssRfiWNFilrUCfCEWfImr0kLKH3KCNnte2X+8CM?=
 =?us-ascii?Q?/eDQ6/rlSD1109YopO6CFhdp68ug/UuOOUSwUlMx33i6JyFcffcnGLgNHR+S?=
 =?us-ascii?Q?Kuu/26UKAC79a3xZmLDSDsI8KZnUwSgLBcegcBuXViVgo2EzOEYvGDIFq5gF?=
 =?us-ascii?Q?lyIDM5zGhmVVGDqQBXAhMC2z6zjUHuFyz5k1AQ0W/wsrXWyrXOZuNJuOe15u?=
 =?us-ascii?Q?fL/Oqc3cfhHj8KFlUINiZYOsy5Lpx9ZK95aJS77M738TXr0R/Pt3j7tPBwFd?=
 =?us-ascii?Q?W9nc8iWboDaik+ZfYUqx+QNVa7rxqCRFmAq1pWRQFl81w5Mc0RR6vscE1+kE?=
 =?us-ascii?Q?Bn+gVgc5IErRsYosS2Vdgrr2X/Cpui45mWhJBkKqcRqJC7OAhZY7vC/Ro/3e?=
 =?us-ascii?Q?OO0OB9+CELcfo6jD9HQXJ9U+zPq6Uu3XwhCBi816CSMLn/BVrUJFHdHwx8IE?=
 =?us-ascii?Q?bkjz8QgjchBueSVBbryA1fuv0EQzlXDDfb1ehNuks2K/ppIxKjiIZsca+Zcv?=
 =?us-ascii?Q?Njib7WzV9byxFgPfdKbIcqvr+rgnnbX/P6p73+Xi4vGzpafyf7uYjHysoDf/?=
 =?us-ascii?Q?+XcOw0Fum3iCl236+Z947hH/skxkzEbXJxuY6wvMgSKZBAO+aBDn0ETkgzQx?=
 =?us-ascii?Q?NYx9xE2bz5yhdeJdwiwlAS3HtcVsFgzTRprfCwQViwLdvgMjx5AUXaZRPk7G?=
 =?us-ascii?Q?EL99ZnARTnJkr1pBa0LnL7QnIW/ExFGj1TbQMQbOQfCHqJCEwG944EE4pSCt?=
 =?us-ascii?Q?omWqz33RP1jYJI3SnuA4Ire9TZpLIS2Mt7o2HSIBa2aUcDP3MgY8aW+mapYn?=
 =?us-ascii?Q?6SqfSEPYKct5lQUC2AA0+ooa4jpzbH8ZDtoi1SVw3tEGA+yPURV2ndXQIrHQ?=
 =?us-ascii?Q?BZKpNCGKpfqMezviz7gDCAH2tPARsfNyP4cYKvAWHRw+J0SlL69RhB9KjI0c?=
 =?us-ascii?Q?J1+Lk/n4uebZiPpKEYbdmGFs+ZBxWNY39iWav64/sZbhLIGdoc+6+qZMFSQp?=
 =?us-ascii?Q?PZwjy4rbFPbVjwiitOXQ1wWX/GRMunXh0Qj59bUltlOZs9vffbDE7w4X3iHN?=
 =?us-ascii?Q?V6YLK/vjW5M/g26/eCxERnYAZuJbDGylcfpiW4fj6OzwzzGsnfIpf6H8N9Or?=
 =?us-ascii?Q?tU11KoF0ZoESmnYUFTGZ4GD3dY5v4XcrraKqeanwysRqANBpsAwmZ1R/dXEP?=
 =?us-ascii?Q?hmX+RwRff7w18SdA5CmbVWnxoDdwkwJQr1Dr7OCwgeaIO7Q2R5vhK7nwzBHZ?=
 =?us-ascii?Q?P49lD6Tn0oo7qBcmSBMNyQwd+ryE1aOzxnorGltmxCQHAkoD3zRZKThYGPR6?=
 =?us-ascii?Q?mU6EnQtaM9BV2fT5sUy4ww/y5EjPkPSNnQDg6e9kFJUKZk9wEbGNBSXzlOtL?=
 =?us-ascii?Q?gP4fPf2bSSBckz4KX94=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 88792e18-32d2-4f5f-c4ba-08dbc9156303
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2023 22:16:29.7737
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6vrjoiN3uqATtwiXxFSvhza9ZjO5ggyl7xX2lykrzAacYY2ST1M2jzdhAKGYyGmE
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7243
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 09 Oct 2023 15:16:41 -0700 (PDT)
X-Spam-Level: **

On Sun, Oct 01, 2023 at 05:00:02PM +0100, Lorenzo Stoakes wrote:
> access_remote_vm() passes through parameters to __access_remote_vm()
> directly, so remove the __access_remote_vm() function from mm.h aand use
> access_remote_vm() in the one caller that needs it (ptrace_access_vm()).
> 
> This allows future adjustments to the GUP-internal __access_remote_vm()
> function while keeping the access_remote_vm() function stable.
> 
> Signed-off-by: Lorenzo Stoakes <lstoakes@gmail.com>
> ---
>  include/linux/mm.h | 2 --
>  kernel/ptrace.c    | 2 +-
>  mm/memory.c        | 4 ++--
>  mm/nommu.c         | 4 ++--
>  4 files changed, 5 insertions(+), 7 deletions(-)

Why do we even have two versions?

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason