Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Mon, 9 Oct 2023 17:14:15 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Zhaoyang Huang <huangzhaoyang@gmail.com>
Cc:     "zhaoyang.huang" <zhaoyang.huang@unisoc.com>,
        Roman Gushchin <guro@fb.com>, Minchan Kim <minchan@kernel.org>,
        Roman Gushchin <roman.gushchin@linux.dev>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, ke.wang@unisoc.com
Subject: Re: [PATCHv5] mm: optimization on page allocation when CMA enabled
Message-Id: <20231009171415.cfc26b45c2f9f4489afe16c2@linux-foundation.org>
In-Reply-To: <CAGWkznHqQHMN1QXz7os7AQTYdzc3+LEq+z2bWOzLbiseV=560A@mail.gmail.com>
References: <1683782550-25799-1-git-send-email-zhaoyang.huang@unisoc.com>
        <20231006141750.5423083520f74bc0746fd249@linux-foundation.org>
        <CAGWkznHqQHMN1QXz7os7AQTYdzc3+LEq+z2bWOzLbiseV=560A@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sun, 8 Oct 2023 15:54:40 +0800 Zhaoyang Huang <huangzhaoyang@gmail.com> wrote:

> > Roman previously asked
> >
> > : Also I'm a bit concerned about potential performance implications.
> > : Would be great to provide some benchmarks or some data.  Probably it's
> > : ok because of we have pcp caches on top, but I'm not 100% sure.
> >
> > Are you able to perform such testing and tell us the result?
> I have applied this patch in a v5.4 based ANDROID system and got no
> regression problem. Actually, this commit is aimed to have
> alloc_pages(GFP_USER) use CMA instead of stealing U&R(could lead to
> GFP_KERNEL fail) only when zone's free pages and free cma are around
> WATERMARK_LOW/MIN which would NOT affect most scenarios.

OK, thanks.

Could the appropriate people please take a look at this?  It has been
in mm-unstable since May.

Thanks.